1843694 - Intermittent accessible/tests/mochitest/textattrs/test_mathml.html | Wrong end offset for mi at offset 0 - got 2, expected 1

Status: VERIFIED FIXED

(Core :: Disability Access APIs, defect, P5)

Description

[Treeherder Bug Filer]

Filed by: ncsoregi [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=422743541&repo=try
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/B6huDWs0RvyZ92_e67IIiw/runs/0/artifacts/public/logs/live_backing.log

---

[task 2023-07-15T11:28:32.222Z] 11:28:32     INFO - TEST-PASS | accessible/tests/mochitest/textattrs/test_mathml.html | Wrong start offset for mi at offset 0 
[task 2023-07-15T11:28:32.222Z] 11:28:32     INFO - Buffered messages finished
[task 2023-07-15T11:28:32.224Z] 11:28:32     INFO - TEST-UNEXPECTED-FAIL | accessible/tests/mochitest/textattrs/test_mathml.html | Wrong end offset for mi at offset 0 - got 2, expected 1
[task 2023-07-15T11:28:32.225Z] 11:28:32     INFO - SimpleTest.is@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:507:14
[task 2023-07-15T11:28:32.225Z] 11:28:32     INFO - testTextAttrs@chrome://mochitests/content/a11y/accessible/tests/mochitest/attributes.js:203:5
[task 2023-07-15T11:28:32.226Z] 11:28:32     INFO - doTest@chrome://mochitests/content/a11y/accessible/tests/mochitest/textattrs/test_mathml.html:21:22
[task 2023-07-15T11:28:32.226Z] 11:28:32     INFO - setTimeout handler*SimpleTest_setTimeoutShim@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:920:41
[task 2023-07-15T11:28:32.227Z] 11:28:32     INFO - addA11yLoadEvent/waitForDocLoad/<@chrome://mochitests/content/a11y/accessible/tests/mochitest/common.js:179:14
[task 2023-07-15T11:28:32.227Z] 11:28:32     INFO - setTimeout handler*SimpleTest_setTimeoutShim@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:920:41
[task 2023-07-15T11:28:32.228Z] 11:28:32     INFO - waitForDocLoad@chrome://mochitests/content/a11y/accessible/tests/mochitest/common.js:169:12
[task 2023-07-15T11:28:32.228Z] 11:28:32     INFO - SimpleTest.waitForFocus/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:1056:13
[task 2023-07-15T11:28:32.229Z] 11:28:32     INFO - TEST-PASS | accessible/tests/mochitest/textattrs/test_mathml.html |  for mi at offset 0 

Comment 1

[Natalia Csoregi [:nataliaCs]]

Frédéric, this intermittent appeared on today's beta simulation and it seems to be related to Bug 1821980.

Do you have time to look into this?
Thank you.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1821980

Comment 3

[Frédéric Wang (:fredw)]

Will look into it later, but I believe the mochitest need explicitly enable mathml_legacy_mathvariant_attribute_disabled

Comment 5

[Intermittent Failures Robot]

6 failures in 3309 pushes (0.002 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• try: 6

Platform and build breakdown:

• linux1804-64-qr: 2
  • debug: 2
• linux1804-64-tsan-qr: 1
  • opt: 1
• macosx1015-64-shippable-qr: 1
  • opt: 1
• linux1804-64-devedition-qr: 1
  • opt: 1
• linux1804-64-shippable-qr: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1843694&startday=2023-07-10&endday=2023-07-16&tree=all

Comment 6

[Frédéric Wang (:fredw)]

OK so I stand corrected. test_mathml.html already explicitly sets mathml.legacy_mathvariant_attribute.disabled to true, so it should not behave differently on beta. I tried to reproduce locally by disabling the flag in StaticPrefList.yaml but that does not work indeed.

Also the failing test reported in the log here and in bug 1843761 is for

<mi id="mi" mathvariant="normal">x</mi>

In this failing run, it behaves the same as <mi id="mi_italic">x</mi> (which defaults to text-transform: math-auto and so transforms x to surrogate pair for the italic x, so the calculated end offset is 2) but it should really take into account the mathvariant="normal" attribute (which applies text-transform: none, so the character x is not transformed and the expected end offset should be 1).

@emilio @james: I'm not sure why mathvariant="normal" is ignored. I see that the flag is enabled first, then addA11yLoadEvent will do setTimeout(runTest, 0) after focus & page load. Is it possible that there is a problem in the order of flag enabling, attribute mapping, style resolution and a11y tree building? Maybe forcing a reflow would help?

@Natalia @Narcis: If we can't find an easy solution, I'd recommend disabling the test in a11y.ini for now.

Comment 7

[Emilio Cobos Álvarez (:emilio)]

I think the issue is that pushPrefEnv is async, so whether the test works relies on whether the pref has been applied before the mathvariant attribute is parsed.

If you add the pref here instead, like here, does it work?

Comment 8

[Frédéric Wang (:fredw)]

OK, I didn't know it was possible to use a prefs (or I forgot, at least it's not in https://firefox-source-docs.mozilla.org/build/buildsystem/test_manifests.html#recognized-metadata). OK I think that makes sense (attribute parsed before the pref enabled), I'll give a try.

Comment 9

[Frédéric Wang (:fredw)]

OK I uploaded https://phabricator.services.mozilla.com/D183722 which seems to work locally. However, I had to tweak testing/mochitest/runtests.py so let's see if that does not cause any issue: https://treeherder.mozilla.org/jobs?repo=try&revision=c91949d6ecfe5044c9b9fba5a4a5173504fc788d

Comment 10

[Frédéric Wang (:fredw)]

Attachment: Bug 1843694 Default a11y mochitest to runByManifest and set test_mathml pref in manifest. r=emilio

Comment 11

[Sandor Molnar[:smolnar]]

Patch seems to work in today's beta-simulation

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/00d95f017327
Default a11y mochitest to runByManifest and set test_mathml pref in manifest. r=emilio,ahal

Comment 13

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/00d95f017327

Comment 14

[Iulian Moraru]

Fix verified in today's central as early beta simulation.

Comment 15

[Intermittent Failures Robot]

3 failures in 3520 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• try: 3

Platform and build breakdown:

• macosx1015-64-qr: 1
  • debug: 1
• windows11-64-2009-qr: 1
  • debug: 1
• linux1804-64-asan-qr: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1843694&startday=2023-07-17&endday=2023-07-23&tree=all