Closed Bug 1821980 Opened 2 years ago Closed 1 year ago

Align mathvariant implementation on MathML Core

Categories

(Core :: MathML, enhancement)

Product:
Core
Component:
MathML
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
113 Branch
Tracking Flags:
Tracking Status
firefox113 --- wontfix
firefox117 --- fixed

People

(Reporter: fredw, Assigned: fredw)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

Bug 1821980: Align mathvariant implementation on MathML Core. r=emilio,jfkthame
48 bytes, text/x-phabricator-request
Details | Review
Update mathvariant WPT tests. Bug 1821980, r=emilio
48 bytes, text/x-phabricator-request
Details | Review

It's now restricted to the mi element and to value mathvariant="normal":

https://w3c.github.io/mathml-core/#the-mathvariant-attribute

Additionally, it relies on the text-transform: math-auto property to implement automatic italicization on single-char mi.

See Also: → 1817215

In MathML Core, the mathvariant attribute is now restricted to the mi
element and to value "normal". Some related WPT tests were updated in
[1]. This commit moves other tests assuming full mathvariant support
into our internal tests. It also tweaks some existing tests to only
rely on MathML Core features.

  • mathvariant-basic-transforms-with-default-font.html: This test assumes support for italic, bold and bold-italic mathvariants so move it to internal tests.
  • mathvariant-case-sensitivity.html: This one tests all mathvariant values, so move it to internal tests.
  • mathvariant-double-struck-font-style-font-weight.html: This test assumes support for double-struck mathvariant so move it to internal tests.
  • Other generated mathvariant-*.html tests for each value (other than "normal") are also moved to internal tests.
  • direction.html: Remove use of mathvariant="bold" since this test is actually testing the dir attribute.
  • presentational-hints-001.html: Verify that local author style for text-transform wins over presentation hints for mathvariant. Tweak it to use value "normal" on the mi element and text-transform: uppercase.
  • presentational-hints-002.html: This is testing dynamic setting of mathvariant. Tweak it to use value "normal" on the mi element.

[1] https://github.com/web-platform-tests/wpt/pull/38490

Pushed by fred.wang@free.fr: https://hg.mozilla.org/integration/autoland/rev/0464baff0fd7 Update mathvariant WPT tests. Bug 1821980, r=emilio
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/39077 for changes under testing/web-platform/tests

https://hg.mozilla.org/mozilla-central/rev/0464baff0fd7

Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox113: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 113 Branch
Pushed by csabou@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/24e1bae4ad6c Backed out changeset 0464baff0fd7 for wrong commit message composition. https://hg.mozilla.org/integration/autoland/rev/1ea808cbf56a Update mathvariant WPT tests. r=emilio
Upstream PR was closed without merging

Can you explain the reason for backout?

Flags: needinfo?(mlaza)

Looks like it was backed out because the commit message wasn't in the correct format and then re-landed with that fixed.

Flags: needinfo?(mlaza)

Reopening since there is still one patch to land.

Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Attachment #9322649 - Attachment description: WIP: Bug 1821980: Align mathvariant implementation on MathML Core → Bug 1821980: Align mathvariant implementation on MathML Core. r=emilio
Upstream PR was closed without merging
Attachment #9322649 - Attachment description: Bug 1821980: Align mathvariant implementation on MathML Core. r=emilio → Bug 1821980: Align mathvariant implementation on MathML Core. r=emilio,jfkthame
Pushed by fred.wang@free.fr: https://hg.mozilla.org/integration/autoland/rev/6cceaca5e653 Align mathvariant implementation on MathML Core. r=emilio,jfkthame

Thanks, it seems it's failing with non-unified build. let's try again: https://treeherder.mozilla.org/jobs?repo=try&revision=d200a97aa91281fb724a8ad799ed7cb093db41b8

Flags: needinfo?(fwang)
Pushed by fred.wang@free.fr: https://hg.mozilla.org/integration/autoland/rev/db50582c2b9f Align mathvariant implementation on MathML Core. r=emilio,jfkthame

Backed out for causing mochitest failures in browser_mathml.js

  • Backout link
  • Push with failures
  • Failure Log
  • Failure line: TEST-UNEXPECTED-FAIL | accessible/tests/browser/mac/browser_mathml.js | AXMathRootRadicand value has correct text - Got "<U+01D465>", expected "x"
Flags: needinfo?(fwang)

OK trying again with the fix for mac: https://treeherder.mozilla.org/jobs?repo=try&revision=7f49fe1b1c0e70041327ecefabfa461300398d84

Flags: needinfo?(fwang)
Pushed by fred.wang@free.fr: https://hg.mozilla.org/integration/autoland/rev/72da4ec089de Align mathvariant implementation on MathML Core. r=emilio,jfkthame

https://hg.mozilla.org/mozilla-central/rev/72da4ec089de

Status: REOPENED → RESOLVED
Closed: 2 years ago → 1 year ago
status-firefox117: --- → fixed
Resolution: --- → FIXED
Regressions: 1843694
Regressions: 1843761

Is this something we wanted to call out in the Fx117 relnotes?

Flags: needinfo?(fwang)

Flag is currently only true on nightly, so we don't need relnotes yet I believe.

Flags: needinfo?(fwang)
Upstream PR merged by moz-wptsync-bot
Blocks: 1845461

(In reply to Frédéric Wang (:fredw) from comment #24)

Flag is currently only true on nightly, so we don't need relnotes yet I believe.

I opened bug 1845461 to prepare turning on the flag in beta/release.

Blocks: 1846482
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/412365ddbdba [wpt PR 39077] - [Gecko Bug 1821980] Update mathvariant WPT tests. Bug 1821980, a=testonly
Depends on: 1866693
No longer depends on: 1866693
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: