1843700 - Bookmarks menu stays open after minimize the window

Status: VERIFIED FIXED

(Core :: XUL, defect)

Description

[Ronny]

Attachment: transparency.jpg

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:109.0) Gecko/20100101 Firefox/115.0

Steps to reproduce:

Customize Toolbar -> add Bookmarks menu to the Toolbar. Open the Bookmarks menu an with the menu open minimize the Firefox window.

Actual results:

Like seen on the screenshot the Bookmarks menu stays on top at around 50% transparency. It will stay over any program. Clicking on this bugging Boormark menu will force it to close.

Expected results:

This bug was not there a few weeks ago.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Firefox::Bookmarks & History' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:mak, could you have a look please?

For more information, please visit BugBot documentation.

Comment 3

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

Hello, thank you for the bug report!
Unfortunately I could not reproduce your issue. Would you be so kind as to answer a few questions so we can investigate this further?

• Does this issue happen with a new profile? Here is a link on how to create one: https://support.mozilla.org/en-US/kb/profile-manager-create--remove-switch-firefox-profiles
• Does this issue happen with latest nightly? Here is a link from where you can download it: https://www.mozilla.org/en-US/firefox/channel/desktop/
• Does this issue happen when Firefox is in Troubleshoot Mode? Here’s a link on how to enable it: https://support.mozilla.org/en-US/kb/diagnose-firefox-issues-using-troubleshoot-mode#w_how-to-start-firefox-in-troubleshoot-mode

Comment 4

[Ronny]

Attachment: win10x64_ff_nightly.png

Comment 5

[Ronny]

Attachment: win11x64_ff_nightly.png

Comment 6

[Ronny]

Attachment: ff_nightly.png

Comment 7

[Ronny]

Hi,

Does this issue happen with a new profile?
Yes, even with a new profile the bug is there.

Does this issue happen with latest nightly?
Yes, see the last attachments, did happen with the latest nightly too.

Does this issue happen when Firefox is in Troubleshoot Mode?
Yes, did happen even in Troubleshoot Mode.

I did test it even on my wifes pc, she runs Win11 x64 and i run Win10 x64.
Like you see in the attachment, the same bug did happen on her pc too.

All i did was:

Install the fresh FF Nightly
Rightclick -> Customize Toolbar
Drag the "Bookmarks menu" to the Toolbar
Click on "Done"
Leftclick on "Show you bookmarks"
Press the "minimize to Taskbar" Button

Comment 8

[Ronny]

I did some research when the bug first appeared, so i installed all FF portable editions from 110.0 onwards.

Any version till 113.0.2 was working fine, on version 114.0.0 and up the bug is present.

So it did happen with the 114 release, hope this helps a little bit to pinpoint the error ;)

Comment 9

[Marco Bonardo [:mak]]

Thank you for doing the first regression range. Rather than installing portable versions, we can provide a better method to do it.
See https://mozilla.github.io/mozregression/, that software downloads builds for you, and let you reproduce the bug marking each build as good or bad, until you reach the exact change that caused the bug.
Since you already identified 113 as good and 114 as bad, you can pass --good 113 --bad 114 to only bisect between those 2 versions.

As a last thing, I'd ask if you could please attach a txt log from about:support page to this bug report, so we can check notable preferences and graphics information.

Comment 10

[Ronny]

Attachment: ff_txtlog.txt

Comment 11

[Daniel Bodea [:danibodea]]

I managed to reproduce this issue with the information provided in comment 7.

Regression investigation result:
2023-08-11T16:39:05.386000: DEBUG : Found commit message:
Bug 1828587 - Don't paint or refresh animated images on throttled refresh drivers. r=smaug

As the compositor might be paused. We don't really want to queue a bunch
of paints that are never going to be visible.

Differential Revision: https://phabricator.services.mozilla.com/D176213

Comment 12

[BugBot [:suhaib / :marco/ :calixte]]

:emilio, since you are the author of the regressor, bug 1828587, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 13

[Timothy Nikkel (:tnikkel)]

This sounds very similar to bug 1832384 and bug 1843205 which are both fixed.

Comment 14

[Emilio Cobos Álvarez (:emilio)]

Huh, wtf. I'm pretty sure I sent a patch for this...

Comment 15

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1843700 - Hide popups synchronously if needed, even if already hiding async. r=tnikkel,cmartin,stransky

Comment 16

[Emilio Cobos Álvarez (:emilio)]

Alright, I goofed the bug #, whoops :)

Comment 17

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1828587

Comment 18

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:enndeakin, could you have a look please?

For more information, please visit BugBot documentation.

Comment 19

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/523189f103b0
Hide popups synchronously if needed, even if already hiding async. r=NeilDeakin

Comment 20

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/355e2b268611
Temporarily annotate HidePopupCallback as script boundary.

Comment 21

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/523189f103b0
https://hg.mozilla.org/mozilla-central/rev/355e2b268611

Comment 22

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:emilio, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox118 to wontfix.

For more information, please visit BugBot documentation.

Comment 23

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 9348934 [details]
Bug 1843700 - Hide popups synchronously if needed, even if already hiding async. r=tnikkel,cmartin,stransky

Beta/Release Uplift Approval Request

• User impact if declined: comment 0
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: comment 0
• List of other uplifts needed: (the second patch in the bug needs uplift too)
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Relatively simple / straight-forward fix.
• String changes made/needed: none
• Is Android affected?: No

Comment 24

[Pascal Chevrel:pascalc]

Comment on attachment 9348934 [details]
Bug 1843700 - Hide popups synchronously if needed, even if already hiding async. r=tnikkel,cmartin,stransky

Approved for 118.0b6, thanks.

Comment 25

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/7f6fae3e45f7
https://hg.mozilla.org/releases/mozilla-beta/rev/bf1c8b3b1322

Comment 26

[Pascal Chevrel:pascalc]

https://hg.mozilla.org/releases/mozilla-beta/rev/7f6fae3e45f7
https://hg.mozilla.org/releases/mozilla-beta/rev/bf1c8b3b1322

Comment 27

[Hani Yacoub, Desktop QA]

Verified as fixed on Windows 10 x64 and on Windows 11 x64 on Firefox Nightly 119.0a1(2023-09-07).

Comment 28

[Hani Yacoub, Desktop QA]

Verified as fixed on Windows 10 x64 and on Windows 11 x64 on Firefox 118.0b6.

Comment 29

[Pascal Chevrel:pascalc]

Comment on attachment 9348934 [details]
Bug 1843700 - Hide popups synchronously if needed, even if already hiding async. r=tnikkel,cmartin,stransky

Approved for ESR 115.3, thanks.

Comment 30

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-esr115/rev/6c23b6cc5af8
https://hg.mozilla.org/releases/mozilla-esr115/rev/2ba2649ea65e

Comment 31

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9348934 [details]
Bug 1843700 - Hide popups synchronously if needed, even if already hiding async. r=tnikkel,cmartin,stransky

Approved for 117.0.1

Comment 32

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-release/rev/e007eac02b9c
https://hg.mozilla.org/releases/mozilla-release/rev/ebe0eceaaffc

Comment 33

[Ryan VanderMeulen [:RyanVM]]

Added to the 117.0.1 release notes:

Fixed the bookmarks menu sometimes remaining partially visible when minimizing Firefox

Comment 34

[Hani Yacoub, Desktop QA]

Verified as fixed on Windows 10 x64 and on Windows 11 x64 on Firefox 117.0.1.

Comment 35

[Ronny]

(In reply to Hani Yacoub, Desktop QA from comment #34)

Verified as fixed on Windows 10 x64 and on Windows 11 x64 on Firefox 117.0.1.

can confirm, finally fixed ;)

Comment 36

[Anca Soncutean, Desktop QA]

Verified fixed with ESR 115.3 on Windows 10 and macOS 13.