1843704 - Sessions should remain when Add-on is updated / reinstalled

Status: RESOLVED FIXED

(Thunderbird :: Add-Ons: Extensions API, defect)

Description

[Axel Grude]

I am using sessions.setTabValue to store the currently selected Categories for my Add-on QuickFolders. This works well for a restart of THunderbird, so that I can restore this tab specific data.

However: I install a newer version (or the Add-on is updated or temporarily disabled during the session) - this data is purged and my Add-on cannot recover. THis is not useful and unexpected. Instead Thunderbird should tidy up this data when it shuts down:

• if the Add-on is uninstalled or disabled, Thunderbird can delete the data on shutdown. It should however be persistent during the session so that the Add-on can restart / updated / be disabled / enabled without any missing persisted data. Otherwise the Add-on is forced to implement it's own Tab Monitor / Model to store this elsewhere - which defeats the purpose of a "Sessions" API.

Comment 1

[John Bieling (:TbSync)]

Attachment: Bug 1843704 - Clear session data only on uninstall. r=#thunderbird-reviewers

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/45727bef2adf
Clear session data only on uninstall. r=elizabeth

Comment 3

[John Bieling (:TbSync)]

Comment on attachment 9344643 [details]
Bug 1843704 - Clear session data only on uninstall. r=#thunderbird-reviewers

[Approval Request Comment]
Regression caused by (bug #):
User impact if declined:
The Session API will not retain data on disable/enable or updates

Testing completed (on c-c, etc.): A few days on daily
Risk to taking this patch (and alternatives if risky):
Low. We moved the cleanup from shutdown to uninstall.

Comment 4

[Wayne Mery (:wsmwk)]

Comment on attachment 9344643 [details]
Bug 1843704 - Clear session data only on uninstall. r=#thunderbird-reviewers

[Triage Comment]
Approved for beta

Comment 5

[John Bieling (:TbSync)]

Comment on attachment 9344643 [details]
Bug 1843704 - Clear session data only on uninstall. r=#thunderbird-reviewers

[Approval Request Comment]
Regression caused by (bug #):
User impact if declined:
The Session API will not retain data on disable/enable or updates

Testing completed (on c-c, etc.): A few days on beta
Risk to taking this patch (and alternatives if risky):
Low. We moved the cleanup from shutdown to uninstall.

Comment 6

[Wayne Mery (:wsmwk)]

Comment on attachment 9344643 [details]
Bug 1843704 - Clear session data only on uninstall. r=#thunderbird-reviewers

[Triage Comment]
Approved for esr115

This didn't make the beta, so it will appear in 117 beta. It's only narrowing the scope, so approving for 115.

Comment 7

[Rob Lemley [:rjl]]

Thunderbird 115.1.0:
https://hg.mozilla.org/releases/comm-esr115/rev/7bb4d3bb31f2