1843707 - From field in message compose is too narrow

Status: RESOLVED FIXED

(Thunderbird :: Message Compose Window, defect)

Description

[Michal Kochanowicz]

Attachment: thunderbird-from-field-too-narrow.png

Steps to reproduce:

Created new message. Edited "from" field and entered custom email address.

Actual results:

"From" field is too narrow, I can't tell which address is there.

Expected results:

Field should be wide enough to read it's value.

Comment 1

[Michal Kochanowicz]

Attachment: Before and after entering custom address into "From" field.

Comment 2

[Richard Marti (:Paenglab)]

Emilio, I think, this is a new-flex issue. I looked at this but didn't find a solution. Maybe you know how to fix this?

To see this you can click on the dropdown arrow and choose "Customize From Address...".

Comment 3

[Emilio Cobos Álvarez (:emilio)]

So this is because you're replacing the label-box by an <input>, and the <input> doesn't size to its contents.

Do you know what was the pre-xul behavior? Any reason why this isn't just flex: 1 auto? I think that makes the menulist take all the available space and should fix this.

Comment 4

[Richard Marti (:Paenglab)]

(In reply to Emilio Cobos Álvarez (:emilio) from comment #3)

So this is because you're replacing the label-box by an <input>, and the <input> doesn't size to its contents.

Do you know what was the pre-xul behavior? Any reason why this isn't just flex: 1 auto? I think that makes the menulist take all the available space and should fix this.

Many thanks, this fixes the issue. The pre-xul behaviour was like with the fix: the menulist uses the whole available width. In bug 1817302 this was changed to use only the width of the content which probably ended in this issue.

Now I need to look if I can fix this and also the different position of the dropmarker when changing to the input mode.

Comment 5

[Richard Marti (:Paenglab)]

Attachment: Bug 1843707 - Make the customize from address input as wide as the menulist text. r=#thunderbird-front-end-reviewers

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/6faeed02e049
Make the customize from address input as wide as the menulist text. r=elizabeth

Comment 8

[Richard Marti (:Paenglab)]

Comment on attachment 9346357 [details]
Bug 1843707 - Make the customize from address input as wide as the menulist text. r=#thunderbird-front-end-reviewers

[Approval Request Comment]
User impact if declined: in composer when changing the from address to editable it shrinks
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): low

Comment 9

[Wayne Mery (:wsmwk)]

Comment on attachment 9346357 [details]
Bug 1843707 - Make the customize from address input as wide as the menulist text. r=#thunderbird-front-end-reviewers

[Triage Comment]
Approved for esr115

Comment 10

[Daniel Darnell [:dandarnell]]

Thunderbird 115.2.1:
https://hg.mozilla.org/releases/comm-esr115/rev/079b6f43c5ce