Closed Bug 1843760 Opened 2 years ago Closed 2 years ago

Update SeaMonkey website for 2.53.17 Final release

Categories

(SeaMonkey :: Website, task)

Production

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: frg, Assigned: ewong)

References

Details

(Whiteboard: SM2.53.17)

Attachments

(1 file, 4 obsolete files)

+++ This bug was initially created as a clone of Bug #1837262 +++

The usual. Add news download section and release notes.

Attached patch website1.patch (obsolete) — Splinter Review
Assignee: nobody → ewong
Attachment #9346444 - Flags: review?(iannbugzilla)
Comment on attachment 9346444 [details] [diff] [review] website1.patch >+++ b/lib/sitemap.xml > <page url="releases/2.53.17b1" title="2.53.17 Beta 1" id="2.53.17b1" hide="false"> > <page url="releases/seamonkey2.53.17/" title="Release Notes" id="seamonkey2.53.17"/> > </page> This should become: <page url="releases/2.53.17b1" title="2.53.17 Beta 1" id="2.53.17b1" hide="true"/> >+++ b/src/news.en.xml >@@ -7,6 +7,32 @@ http://www.damowmow.com/portal/ (use the "Indentify" field) >+ <entry id="2023-07-31" showfront="true"> >+ <headline>SeaMonkey 2.53.17 released</headline> >+ <content type="html" xml:lang="en"> >+<![CDATA[<p> >+SeaMonkey 2.53.17 is >+<a href="releases/2.53.17">now available for free download</a> on the >+SeaMonkey website. >+</p> >+<p> >+2.53.17 will be an incremental update on the 2.53.x branch and incorporates a >+number of enhancements, changes and fixes to the application as well as those >+from the underlying platform code. Preliminary support for logical assignment >+operators has been added. Support for the obsolete e4x for each iterator has >+been removed, this might affect old add-ons. Python 2 is no longer required to >+build SeaMonkey. <b>Before installing the new version make a full backup of >+your profile and thoroughly read and follow the >+<a href="releases/seamonkey2.53.17/">Release Notes</a></b>. We encourage >+testers to <a href="dev/get-involved">get involved</a> in discussing and >+reporting problems as well as further improving the product. >+</p> >+<p> >+SeaMonkey 2.53.17 is available in 23 languages, for Windows, macOS x64 >+and Linux. >+</p>]]> >+ </content> >+ </entry> The seems to be a copy of the 2.53.17b1 entry, it should be something like: +<![CDATA[<p> +The SeaMonkey project is proud to present SeaMonkey 2.53.17: The new release of +the all-in-one Internet suite is +<a href="http://www.seamonkey-project.org/releases/">available for download +now</a>! 2.53.17 is an incremental update from the 2.53.x branch and +incorporates a number of changes as well as fixes from the underlying platform +code. +</p> +<p> +There is now preliminary support for logical assignment operators. Support for +the obsolete e4x for each iterator has been removed, this might affect old +add-ons. Python 2 is no longer required to build SeaMonkey. +</p> +<p> +SeaMonkey 2.53.17 is available in 23 languages, for Windows, macOS x64 and +Linux. +</p> +<p> +<b>Automatic upgrades from previous 2.53.x versions are enabled for this +release, but if you have problems with it upgrading or you need to upgrade from +a version earlier than 2.53.5, please download the full installer from the +downloads section and install SeaMonkey 2.53.17 manually over the previous +version.</b><br> +</p> +<p> +For a more complete list of major changes in SeaMonkey 2.53.17, see the +<a href="releases/seamonkey2.53.17/#new">What's New in SeaMonkey 2.53.17</a> +section of the <a href="releases/seamonkey2.53.17/">Release Notes</a>, which +also contain a list of known issues and answers to frequently asked questions. +For a more general overview of the SeaMonkey project (and <a +href="doc/screenshots">screen shots</a>!), visit <a +href="https://www.seamonkey-project.org/">www.seamonkey-project.org</a>. +</p> +<p> +We encourage users to <a href="dev/get-involved">get involved</a> in discussing +and reporting problems as well as further improving the product. +</p>]]> + </content> + </entry> >+++ b/src/releases/index.en.html >@@ -199,7 +199,9 @@ for Legacy Platforms</a>. > <div class="para" id="old"> > <p>Previously released versions of SeaMonkey:</p> > <ul class="snav"> >- <!-- <li><a href="2.53.17b1">2.53.17 Beta 1</a></li> --> >+ <!-- <li><a href="2.53.17b1">2.53.17 Beta 1</a></li> >+ <li><a href="2.53.17">2.53.16</a></li> --> >+ <li><a href="2.53.17b1">2.53.17 Beta 1</a></li> This should be: - <!-- <li><a href="2.53.17b1">2.53.17 Beta 1</a></li> --> + <!-- <li><a href="2.53.17">2.53.17</a></li> --> + <li><a href="2.53.17b1">2.53.17 Beta 1</a></li> You are missing the changes to the source code links. You also need to update the following files to warn those versions are now out of date: src/releases/2.53.16.en.html src/releases/2.53.16b1.en.html You also need to create src/releases/2.53.17.en.html from src/releases/2.53.17b1.en.html and update version, release date and source code links. See https://bug1824833.bmoattachments.org/attachment.cgi?id=9325517 for what was done for the 2.53.16 release r- as lots still to be fixed and I want to see the new version.
Attachment #9346444 - Flags: review?(iannbugzilla) → review-
Attached patch website1.patch (obsolete) — Splinter Review

Updated patch.

Attachment #9346444 - Attachment is obsolete: true
Attachment #9346583 - Flags: review?(iannbugzilla)
Comment on attachment 9346583 [details] [diff] [review] website1.patch >+++ b/lib/sitemap.xml >+ <page url="releases/2.53.17b1" title="2.53.17 Beta 1" id="2.53.17b1" hide="true"> >+ <page url="releases/seamonkey2.53.17/" title="Release Notes" id="seamonkey2.53.17"/> >+ </page> This bit should just be: + <page url="releases/2.53.17b1" title="2.53.17 Beta 1" id="2.53.17b1" hide="true"/> >+++ b/src/news.en.xml >+ <entry id="2023-06-20" showfront="false"> > <headline>SeaMonkey 2.53.17 Beta 1 released</headline> > <content type="html" xml:lang="en"> We leave the beta release announcement showing until the next beta release, so don't change this. >diff --git a/src/releases/2.53.17.en.html b/src/releases/2.53.17.en.html >new file mode 100644 >index 0000000..50bf0b7 >--- /dev/null >+++ b/src/releases/2.53.17.en.html This seems to be correct but shows better if you create the patch against a hg rather a git repo or at least attach a diff between the source and new files to show the changes. >+++ b/src/releases/index.en.html > <p>Previously released versions of SeaMonkey:</p> > <ul class="snav"> > <!-- <li><a href="2.53.17b1">2.53.17 Beta 1</a></li> --> >+ <!-- <li><a href="2.53.17">2.53.16</a></li> --> >+ <li><a href="2.53.17b1">2.53.17 Beta 1</a></li> This still doesn't seem to be correct, it should be: - <!-- <li><a href="2.53.17b1">2.53.17 Beta 1</a></li> --> + <!-- <li><a href="2.53.17">2.53.17</a></li> --> + <li><a href="2.53.17b1">2.53.17 Beta 1</a></li> Lots better, but still would like to review the next patch (with updated dates) so r-
Attachment #9346583 - Flags: review?(iannbugzilla) → review-
Attached patch bug_1843760.diff (obsolete) — Splinter Review

Updated patch.. this time, using mercurial repo

Attachment #9346583 - Attachment is obsolete: true
Attachment #9346857 - Flags: review?(iannbugzilla)

Comment on attachment 9346857 [details] [diff] [review]
bug_1843760.diff

/src/news.en.xml

+</p>
+There is now preliminary support

This should be a <p>

diff --git a/src/releases/2.53.17.en.html b/src/releases/2.53.17.en.html
new file mode 100644
--- /dev/null

Should be copied from the beta file with hg rename to preserve history and then changed. See 2.53.16 patch in Bug 1824833

Otherwise I think it is fine.

Attachment #9346857 - Flags: feedback+

Comment on attachment 9346857 [details] [diff] [review]
bug_1843760.diff

Clearing r? for next patch, see frg's comments.

Attachment #9346857 - Flags: review?(iannbugzilla)
Attached patch bug_1843760.diff (obsolete) — Splinter Review

Updated patch for review.

Attachment #9346857 - Attachment is obsolete: true
Attachment #9347065 - Flags: review?(iannbugzilla)

Comment on attachment 9347065 [details] [diff] [review]
bug_1843760.diff

Looks good to me, other than a couple typos in the news entry: "availabe", and "SaMonkey".

There's also an "ealier" between these two that I didn't notice.

Attachment #9347065 - Flags: feedback+
Attached patch bug_1843760.diffSplinter Review

Updated patch w/ nits and fixed the hg rename to hg copy.

Attachment #9347065 - Attachment is obsolete: true
Attachment #9347065 - Flags: review?(iannbugzilla)
Attachment #9347110 - Flags: review?(iannbugzilla)

Comment on attachment 9347110 [details] [diff] [review]
bug_1843760.diff

Looks good. r+. If there are further minor issues just doing an addendum later.

Release date 07/31 needs to be adjusted before push.

Attachment #9347110 - Flags: review?(iannbugzilla) → review+
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Blocks: 1853566
Blocks: 1867974
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: