184380 - Add a talkback menu item

Status: RESOLVED INVALID

(SeaMonkey :: UI Design, enhancement)

Description

[timeless]

So, everyone asks "how do i use talkback"? "where is talkback?" and similar

questions.



At the risk of adding a menuitem which is useless in cvs builds and useless

on any platform that doesn't support talkback, I'm proposing a patch which

adds a talkback menuitem.



Clicking the item will do one of three things:

1. Run talkback 

2. Offer to install talkback

3. throw a js exception if your platform isn't supported



I could make 3 smarter if a reviewer demands it, but I think that this patch

would be a really great feature and I think it's worth adding ASAP.



I think I'd probably just set the menuitem so that it is hidden or disabled

for unsupported platforms.

Comment 1

[Grey Hodge (jX)]

Attachment: Patch as worked up by timeless

Works great, nothing breaks, handy and useful, and thanks to the UI team's hard
work and dedication, it'll never go anywhere...

But it's here, and still good...

Comment 2

[Jo Hermans]

*** Bug 129950 has been marked as a duplicate of this bug. ***

Comment 3

[Daniel Bratell]

Comment on attachment 108723 [details] [diff] [review]
Patch as worked up by timeless

+    throw "Unsupported paltform";

spelling.

Comment 4

[Henrik Gemal]

a new patch should be produced.

Comment 5

[Grey Hodge (jX)]

Attachment: Spell checked and corrected patch

Comment 6

[Henrik Gemal]

looks good.
BTW: According to bug 116934:
"We are very close to shipping new Talkback Client."

perhaps we should make sure that it still called talkback.exe

Comment 7

[Grey Hodge (jX)]

Request for filename info posted in that bug. We'll wait and see...

Comment 8

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 110860 [details] [diff] [review]
Spell checked and corrected patch

+  var osstuff;
that's a really bad variable name, maybe name it "tbinfo"?

+    throw "Unsupported Platform";
it would be better if the user would actually see the message...
maybe put a try..catch(e) around the function and alert(e);
(or rather, nsIPromptservice for the alert)

+    osstuff={app:"talkback.exe",dir:"windows"};
a few spaces in here would look good

+  var
compdir=Components.classes["@mozilla.org/file/directory_service;1"].createInsta
nce(Components.interfaces.nsIProperties).get("ComsD",Components.interfaces.nsIF
ile);
line too long and missing spaces...
same for next line

+    process.run(false, [], 0, {});
the function signature has changed (,{} should be removed)

spaces are missing on the entire last part of this function

+  const
pieces=reader.read(reader.available()).match(/(\d{4})(\d{2})(\d{2})(\d{2})/);
this will fail miserably for self-compiled builds... maybe you should catch
that somehow.
also, is the build id always the same as the directoryname? I seem to remember
that it's off a bit, but I may be wrong...

+  window.open(talkbackurl);
use loadURI here? you don't really want a new window, which would be empty
because it's no displayable document.

Comment 9

[timeless]

*** Bug 192338 has been marked as a duplicate of this bug. ***

Comment 10

[Christian :Biesinger (don't email me, ping me on IRC)]

*** Bug 239513 has been marked as a duplicate of this bug. ***

Comment 11

[Henrik Gemal]

should we port and simplify this patch so that if talkback is installed in
Firefox and Thunderbird we could add the Menuitem.

I dont think asking to install it should be a part of this bug.

Comment 12

[Jesse Ruderman]

The "Nightly Tester Tools" extension includes this feature.

http://users.blueprintit.co.uk/~dave/web/firefox/buildid/nightly.html

Comment 13

[Philip Chee]

Talkback is not used on trunk. We now use breakpad.