1843895 - Android App Links deeplink blocked (Custom Tabs)

Status: RESOLVED FIXED

(Firefox for Android :: App Links, defect)

Description

[Rodrigo Marenco]

Attachment: device-2023-07-17-112500.mp4

+++ This bug was initially created as a clone of Bug #1809264 +++

Hi Firefox team!
I can still reproduce the cloned bug that was marked as closed (I've attached a video).
I still need to manually select the "Open in App" option from the menu in order to handle the App Link.
I'm using Firefox v115.2.0 on Android, with it selected as the default browser.
Affected app is using Custom Tabs for OAuth 2.0 flow.

Steps to reproduce, Expected Behavior and Actual Behavior are the same as in https://bugzilla.mozilla.org/show_bug.cgi?id=1809264

Device Information
Google Pixel 4a running Android 13

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:royang, could you have a look please?

For more information, please visit BugBot documentation.

Comment 2

[Roger Yang [:royang]]

Hi :Rodrigo Marenco, there was a recent fix with https://bugzilla.mozilla.org/show_bug.cgi?id=1845104. Can you please check with Firefox Nightly that this issue is fixed? Thanks

Comment 3

[Rodrigo Marenco]

(In reply to Roger Yang [:royang] from comment #2)

Hi :Rodrigo Marenco, there was a recent fix with https://bugzilla.mozilla.org/show_bug.cgi?id=1845104. Can you please check with Firefox Nightly that this issue is fixed? Thanks

Hi Roger!
I've just tried with the current version of Firefox Nightly and I get the same result, I either need to select from the 3 dot menu "Open in App" for this flow to work, or previously set the "Open links in apps" setting to "Always" (this settings defaults to "Never" on a fresh install).

Any thoughts?

Comment 4

[Cam Bortlemo]

(In reply to Roger Yang [:royang] from comment #2)

Hi :Rodrigo Marenco, there was a recent fix with https://bugzilla.mozilla.org/show_bug.cgi?id=1845104. Can you please check with Firefox Nightly that this issue is fixed? Thanks

The (1845104) flow used a custom scheme (digiposte://) callback to the app, the reported bug here uses the more secure and reliable Android App-Link callback to the app.

I confirmed on Nightly 118.0a1, that FF tabs don't honor app-link callbacks from FF tabs for OAuth type login flows. The user has to execute the manual steps described by Rodrigo above to trigger the native app.

Comment 5

[Roger Yang [:royang]]

Looks like it's similar to https://bugzilla.mozilla.org/show_bug.cgi?id=1843537. User have "Never" set in "Open links in app". This is a conflict between respecting user option vs usability (https://bugzilla.mozilla.org/show_bug.cgi?id=1836971). I'm reverting the enforcement of "Never" in order to allow authentication flow to work. I'll update once revert has landed.

Comment 6

[Roger Yang [:royang]]

Investigated the issue. I've confirmed that there was an issue with the fix https://bugzilla.mozilla.org/show_bug.cgi?id=1845104.
I'll have a fix for this. Thanks

Comment 7

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1843895 - Update AppLinksUseCases launchInApp when updating the interceptor (#3122)

Comment 8

[BMO Github Automation]

Authored by https://github.com/rocketsroger
https://github.com/mozilla-mobile/firefox-android/commit/b6089b0a02141a4147dbb1cf541b7c6134e135df
[main] Bug 1843895 - Update AppLinksUseCases launchInApp when updating the interceptor

Comment 9

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1843895 - Update AppLinksUseCases launchInApp when updating the interceptor (backport #3122) (#3194)

Comment 10

[Roger Yang [:royang]]

Comment on attachment 9348264 [details] [review]
[mozilla-mobile/firefox-android] Bug 1843895 - Update AppLinksUseCases launchInApp when updating the interceptor (backport #3122) (#3194)

Beta/Release Uplift Approval Request

• User impact if declined: User won't be able to sign into applications through Firefox Android
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): It's a very small change and only applies to custom tab
• String changes made/needed:
• Is Android affected?: Yes

Comment 11

[Dianna Smith [:diannaS]]

Comment on attachment 9348264 [details] [review]
[mozilla-mobile/firefox-android] Bug 1843895 - Update AppLinksUseCases launchInApp when updating the interceptor (backport #3122) (#3194)

Approved for Mobile 117.0b6

Comment 12

[BMO Github Automation]

Authored by https://github.com/mergify[bot]
https://github.com/mozilla-mobile/firefox-android/commit/d7b7cdff1e20dc11170549d8e306b1238cc09283
[releases_v117] Bug 1843895 - Update AppLinksUseCases launchInApp when updating the interceptor (#3194)

Comment 13

[Adina Petridean QA [:apetridean]]

Verified as fixed on 1170b6 from 08/11 with: Google Pixel 6 (Android 14)
Samsung GalaxyZ Fold 4 (Android 13)
Lenovo Yoga Tab 11 (Android 12)
No errors are encountered during 2-factor authentication, and the user can successfully log in from a custom tab with "Open links in app" set to "Never."
Device used for Nightly 118.0a1 - 11.08.2023 : Google Pixel 7 PRO (Android 14)