184394 - Allow drop-in pref panes

Status: RESOLVED FIXED

(Camino Graveyard :: Preferences, enhancement)

Description

[Stephane Moureau]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X; en-US; rv:1.0.1) Gecko/20021206 Chimera/0.6+
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X; en-US; rv:1.0.1) Gecko/20021206 Chimera/0.6+

Would it be possible to have the possibility to create third-party extensions
that can be put inside and Add-on folder ?

Simon Fraser mentions that in Bug 155315 Comment #24
but I was not able to find additional information.

Thank you for such a great program.

Reproducible: Always

Steps to Reproduce:

Comment 1

[Sören 'Chucker' Kuklau (gone)]

Well, no need for this bug right now, as there *is* no add-on "facility", as
Simon calls it, so far.

Comment 2

[Stephane Moureau]

That's why it's a RFE!

Comment 3

[Sören 'Chucker' Kuklau (gone)]

From the summary, this bug appeared to be about a *folder* to put existant
add-ons in. Changing...

Comment 4

[Stephane Moureau]

See bug 159336 comment 17.

Comment 5

[Simon Fraser [no longer active]]

We should just have some way that users can install additional pref panes. It
should be possible for a user to drop in a pref pane in a user-modifiable
folder, or in the Navigator package.

Comment 6

[Simon Fraser [no longer active]]

*** Bug 193900 has been marked as a duplicate of this bug. ***

Comment 7

[S Woodside]

Seems like a reasonable idea. Could be a folder like [~]/Library/Application
Support/Chimera/PrefPanes

Comment 8

[Jasper]

Bump.

I really think this could boost our popularity. 3d party developers could start
making prefpanes. Add a good tutorial and it would make it even better. We need
something to stand out from Omni and Safari.

Comment 9

[S Woodside]

that do what?

Comment 10

[Jasper]

To allow them to make custom prefpanes for add blocking or setting preferences
we haven't made a UI for.

Comment 11

[Simon Fraser [no longer active]]

Attachment: Changes to allow for drop-in pref panes

This patch allows us to pick up pref panes from
~/Library/Camino/PreferencePanes, and /Library/Camino/PreferencePanes.

Additional pref panes in the Camino bundle should also work.

Comment 12

[L. H.]

Shouldn't it be (~)/Library/Application Support/Camino/PreferencePanes?

Comment 13

[Simon Fraser [no longer active]]

Concensus is to use (~)/Library/Application Support/Camino/PreferencePanes for
the pane locations. Assume that when reading the patch.

Comment 14

[Mike Pinkerton (not reading bugmail)]

-	NSMutableArray*         mPanes;         // array of PreferencePaneBase
+	NSMutableArray*         mPaneBundles;   // array of NSBundle*

ugh, this file has tabs all over :(

+    NSString* userLibPath = @"~/Library/Camino/PreferencePanes";

should this be localized?

looks ok, but i didn't give it a very thorough review. my only concern would be
impact on startup time, but that's probably tiny. what happens when someone
installs a whole bunch? i guess the toolbar just overflows?

r=pink

Comment 15

[Simon Fraser [no longer active]]

Fixed. I use FindFolder() to get the "Application Support" dirs, and get
"Camino" from the plist, just like our profile code.

Comment 16

[Hiro]

The beach ball goes out when Preference is chosen from the menu and it hangs up. 
There is no problem when this patch is removed. 
http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=Camino&branch=HEAD&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2005-03-05+22%3A56&maxdate=2005-03-05+22%3A56&cvsroot=%2Fcvsroot

Mac OS X 10.3.8
2005030721 (v0.8+)

Comment 17

[Simon Fraser [no longer active]]

Please run ThreadViewer or Sampler to get a stack trace for the hang.

Comment 18

[Hiro]

It is stack trace obtained with ThreadViewer.
And sorry, this patch might have been unrelated. 

+[NSData dataWithBytesNoCopy:length:]
-[NSFileManager fileSystemRepresentationWithPath:]
-[NSString(NSWorkspaceStatic) _getFSRefForPath:]
-[NSWorkspace iconForFile:]
-[OrgMozillaChimeraPreferenceNavigation updateDefaultBrowserMenu]
-[OrgMozillaChimeraPreferenceNavigation updateDefaultBrowserMenu]
-[OrgMozillaChimeraPreferenceNavigation updateDefaultBrowserMenu]
-[OrgMozillaChimeraPreferenceNavigation updateDefaultBrowserMenu]
-[OrgMozillaChimeraPreferenceNavigation updateDefaultBrowserMenu]
-[OrgMozillaChimeraPreferenceNavigation updateDefaultBrowserMenu]
-[OrgMozillaChimeraPreferenceNavigation updateDefaultBrowserMenu]

The problem might occur by following step. 
1. Camino is set in a default browser. 
2. The name of Camino is changed. 
   ex) Camino --> Camino-save
   A default browser becomes Camino-save here. 
3. Camino of a new version is installed. 
4. Camino-save is put in Trash.
5. start Camino and select Preferences.

Comment 19

[Simon Fraser [no longer active]]

This is caused by the fix for bug 218271, not this bug.