Closed
Bug 1843957
Opened 2 years ago
Closed 2 years ago
Investigate if letter grade component should be added to allowlist in `browser_all_files_referenced.js`
Categories
(Firefox :: Shopping, task, P3)
Firefox
Shopping
Tracking
()
RESOLVED
WORKSFORME
People
(Reporter: kpatenio, Unassigned)
References
Details
(Whiteboard: [fidefe-shopping])
Bug 1839730 was backed out due to a failure in browser/base/content/test/static/browser_all_files_referenced.js. browser_all_files_referenced.js allows us add some exceptions for shopping components.
The letter grade component is only used certain components and isn't created directly in shopping.html or shopping-container.mjs. Bug 1839730 however keeps a script shopping.html for letter-grade.mjs so that the test passes; it seemed like the easiest fix. If adding the letter grade component in the exceptions list is the better approach, let's be sure to do that.
Severity: -- → N/A
Priority: -- → P3
Whiteboard: [fidefe-shopping]
|
||
Updated•2 years ago
|
|
||
Comment 1•2 years ago
|
||
Do we still need this bug? Looks like the patch has landed successfully. Feel free to close if not
Flags: needinfo?(kpatenio)
I don't think this bug is needed anymore. Closing as a WORKSFORME.
Status: NEW → RESOLVED
Closed: 2 years ago
Flags: needinfo?(kpatenio)
Resolution: --- → WORKSFORME
You need to log in
before you can comment on or make changes to this bug.
Description
•