Closed Bug 1843981 (rustc-1.73) Opened 1 year ago Closed 1 year ago

Update builders to rustc 1.73

Categories

(Firefox Build System :: Toolchains, task)

Product:
Firefox Build System
Component:
Toolchains
Type:
task

Tracking

(firefox121 fixed)

Status:
RESOLVED FIXED
Milestone:
121 Branch
Tracking Flags:
Tracking Status
firefox121 --- fixed

People

(Reporter: glandium, Assigned: glandium)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Bug 1843981 - Update builders to rustc 1.73.
48 bytes, text/x-phabricator-request
Details | Review

Release date: October 4

Depends on: 1849874
Assignee: nobody → mh+mozilla
Status: NEW → ASSIGNED
Pushed by mh@glandium.org: https://hg.mozilla.org/integration/autoland/rev/62f7af8fe549 Update builders to rustc 1.73. r=firefox-build-system-reviewers,sergesanspaille

Backed out for causing valgrind bustages.

[task 2023-10-05T21:34:37.891Z] 21:34:37     INFO -  --29591-- failed to stat64/stat this file
[task 2023-10-05T21:34:40.082Z] 21:34:40     INFO -  ==29591== Thread 34 Renderer:
[task 2023-10-05T21:34:40.083Z] 21:34:40     INFO -  TEST-UNEXPECTED-FAIL | valgrind-test | Conditional jump or move depends on uninitialised value(s) at drop / drop_in_place / drop_in_place / drop_in_place
[task 2023-10-05T21:34:40.083Z] 21:34:40     INFO -  ==29591== Conditional jump or move depends on uninitialised value(s)
[task 2023-10-05T21:34:40.083Z] 21:34:40     INFO -  ==29591==    at 0x1032E7F7: drop<(webrender_api::image::ImageFormat, (webrender::texture_pack::guillotine::GuillotineAllocator, alloc::vec::Vec<webrender::renderer::upload::BatchUploadBuffer, alloc::alloc::Global>)), alloc::alloc::Global> (mod.rs:3106)
[task 2023-10-05T21:34:40.083Z] 21:34:40     INFO -  ==29591==    by 0x1032E7F7: drop_in_place<hashbrown::raw::RawIntoIter<(webrender_api::image::ImageFormat, (webrender::texture_pack::guillotine::GuillotineAllocator, alloc::vec::Vec<webrender::renderer::upload::BatchUploadBuffer, alloc::alloc::Global>)), alloc::alloc::Global>> (mod.rs:497)
[task 2023-10-05T21:34:40.084Z] 21:34:40     INFO -  ==29591==    by 0x1032E7F7: drop_in_place<hashbrown::map::IntoIter<webrender_api::image::ImageFormat, (webrender::texture_pack::guillotine::GuillotineAllocator, alloc::vec::Vec<webrender::renderer::upload::BatchUploadBuffer, alloc::alloc::Global>), alloc::alloc::Global>> (mod.rs:497)
[task 2023-10-05T21:34:40.084Z] 21:34:40     INFO -  ==29591==    by 0x1032E7F7: drop_in_place<std::collections::hash::map::IntoIter<webrender_api::image::ImageFormat, (webrender::texture_pack::guillotine::GuillotineAllocator, alloc::vec::Vec<webrender::renderer::upload::BatchUploadBuffer, alloc::alloc::Global>)>> (mod.rs:497)
[task 2023-10-05T21:34:40.084Z] 21:34:40     INFO -  ==29591==    by 0x1032E7F7: drop_in_place<core::iter::adapters::map::Map<std::collections::hash::map::IntoIter<webrender_api::image::ImageFormat, (webrender::texture_pack::guillotine::GuillotineAllocator, alloc::vec::Vec<webrender::renderer::upload::BatchUploadBuffer, alloc::alloc::Global>)>, webrender::renderer::upload::upload_to_texture_cache::{closure_env#0}>> (mod.rs:497)
[task 2023-10-05T21:34:40.084Z] 21:34:40     INFO -  ==29591==    by 0x1032E7F7: drop_in_place<core::option::Option<core::iter::adapters::map::Map<std::collections::hash::map::IntoIter<webrender_api::image::ImageFormat, (webrender::texture_pack::guillotine::GuillotineAllocator, alloc::vec::Vec<webrender::renderer::upload::BatchUploadBuffer, alloc::alloc::Global>)>, webrender::renderer::upload::upload_to_texture_cache::{closure_env#0}>>> (mod.rs:497)
[task 2023-10-05T21:34:40.085Z] 21:34:40     INFO -  ==29591==    by 0x1032E7F7: drop_in_place<core::iter::adapters::fuse::Fuse<core::iter::adapters::map::Map<std::collections::hash::map::IntoIter<webrender_api::image::ImageFormat, (webrender::texture_pack::guillotine::GuillotineAllocator, alloc::vec::Vec<webrender::renderer::upload::BatchUploadBuffer, alloc::alloc::Global>)>, webrender::renderer::upload::upload_to_texture_cache::{closure_env#0}>>> (mod.rs:497)
[task 2023-10-05T21:34:40.085Z] 21:34:40     INFO -  ==29591==    by 0x1032E7F7: drop_in_place<core::iter::adapters::flatten::FlattenCompat<core::iter::adapters::map::Map<std::collections::hash::map::IntoIter<webrender_api::image::ImageFormat, (webrender::texture_pack::guillotine::GuillotineAllocator, alloc::vec::Vec<webrender::renderer::upload::BatchUploadBuffer, alloc::alloc::Global>)>, webrender::renderer::upload::upload_to_texture_cache::{closure_env#0}>, alloc::vec::into_iter::IntoIter<webrender::renderer::upload::BatchUploadBuffer, alloc::alloc::Global>>> (mod.rs:497)
[task 2023-10-05T21:34:40.086Z] 21:34:40     INFO -  ==29591==    by 0x1032E7F7: drop_in_place<core::iter::adapters::flatten::Flatten<core::iter::adapters::map::Map<std::collections::hash::map::IntoIter<webrender_api::image::ImageFormat, (webrender::texture_pack::guillotine::GuillotineAllocator, alloc::vec::Vec<webrender::renderer::upload::BatchUploadBuffer, alloc::alloc::Global>)>, webrender::renderer::upload::upload_to_texture_cache::{closure_env#0}>>> (mod.rs:497)
[task 2023-10-05T21:34:40.086Z] 21:34:40     INFO -  ==29591==    by 0x1032E7F7: upload_to_texture_cache (upload.rs:204)
[task 2023-10-05T21:34:40.086Z] 21:34:40     INFO -  ==29591==    by 0x1032E7F7: webrender::renderer::Renderer::update_texture_cache+15095 (mod.rs:1938)
[task 2023-10-05T21:34:40.086Z] 21:34:40     INFO -  ==29591==    by 0x1033181D: webrender::renderer::Renderer::render_impl+3661 (mod.rs:1483)
[task 2023-10-05T21:34:40.086Z] 21:34:40     INFO -  ==29591==    by 0x103794C6: UnknownInlinedFun (mod.rs:1240)
[task 2023-10-05T21:34:40.086Z] 21:34:40     INFO -  ==29591==    by 0x103794C6: wr_renderer_render+358 (bindings.rs:619)
[task 2023-10-05T21:34:40.087Z] 21:34:40     INFO -  ==29591==    by 0xB48F48A: mozilla::wr::RendererOGL::UpdateAndRender(mozilla::Maybe<mozilla::gfx::IntSizeTyped<mozilla::gfx::UnknownUnits> > const&, mozilla::Maybe<mozilla::wr::ImageFormat> const&, mozilla::Maybe<mozilla::Range<unsigned char> > const&, bool*, mozilla::wr::RendererStats*)+362 (checkouts/gecko/gfx/webrender_bindings/RendererOGL.cpp:190)
[task 2023-10-05T21:34:40.087Z] 21:34:40     INFO -  ==29591==    by 0xB48EA55: mozilla::wr::RenderThread::UpdateAndRender(mozilla::wr::WrWindowId, mozilla::layers::BaseTransactionId<mozilla::VsyncIdType> const&, mozilla::TimeStamp const&, bool, mozilla::Maybe<mozilla::gfx::IntSizeTyped<mozilla::gfx::UnknownUnits> > const&, mozilla::Maybe<mozilla::wr::ImageFormat> const&, mozilla::Maybe<mozilla::Range<unsigned char> > const&, bool*)+725 (checkouts/gecko/gfx/webrender_bindings/RenderThread.cpp:781)
[task 2023-10-05T21:34:40.087Z] 21:34:40     INFO -  ==29591==    by 0xB48E5EE: mozilla::wr::RenderThread::HandleFrameOneDocInner(mozilla::wr::WrWindowId, bool, bool, mozilla::Maybe<mozilla::wr::FramePublishId>)+686 (checkouts/gecko/gfx/webrender_bindings/RenderThread.cpp:624)
[task 2023-10-05T21:34:40.087Z] 21:34:40     INFO -  ==29591==    by 0xB48DF61: mozilla::wr::RenderThread::HandleFrameOneDoc(mozilla::wr::WrWindowId, bool, bool, mozilla::Maybe<mozilla::wr::FramePublishId>)+65 (checkouts/gecko/gfx/webrender_bindings/RenderThread.cpp:573)
[task 2023-10-05T21:34:40.087Z] 21:34:40     INFO -  ==29591==    by 0xB48DD08: WrNotifierEvent_HandleNewFrameReady (checkouts/gecko/gfx/webrender_bindings/RenderThread.cpp:534)
[task 2023-10-05T21:34:40.088Z] 21:34:40     INFO -  ==29591==    by 0xB48DD08: mozilla::wr::RenderThread::HandleWrNotifierEvents(mozilla::wr::WrWindowId)+760 (checkouts/gecko/gfx/webrender_bindings/RenderThread.cpp:496)
[task 2023-10-05T21:34:40.088Z] 21:34:40     INFO -  ==29591==    by 0xB4958AA: operator()<StoreCopyPassByConstLRef<mozilla::wr::WrWindowId> &> (dist/include/nsThreadUtils.h:1164)
[task 2023-10-05T21:34:40.088Z] 21:34:40     INFO -  ==29591==    by 0xB4958AA: __invoke_impl<void, (lambda at /builds/worker/workspace/obj-build/dist/include/nsThreadUtils.h:1163:9), StoreCopyPassByConstLRef<mozilla::wr::WrWindowId> &> (fetches/sysroot-x86_64-linux-gnu/usr/lib/gcc/x86_64-linux-gnu/8/../../../../include/c++/8/bits/invoke.h:60)
[task 2023-10-05T21:34:40.088Z] 21:34:40     INFO -  ==29591==    by 0xB4958AA: __invoke<(lambda at /builds/worker/workspace/obj-build/dist/include/nsThreadUtils.h:1163:9), StoreCopyPassByConstLRef<mozilla::wr::WrWindowId> &> (fetches/sysroot-x86_64-linux-gnu/usr/lib/gcc/x86_64-linux-gnu/8/../../../../include/c++/8/bits/invoke.h:95)
[task 2023-10-05T21:34:40.088Z] 21:34:40     INFO -  ==29591==    by 0xB4958AA: __apply_impl<(lambda at /builds/worker/workspace/obj-build/dist/include/nsThreadUtils.h:1163:9), std::tuple<StoreCopyPassByConstLRef<mozilla::wr::WrWindowId> > &, 0UL> (fetches/sysroot-x86_64-linux-gnu/usr/lib/gcc/x86_64-linux-gnu/8/../../../../include/c++/8/tuple:1678)
[task 2023-10-05T21:34:40.089Z] 21:34:40     INFO -  ==29591==    by 0xB4958AA: apply<(lambda at /builds/worker/workspace/obj-build/dist/include/nsThreadUtils.h:1163:9), std::tuple<StoreCopyPassByConstLRef<mozilla::wr::WrWindowId> > &> (fetches/sysroot-x86_64-linux-gnu/usr/lib/gcc/x86_64-linux-gnu/8/../../../../include/c++/8/tuple:1687)
[task 2023-10-05T21:34:40.089Z] 21:34:40     INFO -  ==29591==    by 0xB4958AA: apply<mozilla::wr::RenderThread, void (mozilla::wr::RenderThread::*)(mozilla::wr::WrWindowId)> (dist/include/nsThreadUtils.h:1162)
[task 2023-10-05T21:34:40.089Z] 21:34:40     INFO -  ==29591==    by 0xB4958AA: mozilla::detail::RunnableMethodImpl<mozilla::wr::RenderThread*, void (mozilla::wr::RenderThread::*)(mozilla::wr::WrWindowId), true, (mozilla::RunnableKind)0, mozilla::wr::WrWindowId>::Run()+42 (dist/include/nsThreadUtils.h:1213)
[task 2023-10-05T21:34:40.089Z] 21:34:40     INFO -  ==29591==    by 0xA7FBED5: nsThread::ProcessNextEvent(bool, bool*)+1525 (checkouts/gecko/xpcom/threads/nsThread.cpp:1192)
[task 2023-10-05T21:34:40.089Z] 21:34:40     INFO -  ==29591==    by 0xA7FFA6B: NS_ProcessNextEvent(nsIThread*, bool)+75 (checkouts/gecko/xpcom/threads/nsThreadUtils.cpp:480)
[task 2023-10-05T21:34:40.089Z] 21:34:40     INFO -  ==29591==    by 0xAEBE927: mozilla::ipc::MessagePumpForNonMainThreads::Run(base::MessagePump::Delegate*)+231 (checkouts/gecko/ipc/glue/MessagePump.cpp:330)
[task 2023-10-05T21:34:40.090Z] 21:34:40     INFO -  ==29591==    by 0xAE6E544: RunInternal (checkouts/gecko/ipc/chromium/src/base/message_loop.cc:370)
[task 2023-10-05T21:34:40.090Z] 21:34:40     INFO -  ==29591==    by 0xAE6E544: RunHandler (checkouts/gecko/ipc/chromium/src/base/message_loop.cc:363)
[task 2023-10-05T21:34:40.090Z] 21:34:40     INFO -  ==29591==    by 0xAE6E544: MessageLoop::Run()+84 (checkouts/gecko/ipc/chromium/src/base/message_loop.cc:345)
[task 2023-10-05T21:34:40.090Z] 21:34:40     INFO -  ==29591==    by 0xA7F96B3: nsThread::ThreadFunc(void*)+339 (checkouts/gecko/xpcom/threads/nsThread.cpp:370)
[task 2023-10-05T21:34:40.090Z] 21:34:40     INFO -  ==29591==    by 0x5994E95: _pt_root+501 (checkouts/gecko/nsprpub/pr/src/pthreads/ptthread.c:201)
[task 2023-10-05T21:34:40.090Z] 21:34:40     INFO -  ==29591==    by 0x12FC63: set_alt_signal_stack_and_start(PthreadCreateParams*)+211 (checkouts/gecko/mozglue/interposers/pthread_create_interposer.cpp:81)
[task 2023-10-05T21:34:40.090Z] 21:34:40     INFO -  ==29591==    by 0x4C03FD3: start_thread+707 (pthread_create.c:442)
[task 2023-10-05T21:34:40.090Z] 21:34:40     INFO -  ==29591==    by 0x4C8381F: clone+63 (clone.S:100)
[task 2023-10-05T21:34:40.091Z] 21:34:40     INFO -  ==29591==  Uninitialised value was created by a stack allocation
[task 2023-10-05T21:34:40.091Z] 21:34:40     INFO -  ==29591==    at 0x1032AD0D: webrender::renderer::Renderer::update_texture_cache+13 (mod.rs:1770)
[task 2023-10-05T21:34:40.091Z] 21:34:40     INFO -  ==29591==
Flags: needinfo?(mh+mozilla)
Pushed by mh@glandium.org: https://hg.mozilla.org/integration/autoland/rev/baae04dece18 Update builders to rustc 1.73. r=firefox-build-system-reviewers,sergesanspaille

https://hg.mozilla.org/mozilla-central/rev/baae04dece18

Status: ASSIGNED → RESOLVED
Closed: 1 year ago
status-firefox121: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 121 Branch
Regressions: 1863666
Flags: needinfo?(mh+mozilla)

(In reply to Pulsebot from comment #4)

Pushed by mh@glandium.org:
https://hg.mozilla.org/integration/autoland/rev/baae04dece18
Update builders to rustc 1.73.
r=firefox-build-system-reviewers,sergesanspaille

== Change summary for alert #40200 (as of Thu, 09 Nov 2023 19:18:48 GMT) ==

Improvements:

Ratio Test Platform Options Absolute values (old vs new)
30% perf_reftest_singletons bloom-basic.html macosx1015-64-shippable-qr e10s fission stylo webrender 58.86 -> 41.30
23% perf_reftest_singletons bloom-basic.html macosx1015-64-shippable-qr e10s fission stylo webrender 58.84 -> 45.05
22% perf_reftest_singletons bloom-basic-2.html macosx1015-64-shippable-qr e10s fission stylo webrender 58.20 -> 45.27
15% perf_reftest_singletons bloom-basic-2.html linux1804-64-shippable-qr e10s fission stylo webrender 59.72 -> 50.88
14% perf_reftest_singletons bloom-basic.html linux1804-64-shippable-qr e10s fission stylo webrender 59.80 -> 51.21
... ... ... ... ...
5% perf_reftest_singletons bloom-basic-2.html windows10-64-shippable-qr e10s fission stylo webrender 57.63 -> 54.56

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=40200

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: