Closed Bug 1844195 Opened 1 year ago Closed 1 year ago

Avoid duplicating display definitions in rust and C++.

Categories

(Core :: CSS Parsing and Computation, task)

task

Tracking

()

RESOLVED FIXED
117 Branch
Tracking Status
firefox117 --- fixed

People

(Reporter: emilio, Assigned: emilio)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

No description provided.

We need to inline Self::new() so cbindgen generates the constants, which
is kinda lame, but seems better than duplicating the values and type
definitions.

Blocks: 1844148
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/3a3f2d5937c4 Avoid duplicating rust and C++ display definitions. r=layout-reviewers,jfkthame
Flags: needinfo?(emilio)
Flags: needinfo?(emilio)
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f3394bd0f554 Avoid duplicating rust and C++ display definitions. r=layout-reviewers,jfkthame
Backout by imoraru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c9a254411906 Backed out changeset f3394bd0f554 for causing conflicts with another backout.

Sorry :emilio for this backout, but there were some conflicts when I tried to backout this https://bugzilla.mozilla.org/show_bug.cgi?id=1829016#c10 . I hope this doesn't cause too much trouble for you.

backout link for this

Flags: needinfo?(emilio)

No worries.

Flags: needinfo?(emilio)
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/883827ba870e Avoid duplicating rust and C++ display definitions. r=layout-reviewers,jfkthame
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 117 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: