1844211 - Crash in [@ PrefWrapper::WantValueKind] (Should not access the preference 'browser.urlbar.richSuggestions.featureGate' in the Content Processes)

Status: RESOLVED DUPLICATE of bug 1846765

(Firefox :: Address Bar, defect, P1)

Description

[Ryan VanderMeulen [:RyanVM]]

Crash report: https://crash-stats.mozilla.org/report/index/eb0ff672-f0c2-4624-82a2-4342d0230718

MOZ_CRASH Reason: Should not access the preference 'browser.urlbar.richSuggestions.featureGate' in the Content Processes

Top 10 frames of crashing thread:

0  libxul.so  MOZ_Crash  mfbt/Assertions.h:281
0  libxul.so  PrefWrapper::WantValueKind const  modules/libpref/Preferences.cpp:1211
0  libxul.so  PrefWrapper::GetValue const  modules/libpref/Preferences.cpp:1238
1  libxul.so  mozilla::Internals::GetPrefValue<bool*>  modules/libpref/Preferences.cpp:4685
2  libxul.so  mozilla::Internals::GetPref<bool>  modules/libpref/Preferences.cpp:4723
2  libxul.so  mozilla::Preferences::GetBool  modules/libpref/Preferences.cpp:5108
2  libxul.so  Gecko_GetBoolPrefValue  layout/style/GeckoBindings.cpp:1625
3  libxul.so  style::stylesheets::supports_rule::eval_moz_bool_pref  servo/components/style/stylesheets/supports_rule.rs:251
3  libxul.so  style::stylesheets::supports_rule::SupportsCondition::eval  servo/components/style/stylesheets/supports_rule.rs:236
4  libxul.so  <style::stylesheets::rule_parser::NestedRuleParser as cssparser::rules_and_declarations::AtRuleParser>::parse_block::{{closure}}  servo/components/style/stylesheets/rule_parser.rs:755

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The bug is linked to a topcrash signature, which matches the following criterion:

• Top 5 desktop browser crashes on Mac on beta

For more information, please visit BugBot documentation.

Comment 2

[Tom Ritter [:tjr]]

browser.urlbar.richSuggestions.featureGate is crashing three people, and AFAICT those people must have a string for the pref (instead of a bool) because we only crash about string prefs.

If it was one person I'd write it off but... is it possible something in our code sets it to a string?

Comment 3

[Dale Harvey (:daleharvey)]

The only place we would set this pref in code is via Nimbus, I pointed the Nimbus team to this on slack just to give a heads up in case that is setting it incorrectly somehow, however https://bugzilla.mozilla.org/show_bug.cgi?id=1846765 removed the CSS feature gates here so we wont be running into this again