1846765 - Users enrolled in rich suggestions experiment will have broken UI

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P1)

Description

[Dale Harvey (:daleharvey)]

https://bugzilla.mozilla.org/show_bug.cgi?id=1841408 refactored the rich suggestions layout and introduced using CSS -moz-bool-pref @ https://searchfox.org/mozilla-central/source/browser/themes/shared/urlbarView.css#67

This CSS requires a restart to be activated so when users are enrolled in an experiment that enables rich suggestions the feature will become activated without the relevant CSS being applied and will result in a broken UI.

Comment 1

[Dale Harvey (:daleharvey)]

Attachment: Bug 1846765 - Avoid using -moz-bool-pref CSS for experiments. r=adw

Comment 2

[Dianna Smith [:diannaS] - on Leave, back on August 9th]

We should land this as soon as possible and request an uplift if it needs to go in the next 116 dot release

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fb4622ac44ac
Avoid using -moz-bool-pref CSS for experiments. r=adw

Comment 4

[Drew Willcoxon :adw]

Attachment: mozilla-release patch

This is the m-r patch. There's a trivial conflict with the patch on autoland in UrlbarView.sys.mjs due to bug 1792824.

The following bugs should be uplifted to m-r in this order:

1. bug 1839921
2. bug 1846119
3. bug 1846765 (this bug)

Approval Request Comment
[Feature/Bug causing the regression]: See comment 0
[User impact if declined]: We need this to ship the rich suggestions experiment on release as planned
[Is this code covered by automated tests?]: Yes, but this particular bug is a visual change and doesn't have a test
[Has the fix been verified in Nightly?]: No
[Needs manual test from QE? If yes, steps to reproduce]:
[List of other uplifts needed for the feature/fix]: See above
[Is the change risky?]: No
[Why is the change risky/not risky?]: Small CSS changes that should only take effect when rich suggestions are enabled
[String changes made/needed]:

Comment 5

[Drew Willcoxon :adw]

Comment on attachment 9347017 [details]
Bug 1846765 - Avoid using -moz-bool-pref CSS for experiments. r=adw

Beta/Release Uplift Approval Request

• User impact if declined: We need this to ship the rich suggestions experiment on release as planned
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Toggle browser.urlbar.richSuggestions.featureGate and make sure the magnifying glass search icon in the urlbar input aligns with the favicons in the urlbar panel. Please try with the pref set to true and false. You should not need to restart Firefox.
• List of other uplifts needed: Bug 1846119 should be uplifted to beta first
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Small change that's mostly CSS, intended to affect only rich suggestions, which are disabled by default
• String changes made/needed:
• Is Android affected?: No

Comment 6

[Dianna Smith [:diannaS] - on Leave, back on August 9th]

Comment on attachment 9347017 [details]
Bug 1846765 - Avoid using -moz-bool-pref CSS for experiments. r=adw

Approved for 117.0b3

Comment 7

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/de78a2160c98

Comment 8

[Dianna Smith [:diannaS] - on Leave, back on August 9th]

Comment on attachment 9347072 [details] [diff] [review]
mozilla-release patch

Approved for 116.0.1 dot release

Comment 9

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-release/rev/7fffaa98530c

Comment 10

[Dão Gottwald [:dao]]

Attachment: Bug 1846765 - Various code style fixes. r=daleharvey

Comment 11

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/fb4622ac44ac

Comment 12

[Cosmin Muntean [:cmuntean], Ecosystem QA]

The issue is verified fixed using the latest Nightly 118.0a1 (Build ID: 20230803094549), Firefox 117.0b3 treeherder build (Build ID 20230803024036) and Firefox 116.0.1 treeherder build (Build ID: 20230803114611) on Windows 10 x64, macOS 13.1 and Linux Mint 20.1 x64.

• In order to verify this issue I have created a new experiment for Google Rich on the staging server.

Comment 13

[Dale Harvey (:daleharvey)]

Clearing needinfo (Thanks Drew)

Comment 15

[BugBot [:suhaib / :marco/ :calixte]]

Copying crash signatures from duplicate bugs.

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cb8e00b764f9
Various code style fixes. r=daleharvey

Comment 17

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/cb8e00b764f9