1844236 - Open Settings->Privacy & Security will causing network.trr.uri in about:config revert to default

Status: UNCONFIRMED

(Core :: Networking: DNS, defect, P3)

Description

[Tom25519]

1. I set network.trr.uri = https://1.1.1.1/dns-query in about:config
2. Open Settings->Privacy & Security
3. network.trr.uri revert to default

Comment 1

[Sunil Mayya]

I am able to reproduce this issue right away.
We are clearing the pref at a number of places in privacy.js.

Comment 2

[Valentin Gosu [:valentin] (he/him)]

This is caused by these lines here:
https://searchfox.org/mozilla-central/rev/503938c13ef2dd174705dc0f6d0683ae43074ccc/browser/components/preferences/privacy.js#759-762

// When the mode is set to 0 we need to clear the URI so
// doh-rollout can kick in.
if (value == Ci.nsIDNSService.MODE_NATIVEONLY) {
  Services.prefs.clearUserPref("network.trr.uri");

This only happens when the TRR mode is 0 (NATIVEONLY)
If you set the TRR mode to 2 or 3 before opening the window, the bug doesn't happen.
While it's annoying that the pref is cleared, the fact that it does get cleared doesn't really do anything. The value of this pref should only be set by the UI now.

I'm inclined to close this bug as INVALID or WONTFIX, but I'll leave it open for now, in case someone finds a compelling reason we should have a different behaviour.

Comment 3

[footmenkingdom]

I'm inclined to close this bug as INVALID or WONTFIX, but I'll leave it open for now, in case someone finds a compelling reason we should have a different behaviour.

I don't agree with this, how about Android users ? They're getting their TRR URI resetted and that's annoying because there's no ways to trigger doh-rollout and to know when doh-rollout is triggered.

Comment 4

[Valentin Gosu [:valentin] (he/him)]

(In reply to footmenkingdom from comment #3)

I'm inclined to close this bug as INVALID or WONTFIX, but I'll leave it open for now, in case someone finds a compelling reason we should have a different behaviour.

I don't agree with this, how about Android users ? They're getting their TRR URI resetted and that's annoying because there's no ways to trigger doh-rollout and to know when doh-rollout is triggered.

Hi, doh-rollout doesn't really run on Android right now, and neither does the preferences UI. We also have no UI on Android as you correctly state. We tried landing bug 1591533 recently, but we backed it out as it caused bug 1854216. We do plan to improve the situation on Android soon, so stay tuned.

Comment 5

[footmenkingdom]

Yeah, thanks!

Hopefully we find a solution soon because Android users do know how to install Firefox Beta/Nightly to edit about:config, and they edit trr to get the most out of Secure DNS to enable and use DoH3 (for example https://doh3.dns.nextdns.io/), but the current situation is quite frustrated because network.trr.uri is getting resetted every 10 mins.

Comment 6

[Valentin Gosu [:valentin] (he/him)]

(In reply to footmenkingdom from comment #5)

Hopefully we find a solution soon because Android users do know how to install Firefox Beta/Nightly to edit about:config, and they edit trr to get the most out of Secure DNS to enable and use DoH3 (for example https://doh3.dns.nextdns.io/), but the current situation is quite frustrated because network.trr.uri is getting resetted every 10 mins.

I think that should have been resolved in bug 1854216. Make sure to update and check that it's fixed (note that the beta fix landed 20 hours ago, so it might take a few days until it gets released to the play store).

Comment 8

[Tom25519]

Workaround is set network.trr.default_provider_uri instead, don't use network.trr.uri anymore.