1854216 - trr.mode pref set via about:config resets when the browser is restarted

Status: VERIFIED FIXED

(Fenix :: General, defect)

Description

[alessandro]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:109.0) Gecko/20100101 Firefox/119.0

Steps to reproduce:

in fenix nighlt v 119 is no longer possible to permanelty set trr.mode to any value other than zero for example setting to 3 works but if fenix is killed and restarted trr.mode reset to default zero value , BUT SEROUSLY?????????????????????

Actual results:

NIGHLT USER are supposed to change trr.mode without issue

Expected results:

trr.mode reset to 0 at every phone reboot or app restart

Comment 1

[Daniel Veditz [:dveditz]]

Doesn't need to be hidden (it's security-related, but not an attack).

Are you able to save other prefs? It's possible there's a file corruption problem specific to you.

Ah, Andrew found bug 1591533 just landed and may have changed how this works. Might be an unintended regression, or maybe GeckoView (underlying Fenix) created a different way to set these. There are some differences in how Fenix has to work for anything that gets exposed to the front end.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

:elizabbennet, since you are the author of the regressor, bug 1591533, could you take a look?

For more information, please visit BugBot documentation.

Comment 3

[alessandro]

I tested on 3 different devices so I highly doubt there's file corruption ...

Comment 4

[cschanaj]

I am able to toggle/ modify some other settings and observe they persist over app restart. Looks like this is a regression because changes from the about:config pages are not propagate to the new api somehow? I am not familiar with how the config page works yet I will try to take a look later this week.

Comment 5

[cschanaj]

There are some differences in how Fenix has to work for anything that gets exposed to the front end.

I tried to toggle javascript.enabled using the about:config page and confirmed that if a geckoview runtime setting is exposed, GeckoView will reset it after app restart. Although this is an unintended regression, I am reluctant to rollback because it will block non-tech savvy users to have DoH eventually. Would it be possible for Mozilla's Engineers to prioritize bug 1801530 to P1/P2 and provide an Android UI for end-users to toggle TRR properly?

tagging :celu :owlish :valentin who helped reviewing bug 159133 for suggestions. I am happy to submit patches if there is a way to make the setting persistence without rolling back. Please let me know if I can help.

Comment 6

[miralobontiu]

I'll confirm this bug, since I was able to reproduce it on the today's Nightly 119.0a1 build with Google Pixel 6 (Android 14).

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1591533

Comment 8

[Donal Meehan [:dmeehan]]

Adding needinfos re: comment 5

Comment 9

[Valentin Gosu [:valentin] (he/him)]

I think we should backout bug 1591533 from Nightly and land it at a later point when we fix the GV API overwriting them. I suspect the number of users who use TRR on release is quite low, but we still should avoid changing their prefs.

Comment 10

[Donal Meehan [:dmeehan]]

(In reply to Valentin Gosu [:valentin] (he/him) from comment #9)

I think we should backout bug 1591533 from Nightly and land it at a later point when we fix the GV API overwriting them. I suspect the number of users who use TRR on release is quite low, but we still should avoid changing their prefs.

I'll request the Sheriffs to backout

Comment 11

[Andrew McCreight [:mccr8]]

I've updated the summary to hopefully be a bit clearer about the specific issue.

Comment 12

[Donal Meehan [:dmeehan]]

(In reply to Valentin Gosu [:valentin] (he/him) from comment #9)

I think we should backout bug 1591533 from Nightly and land it at a later point when we fix the GV API overwriting them. I suspect the number of users who use TRR on release is quite low, but we still should avoid changing their prefs.

Unfortunately, it doesn't blackout cleanly from central due to Bug 1852804 which also touches changelog.md.
Could you please provide a patch that backs out cleanly?

Comment 13

[Valentin Gosu [:valentin] (he/him)]

Attachment: Bug 1854216 - Backed out changeset f5d973fcd59c (bug 1591533) for resetting the TRR mode when set via about:config r=owlish

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/301cd75007d9
Backed out changeset f5d973fcd59c (bug 1591533) for resetting the TRR mode when set via about:config r=owlish

Comment 15

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1591533

Comment 16

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/301cd75007d9

Comment 17

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:valentin, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox119 to wontfix.

For more information, please visit BugBot documentation.

Comment 18

[Valentin Gosu [:valentin] (he/him)]

Comment on attachment 9354853 [details]
Bug 1854216 - Backed out changeset f5d973fcd59c (bug 1591533) for resetting the TRR mode when set via about:config r=owlish

Beta/Release Uplift Approval Request

• User impact if declined: The network.trr.mode pref set by the user in about:config gets reset by GV API.
• Is this code covered by automated tests?: Unknown
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Set network.trr.mode to 3 in about:config, close Fenix, open it again, check that the pref is still set
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Just a backout reverting to previous behaviour.
• String changes made/needed:
• Is Android affected?: Yes

Comment 19

[miralobontiu]

Verified as fixed on the latest Fenix Nightly 120.0a1 from 9/28 with Google Pixel 6 (Android 14).

Comment 20

[Dianna Smith [:diannaS]]

Comment on attachment 9354853 [details]
Bug 1854216 - Backed out changeset f5d973fcd59c (bug 1591533) for resetting the TRR mode when set via about:config r=owlish

Approved for 119.0b3

Comment 21

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/b2a289b3e470

Comment 22

[Delia Pop (Android QA)]

Verified fixed on Beta 119.0b3 with Samsung Galaxy A53 5G (Android 13). The network.trr.mode param is no longer reset after restarting Fenix.