1844495 - Implement base of MDN Suggestions

Status: VERIFIED FIXED

(Firefox :: Address Bar, task, P3)

Description

[Daisuke Akatsuka (:daisuke)]

Implement base of MDN Suggestions.

Comment 1

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1844495: Implement base of MDN Suggestions

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/058d7fc0c711
Implement base of MDN Suggestions r=adw,dao

Comment 3

[Iulian Moraru]

Backed out for causing bc failures on browser_quicksuggest_mdn.js.

• Push with failures

• Failure log

• Backout link

[task 2023-07-27T21:39:16.269Z] 21:39:16     INFO - TEST-START | browser/components/urlbar/tests/quicksuggest/browser/browser_quicksuggest_mdn.js
[task 2023-07-27T21:39:16.273Z] 21:39:16     INFO - GECKO(4809) | [Child 4902: Main Thread]: I/DocShellAndDOMWindowLeak --DOCSHELL 7f36e5f40800 == 0 [pid = 4902] [id = 0] [url = about:blank]
[task 2023-07-27T21:39:16.323Z] 21:39:16     INFO - GECKO(4809) | [Child 4902: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 3 (7f36e1413f20) [pid = 4902] [serial = 1] [outer = 0] [url = about:blank]
[task 2023-07-27T21:39:16.366Z] 21:39:16     INFO - GECKO(4809) | [Child 5013, Main Thread] WARNING: NS_ENSURE_SUCCESS(rv, NS_OK) failed with result 0x80004005 (NS_ERROR_FAILURE): file /builds/worker/checkouts/gecko/caps/BasePrincipal.cpp:1150
[task 2023-07-27T21:39:16.368Z] 21:39:16     INFO - GECKO(4809) | [Child 5013, Main Thread] WARNING: NS_ENSURE_SUCCESS(rv, NS_OK) failed with result 0x80004005 (NS_ERROR_FAILURE): file /builds/worker/checkouts/gecko/caps/BasePrincipal.cpp:1150
[task 2023-07-27T21:39:16.368Z] 21:39:16     INFO - GECKO(4809) | [Child 5013, Main Thread] WARNING: NS_ENSURE_SUCCESS(rv, NS_OK) failed with result 0x80004005 (NS_ERROR_FAILURE): file /builds/worker/checkouts/gecko/caps/BasePrincipal.cpp:1150
[task 2023-07-27T21:39:16.696Z] 21:39:16     INFO - GECKO(4809) | [Parent 4809, Main Thread] WARNING: '!mOwner', file /builds/worker/checkouts/gecko/dom/events/Event.cpp:734
[task 2023-07-27T21:39:17.016Z] 21:39:17     INFO - TEST-INFO | started process screentopng
[task 2023-07-27T21:39:17.202Z] 21:39:17     INFO - TEST-INFO | screentopng: exit 0
[task 2023-07-27T21:39:17.203Z] 21:39:17     INFO - Buffered messages logged at 21:39:16
[task 2023-07-27T21:39:17.204Z] 21:39:17     INFO - Entering setup bound 
[task 2023-07-27T21:39:17.205Z] 21:39:17     INFO - Console message: [JavaScript Error: "Error: Can't find profile directory." {file: "resource://gre/modules/XULStore.sys.mjs" line: 60}]
[task 2023-07-27T21:39:17.205Z] 21:39:17     INFO - load@resource://gre/modules/XULStore.sys.mjs:60:15
[task 2023-07-27T21:39:17.205Z] 21:39:17     INFO - XULStore@resource://gre/modules/XULStore.sys.mjs:17:10
[task 2023-07-27T21:39:17.206Z] 21:39:17     INFO - 
[task 2023-07-27T21:39:17.206Z] 21:39:17     INFO - ensureQuickSuggestInit calling QuickSuggest.init()
[task 2023-07-27T21:39:17.207Z] 21:39:17     INFO - Leaving setup bound 
[task 2023-07-27T21:39:17.207Z] 21:39:17     INFO - Entering test bound basic
[task 2023-07-27T21:39:17.208Z] 21:39:17     INFO - Awaiting for the urlbar panel to open
[task 2023-07-27T21:39:17.209Z] 21:39:17     INFO - Urlbar panel opened
[task 2023-07-27T21:39:17.209Z] 21:39:17     INFO - Buffered messages finished
[task 2023-07-27T21:39:17.213Z] 21:39:17     INFO - TEST-UNEXPECTED-FAIL | browser/components/urlbar/tests/quicksuggest/browser/browser_quicksuggest_mdn.js | 1 == 2 - {"filename":"chrome://mochitests/content/browser/browser/components/urlbar/tests/quicksuggest/browser/browser_quicksuggest_mdn.js","name":"basic","sourceId":581,"lineNumber":49,"columnNumber":10,"sourceLine":"","asyncCause":null,"asyncCaller":{"filename":"chrome://mochikit/content/browser-test.js","name":"handleTask","sourceId":529,"lineNumber":1131,"columnNumber":26,"sourceLine":"","asyncCause":null,"asyncCaller":null,"caller":{"filename":"chrome://mochikit/content/browser-test.js","name":"_runTaskBasedTest","sourceId":529,"lineNumber":1203,"columnNumber":18,"sourceLine":"","asyncCause":null,"asyncCaller":{"filename":"chrome://mochikit/content/browser-test.js","name":"Tester_execTest","sourceId":529,"lineNumber":1345,"columnNumber":14,"sourceLine":"","asyncCause":null,"asyncCaller":null,"caller":{"filename":"chrome://mochikit/content/browser-test.js","name":"nextTest/<","sourceId":529,"lineNumber":1120,"columnNumber":14,"sourceLine":"","asyncCause":null,"asyncCaller":null,"caller":{"filename":"chrome://mochikit/content/tests/SimpleTest/SimpleTest.js","name":"SimpleTest.waitForFocus/<","sourceId":557,"lineNumber":1056,"columnNumber":13,"sourceLine":"","asyncCause":null,"asyncCaller":null,"caller":null,"formattedStack":"SimpleTest.waitForFocus/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:1056:13\n","nativeSavedFrame":{}},"formattedStack":"nextTest/<@chrome://mochikit/content/browser-test.js:1120:14\nSimpleTest.waitForFocus/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:1056:13\n","nativeSavedFrame":{}},"formattedStack":"async*Tester_execTest@chrome://mochikit/content/browser-test.js:1345:14\nnextTest/<@chrome://mochikit/content/browser-test.js:1120:14\nSimpleTest.waitForFocus/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:1056:13\n","nativeSavedFrame":{}},"caller":null,"formattedStack":"_runTaskBasedTest@chrome://mochikit/content/browser-test.js:1203:18\nasync*Tester_execTest@chrome://mochikit/content/browser-test.js:1345:14\nnextTest/<@chrome://mochikit/content/browser-test.js:1120:14\nSimpleTest.waitForFocus/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:1056:13\n","nativeSavedFrame":{}},"formattedStack":"async*handleTask@chrome://mochikit/content/browser-test.js:1131:26\n_runTaskBasedTest@chrome://mochikit/content/browser-test.js:1203:18\nasync*Tester_execTest@chrome://mochikit/content/browser-test.js:1345:14\nnextTest/<@chrome://mochikit/content/browser-test.js:1120:14\nSimpleTest.waitForFocus/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:1056:13\n","nativeSavedFrame":{}},"caller":null,"formattedStack":"basic@chrome://mochitests/content/browser/browser/components/urlbar/tests/quicksuggest/browser/browser_quicksuggest_mdn.js:49:10\nasync*handleTask@chrome://mochikit/content/browser-test.js:1131:26\n_runTaskBasedTest@chrome://mochikit/content/browser-test.js:1203:18\nasync*Tester_execTest@chrome://mochikit/content/browser-test.js:1345:14\nnextTest/<@chrome://mochikit/content/browser-test.js:1120:14\nSimpleTest.waitForFocus/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:1056:13\n","nativeSavedFrame":{}}
[task 2023-07-27T21:39:17.214Z] 21:39:17     INFO - Stack trace:
[task 2023-07-27T21:39:17.215Z] 21:39:17     INFO - chrome://mochitests/content/browser/browser/components/urlbar/tests/quicksuggest/browser/browser_quicksuggest_mdn.js:basic:49
[task 2023-07-27T21:39:17.215Z] 21:39:17     INFO - chrome://mochikit/content/browser-test.js:handleTask:1131
[task 2023-07-27T21:39:17.216Z] 21:39:17     INFO - chrome://mochikit/content/browser-test.js:_runTaskBasedTest:1203
[task 2023-07-27T21:39:17.216Z] 21:39:17     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1345
[task 2023-07-27T21:39:17.216Z] 21:39:17     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:1120
[task 2023-07-27T21:39:17.217Z] 21:39:17     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/<:1056
[task 2023-07-27T21:39:17.218Z] 21:39:17     INFO - Not taking screenshot here: see the one that was previously logged
[task 2023-07-27T21:39:17.219Z] 21:39:17     INFO - TEST-UNEXPECTED-FAIL | browser/components/urlbar/tests/quicksuggest/browser/browser_quicksuggest_mdn.js | Uncaught exception in test bound basic - at resource://testing-common/UrlbarTestUtils.sys.mjs:204 - Error: Not enough results
[task 2023-07-27T21:39:17.220Z] 21:39:17     INFO - Stack trace:
[task 2023-07-27T21:39:17.220Z] 21:39:17     INFO - waitForAutocompleteResultAt@resource://testing-common/UrlbarTestUtils.sys.mjs:204:13
[task 2023-07-27T21:39:17.220Z] 21:39:17     INFO - async*getDetailsOfResultAt@resource://testing-common/UrlbarTestUtils.sys.mjs:525:30
[task 2023-07-27T21:39:17.221Z] 21:39:17     INFO - basic@chrome://mochitests/content/browser/browser/components/urlbar/tests/quicksuggest/browser/browser_quicksuggest_mdn.js:51:53
[task 2023-07-27T21:39:17.221Z] 21:39:17     INFO - async*handleTask@chrome://mochikit/content/browser-test.js:1131:26
[task 2023-07-27T21:39:17.222Z] 21:39:17     INFO - _runTaskBasedTest@chrome://mochikit/content/browser-test.js:1203:18
[task 2023-07-27T21:39:17.222Z] 21:39:17     INFO - async*Tester_execTest@chrome://mochikit/content/browser-test.js:1345:14
[task 2023-07-27T21:39:17.222Z] 21:39:17     INFO - nextTest/<@chrome://mochikit/content/browser-test.js:1120:14
[task 2023-07-27T21:39:17.223Z] 21:39:17     INFO - SimpleTest.waitForFocus/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:1056:13
[task 2023-07-27T21:39:17.223Z] 21:39:17     INFO - Leaving test bound basic
[task 2023-07-27T21:39:17.224Z] 21:39:17     INFO - Entering test bound disable
[task 2023-07-27T21:39:17.225Z] 21:39:17     INFO - GECKO(4809) | ### XPCOM_MEM_BLOAT_LOG defined -- logging bloat/leaks to /tmp/tmpevlcfyif.mozrunner/runtests_leaks_tab_pid5050.log
[task 2023-07-27T21:39:17.226Z] 21:39:17     INFO - GECKO(4809) | [Child 5050, Main Thread] WARNING: could not set real-time limit in CubebUtils::InitLibrary: file /builds/worker/checkouts/gecko/dom/media/CubebUtils.cpp:655
[task 2023-07-27T21:39:17.429Z] 21:39:17     INFO - TEST-PASS | browser/components/urlbar/tests/quicksuggest/browser/browser_quicksuggest_mdn.js | 1 == 1 - 

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a375aee72ff0
Implement base of MDN Suggestions r=adw,dao

Comment 5

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/a375aee72ff0

Comment 6

[Cosmin Muntean [:cmuntean], Ecosystem QA]

Hi Daisuke!

I am the QA contact who will help with the MDN suggestions feature and I am planning to verify all the bugs implemented. But I would need some information first:

1. Is the feature enabled by default? Are there any prefs that I should add?
2. Is the feature available for all countries, or only for the US?
3. Are the keywords that will trigger MDN suggestions stored in Remote Settings?
4. Is there a list with keywords that would trigger an MDN suggestion?

Comment 7

[Daisuke Akatsuka (:daisuke)]

Hi Cosmin! I'm so sorry for my delay.

(In reply to Cosmin Muntean [:cmuntean], Ecosystem QA from comment #6)

I am the QA contact who will help with the MDN suggestions feature and I am planning to verify all the bugs implemented. But I would need some information first:

1. Is the feature enabled by default? Are there any prefs that I should add?

No, it is not enabled as default.
The following prefs are needed to enable MDN suggestions.

• browser.urlbar.mdn.featureGate
• browser.urlbar.suggest.mdn
• browser.urlbar.quicksuggest.enabled
• browser.urlbar.suggest.quicksuggest.nonsponsored

2. Is the feature available for all countries, or only for the US?

According to the document, it would expand outside US in the longer term.

3. Are the keywords that will trigger MDN suggestions stored in Remote Settings?

Yes, it is ready for dev and prod.

4. Is there a list with keywords that would trigger an MDN suggestion?

Please check this document.

Thanks!

Comment 8

[Cosmin Muntean [:cmuntean], Ecosystem QA]

Thank you @Daisuke for all the details!

We have managed to enable the MDN Firefox Suggests. We have already verified the other tasks and we performed exploratory testing on the latest Nightly 118.0a1 (Build ID: 20230824214839) on Windows 10 x64, macOS 13.1 and Linux Mint.

• The MDN results are correctly triggered under the "Recommended resource" label and work as expected.

Based on this I will also mark this task as verified - fixed.