1844521 - GeckoView Session Translations API support

Status: RESOLVED FIXED

(Firefox for Android :: Translations, enhancement, P1)

Description

[Jonathan Almeida [:jonalmeida]]

We need to add an API controller to: turn the feature on/off, change languages, fetch and delete language models, etc.

Comment 1

[Olivia Hall [:olivia]]

Readjusting this bug for GV Session API changes needed. Runtime GeckoView Translations API support is now bug 1844518.

Comment 2

[Olivia Hall [:olivia]]

Attachment: Bug 1844521 - GeckoView Initial Session Translations API

This patch lands an initial GeckoView session API for using toolkit
translations. This patch adds an initial session translate delegate,
functions to translate, detect languages, and restore to an original
page. The runtime API will follow in bug 1852313 and additional session
API changes are planned.

Comment 3

[Olivia Hall [:olivia]]

Attachment: Bug 1844521 - GeckoView Initial Runtime Translations API

This patch lands an initial GeckoView runtime API for using toolkit
translations. Most of the runtime functionality revolves around querying
for language options,language model state, and managing language models.

Depends on D189228

Comment 4

[Phabricator Automation]

Comment on attachment 9355079 [details]
Bug 1844521 - GeckoView Initial Runtime Translations API

Revision D189229 was moved to bug 1852313. Setting attachment 9355079 [details] to obsolete.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5c2d783060b0
GeckoView Initial Session Translations API r=geckoview-reviewers,kaya,calu

Comment 6

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/5c2d783060b0

Comment 7

[Dianna Smith [:diannaS]]

:Olivia is this something you want to mention in the fx120 release notes? https://wiki.mozilla.org/Release_Management/Release_Notes_Nomination

Comment 8

[Olivia Hall [:olivia]]

Hi Dianna, thanks for noticing this patch for the release notes! This patch is background work for translations and only noteworthy right now for GeckoView embedders. (Patch doesn't include UI or a web API for translations.) GeckoView developers will be informed via the GeckoView CHANGELOG.md in-tree notes .