1844523 - AC Add Basic Session Translations support to Android Components

Status: RESOLVED FIXED

(Firefox for Android :: Translations, enhancement, P1)

Description

[Jonathan Almeida [:jonalmeida]]

We can do a bulk of the logic here to observe for translation detection, offer a state of downloaded language models, and other requirements.

Some of the re-usable UI can be in the component as well (see Addons for example), this would let the application layer build on other specifics like onboarding.

Comment 1

[Olivia Hall [:olivia]]

Repurposing this bug for the session features needed in AC.

Comment 2

[Olivia Hall [:olivia]]

This patch should include adding these translation session functions to the engine:

• translate
• restoreToOriginalPage

Edit: Moving these functions to Bug 1860844 to make GeckoTranslateSessionDelegate.kt

• onOfferTranslate
• onExpectedTranslate
• onTranslationStateChange

Comment 3

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1844523 - Translate and Restore to Original Engine Support (#4231)

Comment 4

[BMO Github Automation]

Authored by https://github.com/ohall-m
https://github.com/mozilla-mobile/firefox-android/commit/c9bc947a2ac7cc65433acaf4ee0b98fe243796e9
[main] Bug 1844523 - Translate and Restore to Original Engine Support

Comment 5

[Olivia Hall [:olivia]]

(Only added option to engine and reference browser.)