Closed Bug 1844523 Opened 5 months ago Closed 28 days ago

AC Add Basic Session Translations support to Android Components

Categories

(Fenix :: Translations, enhancement, P1)

All
Android
enhancement

Tracking

(firefox119 wontfix, firefox120 wontfix, firefox121 fixed)

RESOLVED FIXED
121 Branch
Tracking Status
firefox119 --- wontfix
firefox120 --- wontfix
firefox121 --- fixed

People

(Reporter: jonalmeida, Assigned: olivia)

References

(Blocks 2 open bugs)

Details

(Whiteboard: [fxdroid][foundation][geckoview:m121])

Attachments

(1 file)

We can do a bulk of the logic here to observe for translation detection, offer a state of downloaded language models, and other requirements.

Some of the re-usable UI can be in the component as well (see Addons for example), this would let the application layer build on other specifics like onboarding.

Whiteboard: [fxdroid][foundation]
Component: Browser Engine → Translations

Repurposing this bug for the session features needed in AC.

Summary: Add Translations support to Android Components → Add Session Translations support to Android Components
Depends on: 1844521
Blocks: 1855979
Blocks: 1855983
Summary: Add Session Translations support to Android Components → AC Add Session Translations support to Android Components
No longer blocks: 1855983
No longer blocks: 1855979
Assignee: nobody → ohall
Priority: -- → P1
Whiteboard: [fxdroid][foundation] → [fxdroid][foundation][geckoview:m121]

This patch should include adding these translation session functions to the engine:

  • translate
  • restoreToOriginalPage

Edit: Moving these functions to Bug 1860844 to make GeckoTranslateSessionDelegate.kt

  • onOfferTranslate
  • onExpectedTranslate
  • onTranslationStateChange
Summary: AC Add Session Translations support to Android Components → AC Add Basic Session Translations support to Android Components
See Also: → 1860844
Blocks: 1855979
Status: NEW → RESOLVED
Closed: 28 days ago
Flags: qe-verify+
Resolution: --- → FIXED
Target Milestone: --- → 121 Branch
Flags: qe-verify+

(Only added option to engine and reference browser.)

You need to log in before you can comment on or make changes to this bug.