Closed
Bug 1844558
Opened 3 years ago
Closed 2 years ago
Log a message to the web console if a site is classified as a potential bounce tracker
Categories
(Core :: Privacy: Anti-Tracking, enhancement, P2)
Core
Privacy: Anti-Tracking
Tracking
()
RESOLVED
FIXED
131 Branch
| Tracking | Status | |
|---|---|---|
| firefox131 | --- | fixed |
People
(Reporter: emz, Assigned: emz)
References
(Blocks 1 open bug)
Details
Attachments
(1 external file)
On extended navigation end, if we classify a site as a potential bounce tracker we should log a message to the website console. We can log it in the destination site (either on timeout or when the user navigates away.
At this point the site may get purged in the future if it doesn't receive user interaction.
| Assignee | ||
Updated•2 years ago
|
Blocks: btp-etp-strict
| Assignee | ||
Updated•2 years ago
|
Priority: P3 → P2
| Assignee | ||
Updated•2 years ago
|
Assignee: nobody → pbz
Status: NEW → ASSIGNED
| Assignee | ||
Comment 1•2 years ago
|
||
Pushed by pzuhlcke@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/00cce862553d
Log a message to the web console if a site is classified as a potential bounce tracker. r=anti-tracking-reviewers,fluent-reviewers,bolsson,bvandersloot
Comment 3•2 years ago
|
||
Backed out for causing build bustages on BounceTrackingProtection.cpp
[task 2024-08-09T13:30:47.085Z] 13:30:47 INFO - gmake[4]: Entering directory '/builds/worker/workspace/obj-build/toolkit/components/antitracking/bouncetrackingprotection'
[task 2024-08-09T13:30:47.091Z] 13:30:47 INFO - /builds/worker/fetches/sccache/sccache /builds/worker/fetches/gcc/bin/g++ --sysroot /builds/worker/fetches/sysroot-x86_64-linux-gnu -std=gnu++17 -isystem /builds/worker/fetches/sysroot-x86_64-linux-gnu/usr/include/c++/8 -isystem /builds/worker/fetches/sysroot-x86_64-linux-gnu/usr/include/x86_64-linux-gnu/c++/8 -isystem /builds/worker/fetches/sysroot-x86_64-linux-gnu/usr/include/x86_64-linux-gnu -isystem /builds/worker/fetches/sysroot-x86_64-linux-gnu/usr/include -o Unified_cpp_cetrackingprotection0.o -c -I/builds/worker/workspace/obj-build/dist/stl_wrappers -I/builds/worker/workspace/obj-build/dist/system_wrappers -include /builds/worker/checkouts/gecko/config/gcc_hidden.h -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -DDEBUG=1 -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -DMOZ_SUPPORT_LEAKCHECKING -DSTATIC_EXPORTABLE_JS_API -I/builds/worker/checkouts/gecko/toolkit/components/antitracking/bouncetrackingprotection -I/builds/worker/workspace/obj-build/toolkit/components/antitracking/bouncetrackingprotection -I/builds/worker/workspace/obj-build/ipc/ipdl/_ipdlheaders -I/builds/worker/checkouts/gecko/ipc/chromium/src -I/builds/worker/checkouts/gecko/dom/base -I/builds/worker/workspace/obj-build/dist/include -I/builds/worker/workspace/obj-build/dist/include/nspr -I/builds/worker/workspace/obj-build/dist/include/nss -DMOZILLA_CLIENT -include /builds/worker/workspace/obj-build/mozilla-config.h -D_GLIBCXX_USE_CXX11_ABI=0 -fno-rtti -pthread -fno-sized-deallocation -fno-aligned-new -ffunction-sections -fdata-sections -fno-math-errno -fno-exceptions -pipe -fPIC -gdwarf-4 -O2 -fno-omit-frame-pointer -funwind-tables -Werror -Wall -Wempty-body -Wignored-qualifiers -Wpointer-arith -Wsign-compare -Wtype-limits -Wunreachable-code -Wno-invalid-offsetof -Wduplicated-cond -Wimplicit-fallthrough -Wlogical-op -Wno-error=maybe-uninitialized -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=free-nonheap-object -Wno-multistatement-macros -Wno-error=class-memaccess -Wformat -Wformat-overflow=2 -Wno-psabi -Wno-error=builtin-macro-redefined -fno-strict-aliasing -ffp-contract=off -MD -MP -MF .deps/Unified_cpp_cetrackingprotection0.o.pp Unified_cpp_cetrackingprotection0.cpp
[task 2024-08-09T13:30:47.091Z] 13:30:47 INFO - In file included from /builds/worker/workspace/obj-build/dist/include/mozilla/Assertions.h:35,
[task 2024-08-09T13:30:47.091Z] 13:30:47 INFO - from /builds/worker/workspace/obj-build/dist/include/js/ErrorReport.h:20,
[task 2024-08-09T13:30:47.091Z] 13:30:47 INFO - from /builds/worker/workspace/obj-build/dist/include/mozilla/ErrorResult.h:34,
[task 2024-08-09T13:30:47.091Z] 13:30:47 INFO - from /builds/worker/workspace/obj-build/dist/include/mozilla/dom/BrowsingContext.h:12,
[task 2024-08-09T13:30:47.091Z] 13:30:47 INFO - from /builds/worker/workspace/obj-build/dist/include/mozilla/ContentBlockingAllowList.h:10,
[task 2024-08-09T13:30:47.091Z] 13:30:47 INFO - from /builds/worker/checkouts/gecko/toolkit/components/antitracking/bouncetrackingprotection/BounceTrackingAllowList.h:10,
[task 2024-08-09T13:30:47.091Z] 13:30:47 INFO - from /builds/worker/checkouts/gecko/toolkit/components/antitracking/bouncetrackingprotection/BounceTrackingAllowList.cpp:7,
[task 2024-08-09T13:30:47.091Z] 13:30:47 INFO - from Unified_cpp_cetrackingprotection0.cpp:2:
[task 2024-08-09T13:30:47.092Z] 13:30:47 INFO - /builds/worker/checkouts/gecko/toolkit/components/antitracking/bouncetrackingprotection/BounceTrackingProtection.cpp: In member function 'nsresult mozilla::BounceTrackingProtection::OnModeChange(bool)':
[task 2024-08-09T13:30:47.092Z] 13:30:47 ERROR - /builds/worker/checkouts/gecko/toolkit/components/antitracking/bouncetrackingprotection/BounceTrackingProtection.cpp:235:15: error: comparison is always true due to limited range of data type [-Werror=type-limits]
[task 2024-08-09T13:30:47.092Z] 13:30:47 INFO - modeInt >= 0 && modeInt <= nsIBounceTrackingProtection::MAX_MODE_VALUE,
[task 2024-08-09T13:30:47.092Z] 13:30:47 INFO - ~~~~~~~~^~~~
[task 2024-08-09T13:30:47.092Z] 13:30:47 INFO - /builds/worker/workspace/obj-build/dist/include/mozilla/Likely.h:17:48: note: in definition of macro 'MOZ_UNLIKELY'
[task 2024-08-09T13:30:47.092Z] 13:30:47 INFO - # define MOZ_UNLIKELY(x) (__builtin_expect(!!(x), 0))
[task 2024-08-09T13:30:47.093Z] 13:30:47 INFO - ^
[task 2024-08-09T13:30:47.093Z] 13:30:47 INFO - /builds/worker/checkouts/gecko/toolkit/components/antitracking/bouncetrackingprotection/BounceTrackingProtection.cpp:234:3: note: in expansion of macro 'NS_ENSURE_TRUE'
[task 2024-08-09T13:30:47.093Z] 13:30:47 INFO - NS_ENSURE_TRUE(
[task 2024-08-09T13:30:47.093Z] 13:30:47 INFO - ^~~~~~~~~~~~~~
[task 2024-08-09T13:30:47.093Z] 13:30:47 INFO - In file included from /builds/worker/workspace/obj-build/dist/include/mozilla/ErrorResult.h:41,
[task 2024-08-09T13:30:47.093Z] 13:30:47 INFO - from /builds/worker/workspace/obj-build/dist/include/mozilla/dom/BrowsingContext.h:12,
[task 2024-08-09T13:30:47.093Z] 13:30:47 INFO - from /builds/worker/workspace/obj-build/dist/include/mozilla/ContentBlockingAllowList.h:10,
[task 2024-08-09T13:30:47.093Z] 13:30:47 INFO - from /builds/worker/checkouts/gecko/toolkit/components/antitracking/bouncetrackingprotection/BounceTrackingAllowList.h:10,
[task 2024-08-09T13:30:47.094Z] 13:30:47 INFO - from /builds/worker/checkouts/gecko/toolkit/components/antitracking/bouncetrackingprotection/BounceTrackingAllowList.cpp:7,
[task 2024-08-09T13:30:47.094Z] 13:30:47 INFO - from Unified_cpp_cetrackingprotection0.cpp:2:
[task 2024-08-09T13:30:47.094Z] 13:30:47 INFO - /builds/worker/workspace/obj-build/dist/include/nsTArray.h: In instantiation of 'static void AssignRangeAlgorithm<true, true>::implementation(ElemType*, IndexType, SizeType, const Item*) [with Item = mozilla::dom::workerinternals::JSSettings::JSGCSetting; ElemType = mozilla::dom::workerinternals::JSSettings::JSGCSetting; IndexType = long unsigned int; SizeType = long unsigned int]':
[task 2024-08-09T13:30:47.094Z] 13:30:47 INFO - /builds/worker/workspace/obj-build/dist/include/nsTArray.h:2439:58: required from 'void nsTArray_Impl<E, Alloc>::AssignRange(nsTArray_Impl<E, Alloc>::index_type, nsTArray_Impl<E, Alloc>::size_type, const Item*) [with Item = mozilla::dom::workerinternals::JSSettings::JSGCSetting; E = mozilla::dom::workerinternals::JSSettings::JSGCSetting; Alloc = nsTArrayInfallibleAllocator; nsTArray_Impl<E, Alloc>::index_type = long unsigned int; nsTArray_Impl<E, Alloc>::size_type = long unsigned int]'
[task 2024-08-09T13:30:47.095Z] 13:30:47 INFO - /builds/worker/workspace/obj-build/dist/include/nsTArray.h:2468:5: required from 'typename ActualAlloc::ResultType nsTArray_Impl<E, Alloc>::AssignInternal(const Item*, nsTArray_Impl<E, Alloc>::size_type) [with ActualAlloc = nsTArrayInfallibleAllocator; Item = mozilla::dom::workerinternals::JSSettings::JSGCSetting; E = mozilla::dom::workerinternals::JSSettings::JSGCSetting; Alloc = nsTArrayInfallibleAllocator; typename ActualAlloc::ResultType = void; nsTArray_Impl<E, Alloc>::size_type = long unsigned int]'
[task 2024-08-09T13:30:47.095Z] 13:30:47 INFO - /builds/worker/workspace/obj-build/dist/include/nsTArray.h:1454:39: required from 'typename ActualAlloc::ResultType nsTArray_Impl<E, Alloc>::Assign(const nsTArray_Impl<E, Allocator>&) [with Allocator = nsTArrayInfallibleAllocator; ActualAlloc = nsTArrayInfallibleAllocator; E = mozilla::dom::workerinternals::JSSettings::JSGCSetting; Alloc = nsTArrayInfallibleAllocator; typename ActualAlloc::ResultType = void]'
[task 2024-08-09T13:30:47.096Z] 13:30:47 INFO - /builds/worker/workspace/obj-build/dist/include/nsTArray.h:2965:7: required from 'CopyableTArray<E>& CopyableTArray<E>::operator=(const CopyableTArray<E>&) [with E = mozilla::dom::workerinternals::JSSettings::JSGCSetting]'
[task 2024-08-09T13:30:47.096Z] 13:30:47 INFO - /builds/worker/workspace/obj-build/dist/include/mozilla/dom/workerinternals/JSSettings.h:24:8: required from here
[task 2024-08-09T13:30:47.096Z] 13:30:47 WARNING - /builds/worker/workspace/obj-build/dist/include/nsTArray.h:671:13: warning: 'void* memcpy(void*, const void*, size_t)' writing to an object of non-trivially copyable type 'struct mozilla::dom::workerinternals::JSSettings::JSGCSetting'; use copy-assignment or copy-initialization instead [-Wclass-memaccess]
[task 2024-08-09T13:30:47.096Z] 13:30:47 INFO - memcpy(aElements + aStart, aValues, aCount * sizeof(ElemType));
[task 2024-08-09T13:30:47.097Z] 13:30:47 INFO - ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[task 2024-08-09T13:30:47.097Z] 13:30:47 INFO - In file included from /builds/worker/workspace/obj-build/dist/include/mozilla/dom/WorkerPrivate.h:39,
[task 2024-08-09T13:30:47.097Z] 13:30:47 INFO - from /builds/worker/workspace/obj-build/dist/include/mozilla/dom/ProcessIsolation.h:15,
[task 2024-08-09T13:30:47.097Z] 13:30:47 INFO - from /builds/worker/workspace/obj-build/dist/include/mozilla/dom/CanonicalBrowsingContext.h:14,
[task 2024-08-09T13:30:47.098Z] 13:30:47 INFO - from /builds/worker/workspace/obj-build/dist/include/mozilla/dom/WindowGlobalParent.h:27,
[task 2024-08-09T13:30:47.098Z] 13:30:47 INFO - from /builds/worker/checkouts/gecko/toolkit/components/antitracking/bouncetrackingprotection/BounceTrackingProtection.cpp:42,
[task 2024-08-09T13:30:47.098Z] 13:30:47 INFO - from Unified_cpp_cetrackingprotection0.cpp:20:
[task 2024-08-09T13:30:47.099Z] 13:30:47 INFO - /builds/worker/workspace/obj-build/dist/include/mozilla/dom/workerinternals/JSSettings.h:25:10: note: 'struct mozilla::dom::workerinternals::JSSettings::JSGCSetting' declared here
[task 2024-08-09T13:30:47.099Z] 13:30:47 INFO - struct JSGCSetting {
[task 2024-08-09T13:30:47.099Z] 13:30:47 INFO - ^~~~~~~~~~~
[task 2024-08-09T13:30:47.099Z] 13:30:47 INFO - cc1plus: all warnings being treated as errors
[task 2024-08-09T13:30:47.099Z] 13:30:47 ERROR - gmake[4]: *** [/builds/worker/checkouts/gecko/config/rules.mk:676: Unified_cpp_cetrackingprotection0.o] Error 1
[task 2024-08-09T13:30:47.099Z] 13:30:47 INFO - gmake[4]: Leaving directory '/builds/worker/workspace/obj-build/toolkit/components/antitracking/bouncetrackingprotection'
[task 2024-08-09T13:30:47.100Z] 13:30:47 INFO - gmake[4]: Target 'target-objects' not remade because of errors.
[task 2024-08-09T13:30:47.100Z] 13:30:47 ERROR - gmake[3]: *** [/builds/worker/checkouts/gecko/config/recurse.mk:72: toolkit/components/antitracking/bouncetrackingprotection/target-objects] Error 2
[task 2024-08-09T13:30:47.107Z] 13:30:47 INFO - gmake[4]: Entering directory '/builds/worker/workspace/obj-build/toolkit/components/glean/xpcom'
[task 2024-08-09T13:30:47.108Z] 13:30:47 INFO - mkdir -p '.deps/'
[task 2024-08-09T13:30:47.108Z] 13:30:47 INFO - gmake[4]: Leaving directory '/builds/worker/workspace/obj-build/toolkit/components/glean/xpcom'
Flags: needinfo?(pbz)
Pushed by pzuhlcke@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/21114fe770f3
Log a message to the web console if a site is classified as a potential bounce tracker. r=anti-tracking-reviewers,fluent-reviewers,bolsson,bvandersloot
| Assignee | ||
Updated•2 years ago
|
Flags: needinfo?(pbz)
Comment 5•2 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox131:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 131 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•