Open Bug 1844639 Opened 3 years ago Updated 6 months ago

toolkit/components/uniffi-js/UniFFICallbacks.cpp is not tested

Categories

(Toolkit :: UniFFI Bindings, enhancement)

enhancement

Tracking

()

ASSIGNED

People

(Reporter: janerik, Assigned: wenzhaoliao)

References

(Blocks 1 open bug)

Details

Attachments

(1 external file)

It seems like there are no automated tests for anything in toolkit/components/uniffi-js/UniFFICallbacks.cpp. This causes some "Lint: code coverage analysis" warnings.

I think this is tested by test_callbacks.js, however that is only enabled if MOZ_UNIFFI_FIXTURES is set.

I believe that flag can only be set manually by a dev in the mozconfig file. There's no CI test for it, we're basically using the honor system and asking devs to run those tests alongside any changes to uniffi.

Oh, TIL.
I filed this because of a warning like this: https://phabricator.services.mozilla.com/D181872#6085367

Assignee: nobody → wenzhaoliao
Status: NEW → ASSIGNED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: