1844665 - Access shopping.html as an about page to ensure it loads in the privileged about process

Status: RESOLVED FIXED

(Firefox :: Shopping, task, P1)

Description

[:Gijs (out for now; he/him)]

Per discussion with Nika, we can't really have a system privileged chrome URL load in a content process, it upsets various things that try to prevent that happening, like the assertion failure Katherine ran into in https://phabricator.services.mozilla.com/D183917#inline-1020546 .

The solution is basically to:

1. create an about: page (hidden from about:about, loading in the privileged about process)
2. ensure it loads in the privileged about process
3. set the XUL <browser> up with remoteType="privilegedabout" as well as maychangeremoteness=true so that any loads are guaranteed to pick the correct process
4. doublecheck the actors load and tests still pass (esp. all files referenced, as the about: page reference may change that)

Comment 1

[:Gijs (out for now; he/him)]

Attachment: Bug 1844665 - rename RPMSetBoolPref so it's more obvious you can use it for int/char prefs, r?mconley,jhirsch

Comment 2

[:Gijs (out for now; he/him)]

Attachment: Bug 1844665 - make reusable components OK with living in unprivileged documents, r?mstriemer,hjones

Depends on D184742

Comment 3

[:Gijs (out for now; he/him)]

Attachment: Bug 1844665 - use about: page for shopping to ensure process mechanics make sense, r?jhirsch!,nika!

Depends on D184743

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/af4999afee01
rename RPMSetBoolPref so it's more obvious you can use it for int/char prefs, r=jhirsch
https://hg.mozilla.org/integration/autoland/rev/c3a64755c336
make reusable components OK with living in unprivileged documents, r=hjones
https://hg.mozilla.org/integration/autoland/rev/c3c3a8d398dc
use about: page for shopping to ensure process mechanics make sense, r=jhirsch,nika

Comment 5

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/af4999afee01
https://hg.mozilla.org/mozilla-central/rev/c3a64755c336
https://hg.mozilla.org/mozilla-central/rev/c3c3a8d398dc