1845598 - Handle clicks on shopping sidebar header dismiss button

Status: VERIFIED FIXED

(Firefox :: Shopping, task, P1)

Description

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

When the sidebar header dismiss button (the 'X' button) is clicked, we want to hide all sidebars, same behavior as toggling the page action button.

To do this, we'll want to call RPMSetPref to flip the value of the browser.shopping.experience2023.active pref (which was added in Bug 1840156).

Comment 1

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Attachment: Bug 1845598 - Handle clicks on shopping sidebar header dismiss button r?#shopping-reviewers

• Clicking the dismiss button flips a pref that will be introduced in
  bug 1840156 (happening in parallel).

Also collected a few misc fixes:

• Refactored the CustomEvent names to be uniform ("Shopping:Foo").

• Added a test for the settings opt-out button click.

Comment 2

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

This was fixed in bug 1844665; closing as a dupe.

Comment 3

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

whoops, closed the wrong bug

Comment 4

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Attachment: Bug 1845598 - Handle clicks on shopping sidebar header dismiss button r?#shopping-reviewers

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/293ac65b56ac
Handle clicks on shopping sidebar header dismiss button r=shopping-reviewers,fchasen

Comment 6

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/293ac65b56ac

Comment 7

[Rares Doghi, Desktop QA]

Verified as fixed in our latest 119.0a1 (2023-08-28).