1845011 - F and N navigation buttons in 115 not working cross-folder

Status: RESOLVED FIXED

(Thunderbird :: Account Manager, defect)

Description

[fred]

Steps to reproduce:

This was in 115.0 but also 115.0.1.
I read a group of new messages in a folder. I use the F button to go to the next message. Or I use N to go to the next unread message.

Actual results:

The F button, with a message open, reads the next message as expected, but when it gets to the bottom of the folder, F reopens the same message, so it looks like I had a duplicate copy. In 102 and before, F at the bottom did nothing, letting me know I hit the bottom. This is bad behavior.

The N button, when pressed in the not-last unread message in a folder, reads the next unread message. But when it gets to the last message of a folder, instead of going to the next unread message in the next folder, it does nothing, which is actually what the F button was supposed to do in that case! This isn't necessarily bad behavior on the part of the N button, since the old way of going to another folder is not necessarily better than just stopping and letting you decide if you want to go to another folder, but it appears to be an undocumented change.

Expected results:

F should stop at the bottom. N should either go to another folder with unread message or there should be mention in the release notes of modified behavior.

Comment 1

[Geoff Lankow (:darktrojan)]

In 102 the behaviour of N is different depending on whether you're looking at a message in a tab or in a window. In a window it asks about going to the next folder, and does go there, but in a tab it asks and then closes the tab. I suspect that's not what is meant to happen.

In 115 we didn't implement cross-folder navigation outside the 3 pane tab, but that was a long time ago and I don't remember why. I think it can be added back reasonably easily.

Comment 2

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1845011 - Stop next/previous message commands reloading the message if there are no more. r=freaktechnik

Comment 3

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1845011 - Allow navigation commands to cross folders in message tabs/windows. r=freaktechnik

Depends on D185250

Comment 4

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1845011 - Test navigation commands in message tabs and windows. r=freaktechnik

Depends on D185251

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/55951b44b422
Stop next/previous message commands reloading the message if there are no more. r=freaktechnik
https://hg.mozilla.org/comm-central/rev/61a9e055a4fe
Allow navigation commands to cross folders in message tabs/windows. r=freaktechnik
https://hg.mozilla.org/comm-central/rev/263dc4251a6e
Test navigation commands in message tabs and windows. r=freaktechnik

Comment 6

[Wayne Mery (:wsmwk)]

Soeren, Calum,

Can you test the Aug. 8 daily?

Comment 7

[Calum Mackay]

Sorry, I'm not sure how to reproduce the problem? F & N seem to work as expected, for me on my current 7th Aug Daily.

Comment 8

[fred]

The bug I reported was apparently only relevant to message-in-window, not message-in-tab or 3-part-window format. Perhaps it is fixed in the latest internal build. In 115.1.0 it is still there. N in the last message in a folder does not go to an unread message in another folder. F in the last message causes the message window to refresh as if it were reading a new message, though it is reading the same one over again. That doesn't happen in a tab, where only the tab title repaints.

Comment 9

[Calum Mackay]

My apologies, I only tested tab, and 3-pane.

Testing in window…

0807 build

I find that F does nothing, on the last message; I cannot reproduce the re-painting.

But I agree that N does nothing, too, when it should advance to the next folder. This in 0807.

In 0808

I confirm the N behaviour has been fixed: it does now prompt me to move to the next folder.

F remains as before: does nothing, no re-painting.

MacOS 13.3.1 (a)

Comment 10

[Sören Hentzschel]

Works for me as well in Thunderbird Daily 118.0a1 (2023-08-10) on macOS 13.5.

Comment 11

[Geoff Lankow (:darktrojan)]

Comment on attachment 9347084 [details]
Bug 1845011 - Stop next/previous message commands reloading the message if there are no more. r=freaktechnik

[Approval Request Comment]
Regression caused by (bug #): supernova
User impact if declined: message navigation changed behaviour
Testing completed (on c-c, etc.): landed a week ago, with tests
Risk to taking this patch (and alternatives if risky): low

NB: three patches for uplift, and one dependency

Comment 12

[Wayne Mery (:wsmwk)]

Comment on attachment 9347084 [details]
Bug 1845011 - Stop next/previous message commands reloading the message if there are no more. r=freaktechnik

[Triage Comment]
Approved for beta

Comment 13

[Wayne Mery (:wsmwk)]

Comment on attachment 9347085 [details]
Bug 1845011 - Allow navigation commands to cross folders in message tabs/windows. r=freaktechnik

[Triage Comment]
Approved for beta

Comment 14

[Wayne Mery (:wsmwk)]

Comment on attachment 9347086 [details]
Bug 1845011 - Test navigation commands in message tabs and windows. r=freaktechnik

[Triage Comment]
Approved for beta

Comment 15

[Daniel Darnell [:dandarnell]]

Thunderbird 117.0b5:
https://hg.mozilla.org/releases/comm-beta/rev/a63cf49b360a
https://hg.mozilla.org/releases/comm-beta/rev/c805ed323957
https://hg.mozilla.org/releases/comm-beta/rev/3f7e120c65ca

Comment 16

[Wayne Mery (:wsmwk)]

Comment on attachment 9347084 [details]
Bug 1845011 - Stop next/previous message commands reloading the message if there are no more. r=freaktechnik

[Triage Comment]
Approved for esr115

taking this to go with uplift of bug 1846860

Comment 17

[Wayne Mery (:wsmwk)]

Comment on attachment 9347084 [details]
Bug 1845011 - Stop next/previous message commands reloading the message if there are no more. r=freaktechnik

[Triage Comment]
Approved for esr115

taking this to go with uplift of bug 1846860

Comment 18

[Wayne Mery (:wsmwk)]

Comment on attachment 9347084 [details]
Bug 1845011 - Stop next/previous message commands reloading the message if there are no more. r=freaktechnik

[Triage Comment]
Approved for esr115

taking this to go with uplift of bug 1846860

Comment 19

[Wayne Mery (:wsmwk)]

Comment on attachment 9347085 [details]
Bug 1845011 - Allow navigation commands to cross folders in message tabs/windows. r=freaktechnik

[Triage Comment]
Approved for esr115

Comment 20

[Wayne Mery (:wsmwk)]

Comment on attachment 9347086 [details]
Bug 1845011 - Test navigation commands in message tabs and windows. r=freaktechnik

[Triage Comment]
Approved for esr115

Comment 21

[Rob Lemley [:rjl]]

Thunderbird 115.2.0:
https://hg.mozilla.org/releases/comm-esr115/rev/a871104175c8
https://hg.mozilla.org/releases/comm-esr115/rev/d0a2bcd2ad84
https://hg.mozilla.org/releases/comm-esr115/rev/a9fef83303f1