1845087 - Added images, added text, and drawings to PDFs are not tagged

Status: VERIFIED FIXED

(Firefox :: PDF Viewer, defect, P1)

Description

[Adrian Roselli]

Attachment: PDF-UA_FF-nightly-add-img.pdf

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:109.0) Gecko/20100101 Firefox/115.0

Steps to reproduce:

1. Using Firefox Nightly (117) open a tagged PDF: https://adrianroselli.com/files/xfr/PDF-UA.pdf
2. Activate the "Add an image" button
3. Click or tap in the document
4. Choose an image from your computer
5. Embed the image

Actual results:

When I saved the PDF, the image was not added to the tag structure of the document, making it unavailable to my screen reader. This also means a document that conformed to PDF/UA no longer conforms.

Expected results:

When the PDF is saved the image should be folded into the document tags.

I attached the PDF I created with Firefox Nightly 117 to this issue so you can compare them.

Comment 1

[Calixte Denizet (:calixte)]

I'm a bit doubtful on we could/should do with a tagged pdf.
I understand that's an issue to not have the image in the tags set but the tag tree is supposed to reflect the structure of the document.
Here the user is just adding an image but we don't have any information about how the image is semantically linked to the other elements in the page.
Out of curiosity, I just added a stamp annotation (the kind of annotation we use in pdf.js to display the image) and an image in Acrobat Reader Pro and in both cases absolutely nothing has been added in the structure tree.
:Adrian, would you have any insights here ?

Comment 2

[Adrian Roselli]

In Acrobat Pro, open the Tags panel. From the Options button/menu thinger, choose "Tag Annotations".

Now when you add an annotation (a comment is easiest), you should be prompted to choose some part of the document structure (it defaults to "tag root" otherwise and should complain). This places a tag for the annotation in the tree. You can still place it visually anywhere on the page.

I understand this requires effort on the part of the author and they may choose not to do it, but this is for those who want (need) the option.

Comment 3

[James Teh [:Jamie]]

Can we use proximity in the text layer to figure out a reasonable location for the tag? Having UI to choose which part of the structure tree is probably out of scope for something which isn't a fully fledged PDF editor. However, not tagging images at all when we're offering image insertion is very problematic.

Comment 4

[Marco Castelluccio [:marco]]

This also applies to addition of text and drawings.

Comment 5

[BMO Github Automation]

Attachment: [mozilla/pdf.js] [Editor] Add the parent tag id (if any) to the serialized editors (bug 1845087) (#16916)

Comment 6

[BMO Github Automation]

Attachment: [mozilla/pdf.js] [Editor] Add the ability to create/update the structure tree when saving a pdf containing newly added annotations (bug 1845087) (#16938)

Comment 7

[Dana Lucaci, Desktop QA]

Reproduced the issue with Firefox 117.0a1 (2023-07-24) on macOS 12 ARM. Indeed after the PDF is saved the image was not added to the tag structure of the document.
The issue is verified fixed with Firefox 120.0a1 (20231004094640) and Firefox 119.0b4 (20231002091755) on macOS 12 ARM, Win 10 and Ubuntu 22.04. The image is added to the tag structure and is focused after right-clicking the image and inspecting both the accessibility properties and the image itself on the html doc.