1845088 - Make importing images PDF keyboard operable

Status: VERIFIED FIXED

(Firefox :: PDF Viewer, defect)

Description

[Adrian Roselli]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:109.0) Gecko/20100101 Firefox/115.0

Steps to reproduce:

1. Using Firefox Nightly (117) open a tagged PDF: https://adrianroselli.com/files/xfr/PDF-UA.pdf
2. Using only the keyboard, activate the "Add an image" button
3. If that does not work, use a pointer (mouse) to activate it
4. Using only the keyboard, place the image where you want it
5. If that does not work, use a pointer (mouse) to place the image
6. Using only your keyboard, try to move the image

Actual results:

1. Using only my keyboard, I was unable to trigger the button to add an image.
2. I used my mouse to trigger the button, but then I could not place the image using only my keyboard.
3. Once I placed the image with my mouse, I could not use my keyboard to select the image to move it.

Expected results:

1. I should be able to trigger the button using only my keyboard.
2. I should be able to place the image anywhere I want using only my keyboard.
3. I should be able to select and move the placed image using only my keyboard.

Comment 1

[Marco Castelluccio [:marco]]

Is this working for adding text?

Comment 2

[BMO Github Automation]

Attachment: [mozilla/pdf.js] [Editor] Make editors movable in using the keyboard (bug 1845088) (#16746)

Comment 3

[BMO Github Automation]

Attachment: [mozilla/pdf.js] [Editor] Add the possibility to move an empty freetext editor with the keyboard (bug 1845088) (#16750)

Comment 4

[Calixte Denizet (:calixte)]

Attachment: [Editor] Add the possibility to create a new editor in using the keyboard (bug 1845088)

Comment 5

[Marco Castelluccio [:marco]]

One patch still left to land before we can call this fixed.

Comment 6

[Marco Castelluccio [:marco]]

Actually, the last patch is not needed, this is working now thanks to bug 1848108.

Comment 7

[Marco Castelluccio [:marco]]

I'll move the "add text" part into a separate bug.

Comment 8

[Dana Lucaci, Desktop QA]

Reproduced the issue with Firefox 117.0a1 (2023-07-24) on macOS 12 ARM.
The issue is verified fixed with Firefox 120.0a1 (20231004094640) and Firefox 119.0b4 (20231002091755) on macOS 12 ARM, Win 10 and Ubuntu 22.04. The images can be added and moved using only the keyboard.