1845155 - In News, "RE: " is not replaced by "Re: " any more, broken via NNTP-JS

Status: RESOLVED FIXED

(MailNews Core :: Networking: NNTP, defect)

Description

[betterbird.project+7]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/115.0.0.0 Safari/537.36 Edg/115.0.1901.183

Steps to reproduce:

Previously done here:
https://searchfox.org/comm-esr102/search?q=NS_MsgStripRE&path=nsNNTPNewsgroupList.cpp&case=false&regexp=false

We'll post a patch

Comment 1

[betterbird.project+7]

https://github.com/Betterbird/thunderbird-patches/blob/main/115/bugs/1845155-NS_MsgStripRE-for-NNTP.patch

Comment 2

[Hartmut Welpmann [:welpy-cw]]

Attachment: Bug 1845155 - Strip localized Re: prefixes in NNTP messages. r=mkmelin

Comment 3

[betterbird.project+9]

... just returns "chrome://messenger-region/locale/region.properties" when the user hasn't edited the preference.

Good catch. This should be localised by the localisers, see here for example:
https://hg.mozilla.org/projects/comm-l10n/file/tip/de/mail/chrome/messenger-region/region.properties#l29
Usually users don't edit the pref unless they are multi-lingual.

Admittedly, the C++ code is more careful:
https://searchfox.org/comm-central/rev/570e29bd6159a910d43fc0e4f8fedfffb9357f6a/mailnews/base/src/nsMsgUtils.cpp#535

Comment 4

[betterbird.project+10]

Are you sure that getComplexValue() ... .data always returns a string even if the locale is misconfigured? No null or undefined possible? In our opinion if (rawPrefixes.length) { was the safer bet.

Comment 5

[betterbird.project+10]

No, just if (rawPrefixes) {.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/0946cce6a08d
Strip localized Re: prefixes in NNTP messages. r=mkmelin

Comment 7

[Hartmut Welpmann [:welpy-cw]]

Comment on attachment 9352204 [details]
Bug 1845155 - Strip localized Re: prefixes in NNTP messages. r=mkmelin

[Approval Request Comment]
Regression caused by (bug #): nntp-js
User impact if declined: Localized Re: prefixes aren't handled correctly in Usenet messages.
Testing completed (on c-c, etc.): c-c and beta
Risk to taking this patch (and alternatives if risky): low

Comment 8

[Wayne Mery (:wsmwk)]

Comment on attachment 9352204 [details]
Bug 1845155 - Strip localized Re: prefixes in NNTP messages. r=mkmelin

[Triage Comment]
Approved for esr115

Comment 9

[Rob Lemley [:rjl]]

Thunderbird 115.3.2:
https://hg.mozilla.org/releases/comm-esr115/rev/c417b1df636a