184518 - Typeaheadfind repeated character mode not working when it requires >2 chars to start

Status: VERIFIED FIXED

(SeaMonkey :: Find In Page, defect)

Description

[Aaron Leventhal]

When you type the same character several times, typeaheadfind is supposed to
eventually search only for links that start with that character.

This no longer works, not sure when it regressed.

Comment 1

[Aaron Leventhal]

Attachment: Make sure repeated character find code gets called, mode gets set on success

Comment 2

[sairuh (rarely reading bugmail)]

really? this WFM using today's trunk (commercial, 2002120908) build on linux rh8
and win2k. unless this is a debug-only issue.

tested on http://mozilla.org by hitting the letter 'm' repeatedly: taf found
links beginning with the letter 'm'.

Comment 3

[Aaron Leventhal]

Sarah, try "dd" and then "ddd" in www.mozilla.org. That's the case that's not
working.

Will submit patch soon.

Comment 4

[sairuh (rarely reading bugmail)]

ah, i see what you mean --thanks for the clarification!

Comment 5

[Johnny Stenback (:jst)]

Comment on attachment 108777 [details] [diff] [review]
Make sure repeated character find code gets called, mode gets set on success

sr=jst

Comment 6

[Aaron Leventhal]

Attachment: Better patch, after getting feedback from Sairuh about exact bug.

Comment 7

[Christopher Aillon (sabbatical, not receiving bugmail)]

Comment on attachment 108815 [details] [diff] [review]
Better patch, after getting feedback from Sairuh about exact bug.

I wonder if it would be a good idea to move typeahead away from the many
PRPackedBools for everything and maybe just use a PRUint16 (32?) bitmask of
mFlags or something for the various things going on.  Nonetheless, that's not
in the scope of this bug, but would be something to consider maybe.  r=caillon
for this patch.

Also, alecf is on vacation for a while IIRC, so you may want to find a
different sr.

Comment 8

[Aaron Leventhal]

Comment on attachment 108815 [details] [diff] [review]
Better patch, after getting feedback from Sairuh about exact bug.

Johnny, sorry for the bogus original sr= request. This one's for real.

Apparently marking a patch obsolete doesn't kill the review requests.

Comment 9

[Johnny Stenback (:jst)]

Comment on attachment 108815 [details] [diff] [review]
Better patch, after getting feedback from Sairuh about exact bug.

sr=jst

Comment 10

[Aaron Leventhal]

fixed

Comment 11

[Aaron Leventhal]

checked this in last week

Comment 12

[sairuh (rarely reading bugmail)]

vrfy'd fixed using 2003.01.08 trunk bits on win2k, mac os x 10.2.3 and linus rh8.