Typeaheadfind repeated character mode not working when it requires >2 chars to start

VERIFIED FIXED

Status

SeaMonkey
Find In Page
VERIFIED FIXED
16 years ago
10 years ago

People

(Reporter: Aaron Leventhal, Assigned: Aaron Leventhal)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

16 years ago
When you type the same character several times, typeaheadfind is supposed to
eventually search only for links that start with that character.

This no longer works, not sure when it regressed.
(Assignee)

Comment 1

16 years ago
Created attachment 108777 [details] [diff] [review]
Make sure repeated character find code gets called, mode gets set on success
(Assignee)

Updated

16 years ago
Attachment #108777 - Flags: superreview?(jst)
Attachment #108777 - Flags: review?(caillon)
really? this WFM using today's trunk (commercial, 2002120908) build on linux rh8
and win2k. unless this is a debug-only issue.

tested on http://mozilla.org by hitting the letter 'm' repeatedly: taf found
links beginning with the letter 'm'.
(Assignee)

Updated

16 years ago
Attachment #108777 - Attachment is obsolete: true
(Assignee)

Comment 3

16 years ago
Sarah, try "dd" and then "ddd" in www.mozilla.org. That's the case that's not
working.

Will submit patch soon.
Summary: Typeaheadfind repeated character mode no longer working → Typeaheadfind repeated character mode not working when it requires >2 chars to start
ah, i see what you mean --thanks for the clarification!
Comment on attachment 108777 [details] [diff] [review]
Make sure repeated character find code gets called, mode gets set on success

sr=jst
Attachment #108777 - Flags: superreview?(jst) → superreview+
(Assignee)

Updated

16 years ago
Attachment #108777 - Flags: review?(caillon)
(Assignee)

Comment 6

16 years ago
Created attachment 108815 [details] [diff] [review]
Better patch, after getting feedback from Sairuh about exact bug.
(Assignee)

Updated

16 years ago
Attachment #108815 - Flags: superreview?(alecf)
Attachment #108815 - Flags: review?(caillon)
Comment on attachment 108815 [details] [diff] [review]
Better patch, after getting feedback from Sairuh about exact bug.

I wonder if it would be a good idea to move typeahead away from the many
PRPackedBools for everything and maybe just use a PRUint16 (32?) bitmask of
mFlags or something for the various things going on.  Nonetheless, that's not
in the scope of this bug, but would be something to consider maybe.  r=caillon
for this patch.

Also, alecf is on vacation for a while IIRC, so you may want to find a
different sr.
Attachment #108815 - Flags: review?(caillon) → review+
(Assignee)

Comment 8

16 years ago
Comment on attachment 108815 [details] [diff] [review]
Better patch, after getting feedback from Sairuh about exact bug.

Johnny, sorry for the bogus original sr= request. This one's for real.

Apparently marking a patch obsolete doesn't kill the review requests.
Attachment #108815 - Flags: superreview?(alecf) → superreview?(jst)
Comment on attachment 108815 [details] [diff] [review]
Better patch, after getting feedback from Sairuh about exact bug.

sr=jst
Attachment #108815 - Flags: superreview?(jst) → superreview+
(Assignee)

Comment 10

16 years ago
fixed
Status: NEW → ASSIGNED
(Assignee)

Comment 11

16 years ago
checked this in last week
Status: ASSIGNED → RESOLVED
Last Resolved: 16 years ago
Resolution: --- → FIXED

Updated

16 years ago
Component: Keyboard: Navigation → Keyboard: Find as you Type
vrfy'd fixed using 2003.01.08 trunk bits on win2k, mac os x 10.2.3 and linus rh8.
Status: RESOLVED → VERIFIED
Product: Core → SeaMonkey
You need to log in before you can comment on or make changes to this bug.