1845252 - Convert FxAccountsCommon.js to an ES module

Status: RESOLVED FIXED

(Firefox :: Firefox Accounts, task)

Description

[Mark Banner (:standard8)]

FxAccountsCommon.js is a module file which uses a slightly non-standard jsm exports format, and therefore isn't being picked up by automation which is why we haven't spotted it yet.

We should convert it to an ES module as well.

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1845252 - Convert FxAccountsCommon.js to an ES module. r?markh!

Comment 2

[Mark Banner (:standard8)]

Attachment: Bug 1845252 - Update consumers of FxAccountsCommon to import the ES module directly. r?markh!

Depends on D184779

Comment 3

[Mark Banner (:standard8)]

Attachment: Bug 1845252 - Convert FxAccountsCommon.js to an ES module. r?markh!

Comment 4

[Mark Banner (:standard8)]

Attachment: Bug 1845252 - Update consumers of FxAccountsCommon to import the ES module directly. r?markh!

Depends on D184831

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/683a87892126
Convert FxAccountsCommon.js to an ES module. r=markh
https://hg.mozilla.org/integration/autoland/rev/d58bbd55cb35
Update consumers of FxAccountsCommon to import the ES module directly. r=markh,settings-reviewers,credential-management-reviewers,sync-reviewers,sgalich,Gijs

Comment 6

[Serban Stanca [:SerbanS]]

Backed out for causing mochitests failures in browser_fxa_web_channel.js.

• Backout link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | browser/base/content/test/sync/browser_fxa_web_channel.js | Unexpected Exception: TypeError: can't access property "ON_PROFILE_CHANGE_NOTIFICATION", FxAccountsCommon is undefined - false == true - {"filename":"chrome://mochitests/content/browser/browser/base/content/test/sync/browser_fxa_web_channel.js","name":"test/<","sourceId":687,"lineNumber":276,"columnNumber":12,"sourceLine":"","asyncCause":null,"asyncCaller":null,"

Comment 7

[Mark Banner (:standard8)]

Fixed tests.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/899588327e70
Convert FxAccountsCommon.js to an ES module. r=markh
https://hg.mozilla.org/integration/autoland/rev/25069a171ece
Update consumers of FxAccountsCommon to import the ES module directly. r=markh,settings-reviewers,credential-management-reviewers,sync-reviewers,sgalich,Gijs

Comment 9

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/899588327e70
https://hg.mozilla.org/mozilla-central/rev/25069a171ece