1858025 - Correctly clear pref in SyncDisconnect module

Status: VERIFIED FIXED

(Firefox :: Sync, defect)

Comment 1

[Mathew Hodson]

Attachment: Bug 1858025 - Correctly clear pref in SyncDisconnect module. r?skhamis

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1845252

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6700abaef0f9
Correctly clear pref in SyncDisconnect module. r=skhamis,sync-reviewers

Comment 4

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/6700abaef0f9

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:mathew.hodson, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox119 to wontfix.

For more information, please visit BugBot documentation.

Comment 6

[Mathew Hodson]

Attachment: Bug 1858025 - Correctly clear pref in SyncDisconnect module.

Original Revision: https://phabricator.services.mozilla.com/D190517

Comment 7

[Phabricator Automation]

Uplift Approval Request

• Steps to reproduce for manual QE testing: 1. Login to Sync
• User impact if declined: Uneeded warning when disconnecting from Sync and then a different user signs in
• Risk associated with taking this patch: low
• Explanation of risk level: Small change to use pre-existing constant value
• Needs manual QE test: no
• Is Android affected?: yes
• String changes made/needed: no
• Fix verified in Nightly: yes
• Code covered by automated testing: yes

Comment 8

[Phabricator Automation]

Uplift Approval Request

• Fix verified in Nightly: yes
• Code covered by automated testing: yes
• String changes made/needed: no
• Explanation of risk level: Small change to use pre-existing constant value
• User impact if declined: Uneeded warning when disconnecting from Sync and then a different user signs in
• Steps to reproduce for manual QE testing: 1. Login to Sync 2. Manually set pref "identity.fxaccounts.lastSignedInUserHash" 3. Disconnect from Sync 4. Confirm that the pref was cleared
• Needs manual QE test: no
• Is Android affected?: yes
• Risk associated with taking this patch: low

Comment 9

[Donal Meehan [:dmeehan]]

Comment on attachment 9358432 [details]
Bug 1858025 - Correctly clear pref in SyncDisconnect module.

Approved for 119.0 RC1

Comment 10

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/f2a69b23cb0a

Comment 11

[Maria Berlinger [:mberlinger], Services QA]

Hello,

I was able to reproduce the issue using Firefox 118.0.2.

This is verified as fixed using Firefox 119.0 and Firefox nightly 120.0a1. The "identity.fxaccounts.lastSignedInUserHash" pref is deleted after signing out to Sync and checking the "Delete data from this device (passwords.history, bookmarks, etc.)" option.
The pref is automatically created after signing back in to sync.

Also, if the "Delete data from this device (passwords.history, bookmarks, etc.)" option is not checked when signing out, the pref is not deleted.