1845323 - Implement "progress" popup in the install flow

Status: VERIFIED FIXED

(Firefox for Android :: WebExtensions, enhancement)

Description

[William Durand [:willdurand]]

We removed a "downloading" popup in Bug 1839651 because it was (1) no longer working and (2) fundamentally broken anyway. It is a bit odd to have no UI when starting the install of an add-on, though, possibly because of the time it takes to download an XPI.

We should re-introduce a "progress" popup (similar to what we have on Desktop).

Comment 1

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1845323 - Add download add-on dialog (#3123)

Comment 2

[Arturo Mejia [:amejia]]

We are bringing back the previous implementation of the dialog. Handling the dialog directly on the Fenix add-on manager, as we realized Firefox desktop is doing the same behaviour, it's not showing the downloading dialog when installing from the AMO website.

Comment 3

[Arturo Mejia [:amejia]]

Just to add more clarification to my previous comment: This dialog is only shown when the install starts from the Fenix add-ons manager, that this is on purpose because an install flow started with mozAddonManager doesn't have such progress popup on Desktop, and therefore that we have the exact same behaviour on both Fenix and Desktop.

Comment 4

[BMO Github Automation]

Authored by https://github.com/Amejia481
https://github.com/mozilla-mobile/firefox-android/commit/920ae9f49ee6470d335b69589e8d35f6722da8d2
[main] Bug 1845323 - Bring back the downloading add-on dialog.

Comment 5

[Delia Pop (Android QA)]

Attachment: 1691672863532.JPEG

Verified as fixed in latest Nightly 118.0a1 from 08/10 with Samsung Galaxy A53 5G (Android 13). The "Downloading and verifying add-on..." dialogue is displayed right after attempting to install an add-on in the fenix Add-ons Manager.