1845710 - [UrlbarView] Add LRM to URLs with the protocol trimmed in the results pane

Status: RESOLVED FIXED

(Firefox :: Address Bar, defect, P3)

Description

[Dão Gottwald [:dao]]

+++ This bug was initially created as a clone of Bug #1836962 +++

Bug 1836962 handles URLs in the address bar input, but we still need to take care of URLs in the address bar results, I think? https://searchfox.org/mozilla-central/rev/00e6644d0db8acf9372702324151b8077a3d2bb7/browser/components/urlbar/UrlbarResult.sys.mjs#265-270

Comment 1

[Marco Bonardo [:mak]]

I suspect for results we COULD use the LRM trick, since it's just visual.

This is mostly for consistency, since results cannot be use for phishing content (even if they may still be confusing and there's no formatting)

Comment 2

[Marc Seibert (:mseibert)]

@dao Could you provide a case where the displayedUrl would require an LTR marker? Results, as far as I can tell, are always encoded in punycode.

Comment 3

[Marc Seibert (:mseibert)]

Attachment: Bug 1845710 - [UrlbarView] Add LRM to URLs with the protocol trimmed in the results pane.r=mak

Comment 4

[Dão Gottwald [:dao]]

As discussed on slack, let's figure out why we (might need to) display result URLs in punycode and if we can change that to make them consistent with how we display the current page's URL.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f6c351ade4f2
[UrlbarView] Add LRM to URLs with the protocol trimmed in the results pane.r=mak

Comment 6

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/f6c351ade4f2