1845747 - Add new trigger for onboarding experiment

Status: VERIFIED FIXED

(Fenix :: Onboarding, task, P1)

Description

[Daniela Arcese [:daniela]]

I need a button action added for an onboarding experiment.

It should prompt the 'Add search widget' system dialog.

The brief is here https://docs.google.com/document/d/1wuyDtm4miBMOHJlL7RsO0symOmogs9AwiIij_Drccws/edit#heading=h.4sp6t4yuhnu2.

Comment 1

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1845747 - Add "Add search widget" card for Juno Onboarding (#3310)

Comment 5

[BMO Github Automation]

Authored by https://github.com/DreVla
https://github.com/mozilla-mobile/firefox-android/commit/cba23f261cb6b81b60f994022ae41967e7915ade
[main] Bug 1845747 - Add "Add search widget" card for Juno Onboarding

Authored by https://github.com/DreVla
https://github.com/mozilla-mobile/firefox-android/commit/30a4e7d1d9b879f7862217276cb2ce7c4af04c05
[main] Bug 1845747 - Allow enabling/disabling of onboarding cards

Comment 6

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1845747 - Add "Add search widget" card for Juno Onboarding (backport #3310) (#3645)

Comment 7

[Vlad Dreghici [:vdreghici]]

Comment on attachment 9353184 [details] [review]
[mozilla-mobile/firefox-android] Bug 1845747 - Add "Add search widget" card for Juno Onboarding (backport #3310) (#3645)

Beta/Release Uplift Approval Request

• User impact if declined: We are aiming to launch the "Add Search widget experiment" in 118. If declined, the experiment will not be conducted, and it will affect the Juno Onboarding experience, the add search widget card not being shown to users.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: In order to run the experiment, a member of the experiments team will be required to run the app using the nimbus cli command.
• List of other uplifts needed: none
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Currently, the patch only adds an extra card to the onboarding experience. In order for the user to actually see it, they would have to be enrolled in the experiment here. The experiment is currently in preview, and will require testing.
• String changes made/needed: there are strings, but they're only used for an experiment involving English
• Is Android affected?: Yes

Comment 8

[Pascal Chevrel:pascalc]

Comment on attachment 9353184 [details] [review]
[mozilla-mobile/firefox-android] Bug 1845747 - Add "Add search widget" card for Juno Onboarding (backport #3310) (#3645)

Approved for 118.0b9 (last beta)  thanks.

Comment 9

[BMO Github Automation]

Authored by https://github.com/DreVla
https://github.com/mozilla-mobile/firefox-android/commit/7d8333b3138e31bb7f63c2fe1c90dd1de0269484
[releases_v118] Bug 1845747 - Add "Add search widget" card for Juno Onboarding

Authored by https://github.com/DreVla
https://github.com/mozilla-mobile/firefox-android/commit/c836a86646acb7ef2ca2bb5b78a363a641968991
[releases_v118] Bug 1845747 - Allow enabling/disabling of onboarding cards

Authored by https://github.com/pascalchevrel
https://github.com/mozilla-mobile/firefox-android/commit/f3afbd968eb23ea41fc2b380b83e66a9a6895ce1
[releases_v118] Merge pull request #3645 from mozilla-mobile/mergify/bp/releases_v118/pr-3310

Comment 10

[Carmen Tataru [:ctataru], Ecosystem QA]

I have verified that this issue is no longer reproducible using Firefox Beta 118.0b9 (BUILD ID #2015974267), 23c3ed5b9b+, GV: 118.0 - 20230914180032, AS: 118.0 and Firefox Nightly 119.0a1, (BUILD ID: #2015975011), 7ob13eb17+, GV: 119.0a1 -20230918144266, AS: 119.20230916050403 on Samsung Galaxy Tab A8 - Android 13. The button action is added for the onboarding experiment.