Closed Bug 1845794 Opened 7 months ago Closed 4 months ago

Create a beta branding variation for Thunderbird

Categories

(Thunderbird :: General, task)

Tracking

(thunderbird_esr115 wontfix, thunderbird120 fixed)

RESOLVED FIXED
121 Branch
Tracking Status
thunderbird_esr115 --- wontfix
thunderbird120 --- fixed

People

(Reporter: aleca, Assigned: rjl)

References

Details

Attachments

(4 files)

We currently only have branding/nightly/ and branding/thunderbird/ folders to control our assets for the release channels.
We're missing a branding/beta/ so we can add the variation we have of the new logo.

It would be nice to have this before beta 118.

Duplicate of this bug: 1705914

This patch covers the non-image assets for "tb_beta" branding.

At the moment, these files are the same as "thunderbird" branding in order to
facilitate testing. The expectation is that prior to landing this bug, new artwork
will be provided by the design team.

Depends on D186655

Did you send artwork for this yet?
The files that need updating are in the second patch.

Flags: needinfo?(alessandro)

Random update...

There's no bug for this currently because it's sort of a skunkworks project I've been trying to get working for some time. I now have a proof of concept working (hopefully) in https://treeherder.mozilla.org/jobs?repo=try-comm-central&revision=0d4add51e8a8b48b9d4b83779587c1abd191d057

A little background:
The Windows NSIS installer has a self-extracting header based on 7zip. This SFX header/stub is precompiled and lives in comm/other-licenses/7zstub/thunderbird/7zSD.sfx. There's reason's for this I won't get into, they're documented in the equivalent directory of mozilla-central.

Since this file is used for all Thunderbird versions and brandings, all Windows installers use the same icon. Furthermore, inspecting the details tab of the final installer properties in Windows, you will see funny versions like "18.0.5" no matter what.

This "version bug" has been brought up a few times by users of Firefox and Thunderbird and has always been closed "WONTFIX" due to the above mentioned reasons. Basically, modifying the version values in a compiled file is a pain.

I have identified a MIT-licensed Python package that can update resources in a compiled Windows executable, and have hacked it into the build system enough to set the stub's version fields to reflect the Thunderbird version and modify the installer icon based on branding (sort of.. it's hard coded right now and needs finishing).

I hope to finish this code up and land soon. A proper bug will be filed soon.

Redirecting this to Micah.
Please sync up with Rob to send the beta artwork

Flags: needinfo?(alessandro) → needinfo?(micah)
Flags: needinfo?(micah)
Attachment #9349886 - Attachment description: WIP: Bug 1845794 - Create a "beta" branding directory. → Bug 1845794 - Create a "beta" branding directory. r=#!thunderbird-build-system-reviewers,#thunderbird-reviewers
Attachment #9349887 - Attachment description: WIP: Bug 1845794 - tb_beta branding artwork. → Bug 1845794 - tb_beta branding artwork. r=#thunderbird-front-end-reviewers

Pushed by thunderbird@calypsoblue.org:
https://hg.mozilla.org/comm-central/rev/7df402faeded
Create a "beta" branding directory. r=dandarnell#!thunderbird-build-system-reviewers,#thunderbird-reviewers
https://hg.mozilla.org/comm-central/rev/5515b6fa5275
tb_beta branding artwork. r=aleca

Status: NEW → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Status: RESOLVED → REOPENED
Resolution: FIXED → ---

Fix for strings build failure on beta.

Target Milestone: --- → 121 Branch
Status: REOPENED → RESOLVED
Closed: 4 months ago4 months ago
Resolution: --- → FIXED

Comment on attachment 9349886 [details]
Bug 1845794 - Create a "beta" branding directory. r=#!thunderbird-build-system-reviewers,#thunderbird-reviewers

[Approval Request Comment]
Regression caused by (bug #): N/A
User impact if declined: none
Testing completed (on c-c, etc.): local testing
Risk to taking this patch (and alternatives if risky):
This was originally in beta1, but was backed out due to strings problems. That's been fixed. All three patches need uplift to beta.

Attachment #9349886 - Flags: approval-comm-beta?

Comment on attachment 9349886 [details]
Bug 1845794 - Create a "beta" branding directory. r=#!thunderbird-build-system-reviewers,#thunderbird-reviewers

[Triage Comment]
Approved for beta

Attachment #9349886 - Flags: approval-comm-beta? → approval-comm-beta+

Comment on attachment 9349887 [details]
Bug 1845794 - tb_beta branding artwork. r=#thunderbird-front-end-reviewers

[Triage Comment]
Approved for beta

Attachment #9349887 - Flags: approval-comm-beta+

Comment on attachment 9359879 [details]
Bug 1845794 - Expose beta brand strings. r=#thunderbird-reviewers

[Triage Comment]
Approved for beta

Attachment #9359879 - Flags: approval-comm-beta+

Removed an extra pixel making each of these too wide.

Status: RESOLVED → REOPENED
Resolution: FIXED → ---

Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/2672c3888c56
Resize default*.png icons correctly. r=darktrojan

Status: REOPENED → RESOLVED
Closed: 4 months ago4 months ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.