1845794 - Create a beta branding variation for Thunderbird

Status: RESOLVED FIXED

(Thunderbird :: General, task)

Description

[Alessandro Castellani [:aleca]]

We currently only have branding/nightly/ and branding/thunderbird/ folders to control our assets for the release channels.
We're missing a branding/beta/ so we can add the variation we have of the new logo.

It would be nice to have this before beta 118.

Comment 2

[Rob Lemley [:rjl]]

Attachment: Bug 1845794 - Create a "beta" branding directory. r=#!thunderbird-build-system-reviewers,#thunderbird-reviewers

This patch covers the non-image assets for "tb_beta" branding.

Comment 3

[Rob Lemley [:rjl]]

Attachment: Bug 1845794 - tb_beta branding artwork. r=#thunderbird-front-end-reviewers

At the moment, these files are the same as "thunderbird" branding in order to
facilitate testing. The expectation is that prior to landing this bug, new artwork
will be provided by the design team.

Depends on D186655

Comment 4

[Rob Lemley [:rjl]]

Did you send artwork for this yet?
The files that need updating are in the second patch.

Comment 5

[Rob Lemley [:rjl]]

Random update...

There's no bug for this currently because it's sort of a skunkworks project I've been trying to get working for some time. I now have a proof of concept working (hopefully) in https://treeherder.mozilla.org/jobs?repo=try-comm-central&revision=0d4add51e8a8b48b9d4b83779587c1abd191d057

A little background:
The Windows NSIS installer has a self-extracting header based on 7zip. This SFX header/stub is precompiled and lives in comm/other-licenses/7zstub/thunderbird/7zSD.sfx. There's reason's for this I won't get into, they're documented in the equivalent directory of mozilla-central.

Since this file is used for all Thunderbird versions and brandings, all Windows installers use the same icon. Furthermore, inspecting the details tab of the final installer properties in Windows, you will see funny versions like "18.0.5" no matter what.

This "version bug" has been brought up a few times by users of Firefox and Thunderbird and has always been closed "WONTFIX" due to the above mentioned reasons. Basically, modifying the version values in a compiled file is a pain.

I have identified a MIT-licensed Python package that can update resources in a compiled Windows executable, and have hacked it into the build system enough to set the stub's version fields to reflect the Thunderbird version and modify the installer icon based on branding (sort of.. it's hard coded right now and needs finishing).

I hope to finish this code up and land soon. A proper bug will be filed soon.

Comment 6

[Alessandro Castellani [:aleca]]

Redirecting this to Micah.
Please sync up with Rob to send the beta artwork

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/7df402faeded
Create a "beta" branding directory. r=dandarnell#!thunderbird-build-system-reviewers,#thunderbird-reviewers
https://hg.mozilla.org/comm-central/rev/5515b6fa5275
tb_beta branding artwork. r=aleca

Comment 8

[Rob Lemley [:rjl]]

Attachment: Bug 1845794 - Expose beta brand strings. r=#thunderbird-reviewers

Fix for strings build failure on beta.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/3e15e62e87e6
Expose beta brand strings. r=aleca

Comment 10

[Rob Lemley [:rjl]]

Comment on attachment 9349886 [details]
Bug 1845794 - Create a "beta" branding directory. r=#!thunderbird-build-system-reviewers,#thunderbird-reviewers

[Approval Request Comment]
Regression caused by (bug #): N/A
User impact if declined: none
Testing completed (on c-c, etc.): local testing
Risk to taking this patch (and alternatives if risky):
This was originally in beta1, but was backed out due to strings problems. That's been fixed. All three patches need uplift to beta.

Comment 11

[Wayne Mery (:wsmwk)]

Comment on attachment 9349886 [details]
Bug 1845794 - Create a "beta" branding directory. r=#!thunderbird-build-system-reviewers,#thunderbird-reviewers

[Triage Comment]
Approved for beta

Comment 12

[Wayne Mery (:wsmwk)]

Comment on attachment 9349887 [details]
Bug 1845794 - tb_beta branding artwork. r=#thunderbird-front-end-reviewers

[Triage Comment]
Approved for beta

Comment 13

[Wayne Mery (:wsmwk)]

Comment on attachment 9359879 [details]
Bug 1845794 - Expose beta brand strings. r=#thunderbird-reviewers

[Triage Comment]
Approved for beta

Comment 14

[Rob Lemley [:rjl]]

Thunderbird 120.0b2:
https://hg.mozilla.org/releases/comm-beta/rev/5470fc5229fb
https://hg.mozilla.org/releases/comm-beta/rev/7d33eb274cae
https://hg.mozilla.org/releases/comm-beta/rev/22e2e3041d66

Comment 15

[Rob Lemley [:rjl]]

Attachment: Bug 1845794 - Resize default*.png icons correctly. r=#thunderbird-front-end-reviewers

Removed an extra pixel making each of these too wide.

Comment 16

[Rob Lemley [:rjl]]

Backout beta 120.0b2:
https://hg.mozilla.org/releases/comm-beta/rev/2bcdb20c3bff1086b4b57f065ca7b32c5ef89493

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/2672c3888c56
Resize default*.png icons correctly. r=darktrojan

Comment 18

[Rob Lemley [:rjl]]

Thunderbird 120.0b3:
https://hg.mozilla.org/releases/comm-beta/rev/88c7c4eab065
https://hg.mozilla.org/releases/comm-beta/rev/977ed3b0710b -- includes fixed icons from 2672c3888c56
https://hg.mozilla.org/releases/comm-beta/rev/bfdf7fbbb313