1845797 - Remove `reload-default-prefs` observer notification

Status: RESOLVED FIXED

(Toolkit :: Preferences, task, P3)

Description

[Nick Alexander :nalexander [he/him]]

reload-default-prefs is a footgun: in normal operating conditions, it creates a new legacy Telemetry client ID! See Bug 1845338. That was the last consumer; this ticket tracks removing it, that is excising https://searchfox.org/mozilla-central/rev/50588a0b728b365afdd298debd35e8302efe7850/modules/libpref/Preferences.cpp#3958-3961.

Comment 1

[Nick Alexander :nalexander [he/him]]

This is a good first bug: those lines of code need to be deleted but there are no consumers and no tests of the functionality :)

Comment 2

[Nick Alexander :nalexander [he/him]]

(In reply to Nick Alexander :nalexander [he/him] from comment #1)

This is a good first bug: those lines of code need to be deleted but there are no consumers and no tests of the functionality :)

And no consumers in Thunderbird: https://searchfox.org/comm-central/search?q=reload-default-prefs&path=&case=false&regexp=false.

Comment 3

[Richard Cole]

I'm a new contributor, and I'll be submitting a patch for this bug soon.

Comment 4

[:Gijs (he/him)]

Thanks, Richard! Let us know if you need any help.

Comment 5

[Richard Cole]

Attachment: WIP: Bug 1845797 - Remove reload-default-prefs observer notification

Comment 6

[Richard Cole]

Attachment: Bug 1845797 - Remove reload-default-prefs observer notification. r?nalexander

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f79a8a69f1e5
Remove reload-default-prefs observer notification. r=nalexander

Comment 8

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/f79a8a69f1e5