1845832 - "Show New Mail Alert for" X seconds input field is calculated with 0 px width for l10n builds

Status: RESOLVED FIXED

(Thunderbird :: Preferences, defect)

Description

[Alex Ihrig [:Thunderbird_Mail_DE]]

Affected is at least German l10n in Thunderbird 115.0.1

In Thunderbird 115 the preference for notification / new mail alert for X seconds can not be edited, because of the HTML input fields CSS width calculation to 0 px. The input field should have a CSS min-with and the complete dialog overlay should be resized accoding to its content, which is not the case.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: Bug 1845832 - Set a min-width on the Notification dialog totalOpenTime input. r=#thunderbird-front-end-reviewers

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/f08e09d9fc51
Set a min-width on the Notification dialog totalOpenTime input. r=aleca

Comment 3

[Richard Marti (:Paenglab)]

Comment on attachment 9346356 [details]
Bug 1845832 - Set a min-width on the Notification dialog totalOpenTime input. r=#thunderbird-front-end-reviewers

[Approval Request Comment]
Regression caused by (bug #): new flexbox model
User impact if declined: on some locales not or almost not showing of totalOpenTime input
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): low

Comment 4

[Alex Ihrig [:Thunderbird_Mail_DE]]

Attachment: min-width doesn't fix it completely, because of the not scaling dialog box

Comment 5

[Alex Ihrig [:Thunderbird_Mail_DE]]

The min-width doesn't fix it completely, because of the not scaling dialog box - the text after the input field doesn't fit in the dialog box.

Comment 6

[Richard Marti (:Paenglab)]

Attachment: image.png

Here this works.

Comment 7

[Alex Ihrig [:Thunderbird_Mail_DE]]

Wierd, in todays Daily it works for me, too.

Comment 8

[Wayne Mery (:wsmwk)]

Comment on attachment 9346356 [details]
Bug 1845832 - Set a min-width on the Notification dialog totalOpenTime input. r=#thunderbird-front-end-reviewers

[Triage Comment]
Approved for beta

Comment 9

[Daniel Darnell [:dandarnell]]

Thunderbird 117.0b2:
https://hg.mozilla.org/releases/comm-beta/rev/90b0d376bb66

Comment 10

[Wayne Mery (:wsmwk)]

Comment on attachment 9346356 [details]
Bug 1845832 - Set a min-width on the Notification dialog totalOpenTime input. r=#thunderbird-front-end-reviewers

[Triage Comment]
Approved for esr115

Comment 11

[Rob Lemley [:rjl]]

Thunderbird 115.1.1:
https://hg.mozilla.org/releases/comm-esr115/rev/7f51d3177a33