Consider moving logic from browser.js / browser-sidebar.js into the parent shopping actor (ShoppingSidebarParent.sys.mjs)
Categories
(Firefox :: Shopping, task, P3)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox121 | --- | fixed |
People
(Reporter: Gijs, Assigned: niklas, NeedInfo)
References
(Blocks 1 open bug)
Details
(Whiteboard: [fidefe-shopping])
Attachments
(1 file)
See https://phabricator.services.mozilla.com/D184744#6108084 for more context on this. This avoids the trend of making browser.js do ever more stuff itself.
|
||
Updated•11 months ago
|
|
||
Comment 1•11 months ago
|
||
kicking inessential work out of the MVP scope and into the 'fast follow' bucket
|
|
||
Comment 2•10 months ago
|
||
In bug 1848160, I had to insert a bit of a strange _maybeToggleSidebar into the ShoppingSidebarManager, so that we could record exposure telemetry separately for product page visits vs the sidebar actually getting displayed. This is a reminder to clean up and refactor that code (for instance, we now have TabSelect call _updateVisibility which calls onLocationChange...that's definitely not great and makes it really hard to reason about the onLocationChange cases due to navigation vs the TabSelect cases due to tab switching)
|
Assignee | |
Updated•9 months ago
|
|
|
Assignee | |
Comment 3•9 months ago
|
||
|
||
Updated•9 months ago
|
|
|
||
Comment 4•8 months ago
|
||
Moving "fast follow" items to top-level in the shopping backlog. Apologies for bug spam
Pushed by nbaumgardner@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f6d849983128 Refactor shopping code out of browser.js. r=shopping-reviewers,Gijs
|
||
Comment 6•8 months ago
|
||
Backed out for causing failures on browser_shopping_urlbar.js
- backout: https://hg.mozilla.org/integration/autoland/rev/bad2aa60b1b17048aab1068d0a3ca9896c01c856
- push: https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=c1cayoDFQ2G1-6y_zGA9vg.0&revision=f6d8499831289d48d96376145befce3eb4d93690
- failure log: https://treeherder.mozilla.org/logviewer?job_id=434706492&repo=autoland&lineNumber=5020
[task 2023-11-02T14:58:46.543Z] 14:58:46 INFO - TEST-PASS | browser/components/shopping/tests/browser/browser_shopping_urlbar.js | Shopping sidebar closed in new window -
[task 2023-11-02T14:58:46.543Z] 14:58:46 INFO - Console message: [JavaScript Warning: "This page is in Quirks Mode. Page layout may be impacted. For Standards Mode use <!DOCTYPE html>." {file: "https://example.com/product/B09TJGHL5F" line: 0}]
[task 2023-11-02T14:58:46.544Z] 14:58:46 INFO - Buffered messages finished
[task 2023-11-02T14:58:46.544Z] 14:58:46 INFO - TEST-UNEXPECTED-FAIL | browser/components/shopping/tests/browser/browser_shopping_urlbar.js | Test timed out -
[task 2023-11-02T14:58:46.545Z] 14:58:46 INFO - GECKO(8540) | MEMORY STAT | vsize 928MB | vsizeMaxContiguous 1293MB | residentFast 246MB | heapAllocated 102MB
[task 2023-11-02T14:58:46.546Z] 14:58:46 INFO - TEST-OK | browser/components/shopping/tests/browser/browser_shopping_urlbar.js | took 45039ms
[task 2023-11-02T14:58:46.546Z] 14:58:46 INFO - Not taking screenshot here: see the one that was previously logged
[task 2023-11-02T14:58:46.547Z] 14:58:46 INFO - TEST-UNEXPECTED-FAIL | browser/components/shopping/tests/browser/browser_shopping_urlbar.js | Found a tab after previous test timed out: https://example.com/product/B09TJGHL5F -
[task 2023-11-02T14:58:46.547Z] 14:58:46 INFO - checking window state
[task 2023-11-02T14:58:46.548Z] 14:58:46 INFO - Not taking screenshot here: see the one that was previously logged
[task 2023-11-02T14:58:46.549Z] 14:58:46 INFO - TEST-UNEXPECTED-FAIL | browser/components/shopping/tests/browser/browser_shopping_urlbar.js | Found a browser window after previous test timed out -
[task 2023-11-02T14:58:46.549Z] 14:58:46 INFO - GECKO(8540) | must wait for focus
Pushed by nbaumgardner@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/66a36c6e56c8 Refactor shopping code out of browser.js. r=shopping-reviewers,Gijs
|
||
Comment 8•8 months ago
|
||
Backed out for bc failure on browser_shopping_urlbar.js
Backout link: https://hg.mozilla.org/integration/autoland/rev/63221dffde4f2b6c134c16fb540dea75d856626d
Log link: https://treeherder.mozilla.org/logviewer?job_id=434790591&repo=autoland&lineNumber=5025
Pushed by nbaumgardner@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/1995198e0bee Refactor shopping code out of browser.js. r=shopping-reviewers,Gijs
|
||
Comment 10•8 months ago
|
||
| bugherder | ||
Description
•