1901979 - The Review Checker is displayed in a private window for a PDP if the user interacts with the normal window

Status: VERIFIED FIXED

(Firefox :: Shopping, defect, P1)

Description

[Rares Doghi, Desktop QA]

Attachment: Window2.mp4

Found in

• Nightly 129.0a1 (2024-06-11)

Affected versions

• Nightly 129.0a1 (2024-06-11)
• Beta 128
• Release 127.0 (64-bit)

Affected platforms

• All

Preconditions

• browser.shopping.experience2023.enabled - true
  browser.shopping.experience2023.optedIn - 1

Steps to reproduce

1. Open a Private Window.
2. Reach any product details page on Amazon.
3. Click inside the Normal window and Open a new Tab. (If youre on a product details page in the normal window Simply open the Review Checker.)
4. Go back to the Private window and Hit the Back button.

Expected result

• The Review Checker should not be displayed at all in a Private window.
  Going back to the Search results should close the Private Window automatically.

Actual result

• The Review Checker is opened when the user interacts with the Normal Window.
  Going back from the Product Details page in the Private window will keep the Sidebar open.

Regression range
Not a regression.

Comment 1

[:Gijs (he/him)]

Looks like https://searchfox.org/mozilla-central/rev/4582d908c17fbf7924f5699609fe4a12c28ddc4a/browser/components/shopping/ShoppingSidebarParent.sys.mjs#227 needs to bail out for private browsing windows.

Comment 2

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Note, even simpler steps to repro:

1. Open a private window to an amazon product page
2. Toggle the browser.shopping.experience2023.enabled pref to true
3. The sidebar appears in the private window, but it shouldn't.

mozregression points to the patch for bug 1845842.

Comment 3

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Attachment: Bug 1901979 - Ensure shopping code never runs in private windows. r?gijs!,niklas

Comment 4

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Attachment: Bug 1901979 - Ensure shopping code never runs in private windows. r?gijs!,niklas

• Rearrange the ShoppingSidebarManagerClass to clearly separate
  public and private APIs.

• Ensure all public methods include a PBM check and add a comment
  encouraging future refactorings to preserve this property of the
  public API as a whole.

• Also add a check at the IPC layer, updating the child and parent
  actor code to bail out if a message is received in a private window.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e99ed4f09ed0
Ensure shopping code never runs in private windows. r=Gijs

Comment 6

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/e99ed4f09ed0

Comment 7

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Comment on attachment 9407294 [details]
Bug 1901979 - Ensure shopping code never runs in private windows. r?gijs!,niklas

Beta/Release Uplift Approval Request

• User impact if declined: Leadership would like to roll out the review checker feature more widely (ideally in a dot release for 127). This bug is the only blocker to that wider rollout.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Two different STR are covered in the description and comment 2 of the bug.
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): The patch is small and covered by automated tests, and only adds checks to be sure that we don't run the review checker code in private windows. The review checker feature is currently preffed off and any release would be via a Nimbus-controlled rollout, so if we encounter additional bugs, we could reverse the rollout.
• String changes made/needed: None
• Is Android affected?: No

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9407294 [details]
Bug 1901979 - Ensure shopping code never runs in private windows. r?gijs!,niklas

Approved for 128.0b4.

Comment 9

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/c25957a770a1

Comment 10

[Rares Doghi, Desktop QA]

This issue is Verified as fixed in our latest Nightly build 129.0a1 (2024-06-16) as well as Beta 128.0b4.

Comment 11

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-release/rev/41538cb66989

Comment 12

[Pascal Chevrel:pascalc]

Comment on attachment 9407294 [details]
Bug 1901979 - Ensure shopping code never runs in private windows. r?gijs!,niklas

Approved for our next 127 dot release.

Comment 13

[Rares Doghi, Desktop QA]

Verified as fixed in our latest Release build 127.0.1.