1846290 - The “Thanks for your feedback” message is not aligned with the Address Bar results

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P1)

Description

[Carmen Fat [:cfat] - Ecosystem QA]

Attachment: message not aligned.jpg

[Affected versions]:

• Firefox Nightly 117.0a1 - Build ID: 20230730210800

[Affected Platforms]:

• Windows 10 x64
• Linux Ubuntu 20.04 x64
• macOS 12.6.1

[Prerequisites]:

• Set browser.urlbar.pocket.featureGate to “true”.
• Set browser.urlbar.bestMatch.enabled to “true”.
• Set browser.search.region to “US”.

[Steps to reproduce]:

1. Open the browser with the profile from the prerequisites.
2. Type “breakfast” in the Address Bar.
3. Click the “Feedback” button from the Pocket suggestion.
4. Click the “Show less frequently” option.
5. Observe the message that appears under the Pocket suggestion.

[Expected result]:

• The Firefox logo and text of the message are correctly aligned with the rest of the favicons and results.

[Actual result]:

• The Firefox logo and text of the message are not aligned with the rest of the favicons and results.

[Notes]:

• The issue is not reproducible on Firefox Beta 116 (Build ID: 20230724170120)
• Attached is a screenshot of the issue.

Comment 1

[Drew Willcoxon :adw]

Thanks Carmen, I'll bump this down to S4 since it's purely a visual problem.

Comment 2

[Drew Willcoxon :adw]

I've asked Josh for clarification on alignment w/r/t Pocket suggestions as well as other types.

Comment 3

[Drew Willcoxon :adw]

Attachment: Bug 1846290 - Properly align the feedback acknowledgment's icon and text.

Per UX:

• The acknowledgment's app icon should be aligned with favicons
• The text should be aligned with the other text in the view

This patch works regardless of whether rich suggestions are enabled.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/812653ad046d
Properly align the feedback acknowledgment's icon and text. r=dao

Comment 5

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/812653ad046d

Comment 6

[Drew Willcoxon :adw]

Comment on attachment 9348025 [details]
Bug 1846290 - Properly align the feedback acknowledgment's icon and text.

Beta/Release Uplift Approval Request

• User impact if declined: This is required for the Pocket suggestions feature we intend to ship as an experiment in 117.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Should be clear from comments
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Small CSS-only patch that affects a feature that's preffed off by default. This code has test coverage but this particular bug is a visual problem that can't really have an automated test.
• String changes made/needed:
• Is Android affected?: No

Comment 7

[Carmen Fat [:cfat] - Ecosystem QA]

We verified this issue on the latest Firefox Nightly 118.0a1 (Build ID: 20230809213044) on Windows 10 x64, macOS 12.6.1, and Ubuntu 20.04 x64.

• The Firefox logo and text of the “Thanks for your feedback” message are correctly aligned with the rest of the Address Bar results.

Comment 8

[Dianna Smith [:diannaS]]

Comment on attachment 9348025 [details]
Bug 1846290 - Properly align the feedback acknowledgment's icon and text.

Approved for 117.0b6

Comment 9

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/2e70ee50bcde

Comment 10

[Carmen Fat [:cfat] - Ecosystem QA]

We verified this issue on the latest Firefox Beta 117.0b6 (Build ID: 20230810181819) on Windows 10 x64, macOS 12.6.1, and Ubuntu 20.04 x64.

• The Firefox logo and text of the “Thanks for your feedback” message are correctly aligned with the rest of the Address Bar results.