1880865 - The “Thanks for your feedback” message is not aligned with the Address Bar results

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P1)

Description

[Carmen Fat [:cfat] - Ecosystem QA]

Attachment: misaligned message.jpg

[Affected versions]:

• Firefox Nightly 125.0a1 - Build ID: 20240219095613

[Affected Platforms]:

• Windows 10 x64
• macOS 12.6.1
• Linux Ubuntu 20.04 x64

[Prerequisites]:

• Have the following prefs set with the values to enable the feature:
  browser.search.region = US (connect to a VPN server if outside US)
  browser.urlbar.quicksuggest.rustEnabled = true
  browser.urlbar.suggest.yelp = true
  browser.urlbar.yelp.featureGate = true
  browser.urlbar.yelp.priority = true

[Steps to reproduce]:

1. Open the browser with the profile from the prerequisites.
2. Type the “pet shop” string in the Address Bar.
3. Click the “Feedback” button from the Yelp suggestion.
4. Click the “Show less frequently” option.
5. Observe the message that appears under the Yelp suggestion.

[Expected result]:

• The Firefox logo and text of the message are correctly aligned with the rest of the favicons and results.

[Actual result]:

• The Firefox logo and text of the message are not aligned with the rest of the favicons and results.

[Notes]:

• This issue affects Yelp results displayed on both Top Pick and Firefox Suggest locations.
• Attached is a screenshot of the issue.

Comment 1

[Drew Willcoxon :adw]

Attachment: Bug 1880865 - Properly align the urlbar feedback acknowledgment message.

This introduces two new variables for 16px icon inline margins. We can use these
any time we need to align something with the "standard" 16px icons and text, no
matter whether rich suggestions are enabled or not.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c0e0d295e686
Properly align the urlbar feedback acknowledgment message. r=dao,desktop-theme-reviewers

Comment 3

[Drew Willcoxon :adw]

Comment on attachment 9382763 [details]
Bug 1880865 - Properly align the urlbar feedback acknowledgment message.

Beta/Release Uplift Approval Request

• User impact if declined: This is necessary for the Yelp suggestions experiment that will target 124.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce: Should be clear from earlier comments
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This is a CSS-only styling change that properly aligns a message in the urlbar panel. The message isn't usually shown. It's only shown after the user opens the urlbar result menu (which is labeled "Feedback" for some suggestions) and chooses a command in it.
• String changes made/needed:
• Is Android affected?: No

Comment 4

[Drew Willcoxon :adw]

• Needs manual test from QE?: No

Oops sorry, I meant yes!

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/c0e0d295e686

Comment 6

[Dianna Smith [:diannaS]]

Comment on attachment 9382763 [details]
Bug 1880865 - Properly align the urlbar feedback acknowledgment message.

Approved for 124.0b7

Comment 7

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/e75ef8ca198b

Comment 8

[Carmen Fat [:cfat] - Ecosystem QA]

I have verified this issue on the latest Firefox Nightly 125.0a1 (Build ID: 20240303213416) on Windows 10 x64, Ubuntu 20.04 x64, and macOS 12.6.1.

• The Firefox logo and “Thanks for your feedback” message are correctly aligned with the rest of the favicons and results.

Comment 9

[Carmen Fat [:cfat] - Ecosystem QA]

I have verified this issue on Firefox Beta 124.0b7 (Build ID: 20240304091753) on Windows 10 x64, Ubuntu 20.04 x64, and macOS 12.6.1.

• The Firefox logo and “Thanks for your feedback” message are correctly aligned with the rest of the favicons and results.