184646 - Venkman doesn't add itself to the Firefox UI

Status: RESOLVED FIXED

(Other Applications Graveyard :: Venkman JS Debugger, enhancement)

Description

[jsp]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.3a) Gecko/20021207 Phoenix/0.5
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.3a) Gecko/20021207 Phoenix/0.5

When Venkman is installed on Mozilla, it adds itself to the "Tools>Web
Development" menu. On Phoenix, it doesn't get added to the menu system,
presumably because the "Tools" menu doesn't have a "Web Development" submenu.

I like Phoenix, I like Venkman, and I'd like 'em both better if they played
together nicely. (Actually, for the uninitiated, they play together well enough,
just not conveniently: you can start Venkman with "phoenix -venkman".)

Reproducible: Always

Steps to Reproduce:
1. Launch Phoenix.
2. Install Venkman (from http://www.hacksrus.com/~ginda/venkman/).
3. Look around for a menu item.

Actual Results:  
No menu item to be found.

Expected Results:  
Ideally, Venkman would create a menu or toolbar item for itself.  I'm not sure
where it should go; maybe it could just add a toolbar item to those available to
be put into the toolbar, which would allow users to decide where it belongs.

It might make more sense to create a separate Phoenix extension to update the
UI, rather than changing the XPI.

Comment 1

[Timur Safin]

Probably it should be filed as another bug, but IMHO it is another appearence of
some incompatibility of Venkman with the Phoenix.
I wasn't able to close the opned unneeded sources at the Venkman/Phoenix, it
reports me 
Internal error dispatching command ``close-source-tab''.
2147500037
Internal error dispatching command ``close-source-tab''.
2147500037
Every time I try to do "Close Tab" command.

Comment 2

[Robert Ginda]

you can now launch venkman by typing x-jsd:debugger in the url bar.  You can
bookmark it too.

Comment 3

[jsp]

This is definitely a step in the right direction; I've been taking advantage of
it for the last couple of weeks. I still think it would be nice to put it into a
menu, but it's less pressing now that there's a reasonably convenient way to
launch the debugger from within the browser.

Comment 4

[Chris Neale]

Attachment: patch to overlay venkman menu item on Firebird Tools menu

modifications to content/ contents.rdf and venkman-overlay.xul are all that are
required, usually

contents.rdf:
	chrome:extension="true"

    <RDF:li resource="chrome://browser/content/browser.xul"/>

  <RDF:Seq about="chrome://browser/content/browser.xul">
    <RDF:li>chrome://venkman/content/venkman-overlay.xul</RDF:li>
  </RDF:Seq>

venkman-overlay.xul:
<menupopup id="menu_ToolsPopup">
  <menuitem insertafter="javascriptConsole" label="&venkmanCmd.label;"
    accesskey="&venkmanCmd.akey;" oncommand="start_venkman()"/>
</menupopup>

Comment 5

[Robert Ginda]

Comment on attachment 135795 [details] [diff] [review]
patch to overlay venkman menu item on Firebird Tools menu

r=rginda

Comment 6

[James Ross]

Bug 247507 is where I'm putting the patch for Firefox 0.9+ support. This bug
will be fixed by it.

Comment 7

[Ben Fowler]

Is this susceptible to being RESOLVEd FIXED (by checkin for Bug 247507)

Comment 8

[James Ross]

I'm pretty sure this is fixed by bug 247507.

Any new issues with Firefox support should be in other or new bugs.