1846465 - Make source editor search UI persistent

Status: RESOLVED FIXED

(DevTools :: Source Editor, defect, P2)

Description

[ris58h]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:109.0) Gecko/20100101 Firefox/115.0

Steps to reproduce:

1. Open some site with CSS.
2. Open Developer Tools > Style Editor.
3. Focus a content of a stylesheet and press Ctrl+F (Cmd+F on macOS).
4. Try to search something.

Actual results:

After a user hits enter search results are highlighted but search interface disappears and focus goes to the editor.

Expected results:

Same as for Find in Page. Hitting Enter shouldn't hide the search interface and subsequent Enter keystroke should jump to the next instance.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'DevTools::Style Editor' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[Julian Descottes [:jdescottes]]

Thanks, although I feel like this is more or less a duplicate of the various bugs under the meta Bug 973117. The Style Editor search UI is lacking and needs to be overhauled.

Comment 3

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1846465 - [devtools] Make codemirror 5 built-in search UI persistent. r=#devtools.

Overriding the search shortcut allows us to execute the findPersistent command,
which prevents the search input to be closed when the user hit Enter.

A test is added to cover the new functionality.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a0c8e81abd31
[devtools] Make codemirror 5 built-in search UI persistent. r=devtools-reviewers,ochameau.

Comment 6

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/a0c8e81abd31