973117 - [meta] Style Editor Search

Status: NEW

(DevTools :: Style Editor, task, P3)

Description

[Matt Basta [:basta]]

Currently if you press cmd+f in the style editor, you get the equivalent of prompt(), which is really crappy and hard to use. Please add a search tool along the lines of what is provided in the Debugger tab.

Comment 1

[Patrick Brosset <:pbro>]

Inspector bug triage (filter on CLIMBING SHOES).

Comment 4

[Patrick Brosset <:pbro>]

Inspector bug triage (filter on CLIMBING SHOES).

Comment 6

[Patrick Brosset <:pbro>]

We should use this bug to make the search as similar to the one in the debugger as possible, and as feature complete as possible:
- search as you type
- go to next/prev match
- search across all files

Comment 7

[Justin Peter]

First of all: this is absolutely something that would be appreciated; even just the ability to see how many results there are for a search and pressing enter to go through them would be a significant improvement over the status quo.

Second: there seem to be about half a dozen overlapping bugs about this, most of which have duplicates, and most of which are duplicates of each other and/or this bug, namely:

• bug 889571
• bug 934624
• bug 1036702
• bug 1171644
• bug 1362030

(Ultimately, about half the dependencies of bug 1701622.)

Comment 8

[Sebastian Zartner [:sebo]]

The bugs linked in the previous comment are all related but addressing different features.
So maybe this should be turned into a meta-bug for all search features and should block bug 1701622. Multi-source search may still be kept separately because its UI is different from the in-source search (if we want to align it with the search features in the Debugger).

Honza, what do you think?

Sebastian

Comment 9

[Jan Honza Odvarko [:Honza] (always need-info? me)]

(In reply to Sebastian Zartner [:sebo] from comment #8)

So maybe this should be turned into a meta-bug for all search features and should block bug 1701622.

Done, thank you for pointing this out Sebastian.

(let's have this one meta for all search related features in-source & multi-source at last atm)

Comment 10

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Confusing search UX has also been mentioned on Connect.

https://connect.mozilla.org/t5/ideas/dev-tools-gt-style-editor-gt-find-needs-to-work-better-maybe/idi-p/54590

"If you try to search for anything via Ctrl+F and hit Enter to submit the search, it closes the text box and goes to the first match (if one exists). If that wasn't the match you were looking for, you need to reopen the search and try again."

Honza