1846549 - Window closed due to all its tab(s) moving to another window should not end up in the "Reopen Closed ..." stack

Status: ASSIGNED

(Firefox :: Session Restore, defect, P3)

Description

[Asif Youssuff]

Steps to reproduce:

1. Open Firefox
2. Open any two new pages - I control-clicked two random Pocket Stories on the new tab page
3. detach any of the tabs opened in step 2 into a new window (drag out the tab)
4. drag the tab you detached back into the window you initially dragged it from
5. do "control-shift-t"

What happens:

The reattached tab (from step 4) is detached again, AND we have the reattached tab in the window that I initially opened when opening Firefox. The tab has been duplicated.

Expected result:

reopen closed tab does nothing.

mozregression:

 4:49.97 INFO: Narrowed integration regression window from [f1fb2652, 15a57a8c] (3 builds) to [f1fb2652, a44656c2] (2 builds) (~1 steps left)
 4:49.97 INFO: No more integration revisions, bisection finished.
 4:49.97 INFO: Last good revision: f1fb26526a2e8e7d9539b3f975817b0578e1bc0c
 4:49.97 INFO: First bad revision: a44656c2ad83d278286aa51507864e53a3911df3
 4:49.97 INFO: Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=f1fb26526a2e8e7d9539b3f975817b0578e1bc0c&tochange=a44656c2ad83d278286aa51507864e53a3911df3

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1833416

:sclements, since you are the author of the regressor, bug 1833416, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 2

[Sarah Clements [:sclements]]

I don't think this is a bug, its a side effect of the behavior for the ctrl|cmd + shift + T shortcut changing in 116 to reopen the last closed tab or window, in the order closed.

Technically, you closed a window when you dragged the tab out to a window, and then back to the original window. The exact same behavior happens if you use repeat those steps and use the ctrl|cmd + shift + N shortcut to reopen the last closed window.

Comment 3

[Dão Gottwald [:dao]]

(In reply to Sarah Clements [:sclements] from comment #2)

Technically, you closed a window when you dragged the tab out to a window, and then back to the original window. The exact same behavior happens if you use repeat those steps and use the ctrl|cmd + shift + N shortcut to reopen the last closed window.

Thanks for investigating! So this kind of makes sense technically, but from a user's perspective the window wasn't really closed in the sense that you might want to reopen it, it was rather merged into another window. I think we should treat the current behavior as a bug, albeit not a high-priority one and not a regression. Wdyt?

Comment 4

[Sarah Clements [:sclements]]

(In reply to Dão Gottwald [:dao] from comment #3)

(In reply to Sarah Clements [:sclements] from comment #2)

Technically, you closed a window when you dragged the tab out to a window, and then back to the original window. The exact same behavior happens if you use repeat those steps and use the ctrl|cmd + shift + N shortcut to reopen the last closed window.

Thanks for investigating! So this kind of makes sense technically, but from a user's perspective the window wasn't really closed in the sense that you might want to reopen it, it was rather merged into another window. I think we should treat the current behavior as a bug, albeit not a high-priority one and not a regression. Wdyt?

hrm, if we want to treat it as not a deliberate window closure we should probably apply it to the ctrl|cmd + shift + N shortcut as well, otherwise that would be inconsistent.

Comment 5

[Asif Youssuff]

Full disclosure, I blogged about this bug and the regressing bug: https://www.quippd.com/writing/2023/08/02/how-firefox-loses-when-it-tries-to-copy-chrome.html and I think that it is obvious that this is a bug (and a regression) -- this behavior is not present in Chrome (which has the desired behavior quoted in bug 1833416) nor in Firefox prior to 1833416.

Comment 6

[Sarah Clements [:sclements]]

(In reply to Asif Youssuff from comment #5)

Full disclosure, I blogged about this bug and the regressing bug: https://www.quippd.com/writing/2023/08/02/how-firefox-loses-when-it-tries-to-copy-chrome.html and I think that it is obvious that this is a bug (and a regression) -- this behavior is not present in Chrome (which has the desired behavior quoted in bug 1833416) nor in Firefox prior to 1833416.

Yeah, we're not trying to copy Chrome. Word of advice, trashing our work and bragging about it is pretty rude, especially if you want your bug fixed.

Comment 7

[Dão Gottwald [:dao]]

(In reply to Sarah Clements [:sclements] from comment #4)

(In reply to Dão Gottwald [:dao] from comment #3)

(In reply to Sarah Clements [:sclements] from comment #2)

Technically, you closed a window when you dragged the tab out to a window, and then back to the original window. The exact same behavior happens if you use repeat those steps and use the ctrl|cmd + shift + N shortcut to reopen the last closed window.

Thanks for investigating! So this kind of makes sense technically, but from a user's perspective the window wasn't really closed in the sense that you might want to reopen it, it was rather merged into another window. I think we should treat the current behavior as a bug, albeit not a high-priority one and not a regression. Wdyt?

hrm, if we want to treat it as not a deliberate window closure we should probably apply it to the ctrl|cmd + shift + N shortcut as well, otherwise that would be inconsistent.

Yes.

Comment 8

[Sarah Clements [:sclements]]

I can probably look into this but it won't be anytime soon. I'll assign it to myself so I don't forget, but if anyone wants to take it (and would like guidance on a fix) lmk.