Closed
Bug 1846557
Opened 2 years ago
Closed 2 years ago
Fix cta-link style for additional button in feature callout
Categories
(Firefox :: Messaging System, task)
Firefox
Messaging System
Tracking
()
RESOLVED
FIXED
118 Branch
People
(Reporter: jprickett, Assigned: jprickett)
References
Details
Attachments
(1 file)
48 bytes,
text/x-phabricator-request
|
RyanVM
:
approval-mozilla-beta+
|
Details | Review |
No description provided.
Assignee | ||
Comment 1•2 years ago
|
||
Assignee | ||
Comment 2•2 years ago
|
||
[Tracking Requested - why for this release]:
We need this small style change to support designs for an experiment we plan to run in 116 beta.
tracking-firefox116:
--- → ?
Pushed by jprickett@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5940c61bf924
Fix cta-link additional button styles for feature callout r=aminomancer
Comment 4•2 years ago
|
||
do you mean 117 beta? Fx116 is already in release
Flags: needinfo?(jprickett)
Assignee | ||
Comment 5•2 years ago
|
||
Yes, 117. My mistake!
Comment 6•2 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox118:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 118 Branch
Assignee | ||
Comment 7•2 years ago
|
||
Comment on attachment 9346722 [details]
Bug 1846557 - Fix cta-link additional button styles for feature callout r=aminomancer
Beta/Release Uplift Approval Request
- User impact if declined: We'll have to delay an experiment from 117 Beta to 118 Release.
- Is this code covered by automated tests?: Yes
- Has the fix been verified in Nightly?: Yes
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: Bug 1846803
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): This is a small styling change to meet the designs of an experimental feature. The feature will only be enabled for a small population of users through an experiment, and will not be exposed to the entire population.
- String changes made/needed: None
- Is Android affected?: No
Attachment #9346722 -
Flags: approval-mozilla-beta?
Updated•2 years ago
|
Comment 8•2 years ago
|
||
Comment on attachment 9346722 [details]
Bug 1846557 - Fix cta-link additional button styles for feature callout r=aminomancer
Approved for 117.0b3.
Attachment #9346722 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Updated•2 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•