1846803 - Fix some remaining issues with micro survey feature callout experiments

Status: RESOLVED FIXED

(Firefox :: Messaging System, defect)

Description

[Shane Hughes [:aminomancer]]

1. newtabFeatureCalloutCheck callouts don't correctly track their tour prefs, since the tour pref browser.newtab.feature-tour is not in SpecialMessageActions' allowedPrefs
2. checkboxes and radios aren't the right width/height (fixed in bug 1846782, but that won't land till 118)
3. the primary button transitions smoothly when it changes from disabled to active
4. when clicking the primary button, its own action is replaced with an array of the active multi-select items' actions. which works for some cases, but in this case we want the primary button to set the tour pref AND do the action of the active multi-select item. we could add the set tour pref action to each of the multi-select items to work around this issue, but that's a lot of redundant code. it's better if we just append the multi-select items' actions to the clicked button's actions (if it has any).

Comment 1

[Shane Hughes [:aminomancer]]

Actually we don't need to fix #2 with feature changes. That will be handled in the experiment recipe.

Comment 2

[Shane Hughes [:aminomancer]]

Attachment: Bug 1846803 - Final adjustments to feature callout surveys. r=jprickett

1. Allow messages to set browser.newtab.feature-tour
2. Prevent individual element transitions in feature callouts
3. Change how multi-select item actions are processed so that, when
   clicking the primary button, its action is performed as well as the
   action of the selected item.
4. Remove some built-in styles that can be set by experiment recipe
5. Allow messages to override the tour pref for newtab and pdfjs

Comment 3

[Shane Hughes [:aminomancer]]

Comment on attachment 9347002 [details]
Bug 1846803 - Final adjustments to feature callout surveys. r=jprickett

Beta/Release Uplift Approval Request

• User impact if declined: We'll have to delay an experiment from 117 Beta to 118 Release.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: Bug 1846557
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Just some small fixes to get an experimental feature working. The feature will only be enabled for a small audience of Beta users enrolled in an experiment. The Release audience won't be exposed at all.
• String changes made/needed:
• Is Android affected?: No

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c2b5ba04825c
Final adjustments to feature callout surveys. r=jprickett

Comment 5

[Shane Hughes [:aminomancer]]

^ Regarding this uplift request, we also need to uplift bug 1846557 for the experiment. If it makes the uplift easier, I can provide a combined uplift patch. I figured it's probably better to keep the blame intact so we'll file separate uplift requests.

Comment 6

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/c2b5ba04825c

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9347002 [details]
Bug 1846803 - Final adjustments to feature callout surveys. r=jprickett

Approved for 117.0b3.

Comment 8

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/8aec3eecd393