1846581 - Swipe tracker for forward/back too sensitive now

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect, P3)

Description

[Robert Mader [:rmader]]

While the change from bug 1753033 is generally a big improvement in my testing on several devices (thanks a lot!), there's one issue: the forward/back gestures feel a bit too sensitive now (in my and a friends opinion). So that maybe needs adjustment now.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1753033

:ren, since you are the author of the regressor, bug 1753033, could you take a look?

For more information, please visit BugBot documentation.

Comment 2

[Emilio Cobos Álvarez [:emilio]]

Probably this needs a tweak. Robert, can you test in your device if a macOS/windows-like similar value helps there?

Comment 3

[Johan Lorenzo [:jlorenzo]]

Regression triage: We see the author of the original patch is not a MoCo employee. Could you have a look at this bug, :botond?

Comment 4

[Botond Ballo [:botond]]

The regressing bug is a nightly-only change. Accordingly, I'm marking this as "firefox117: unaffected".

We will address this before rolling out the change to the release population. We're not sure yet if the pref values put in place on nightly are what we'll want to ship to release, as we've had mixed feeback from nightly users (e.g. in bug 1846180); we'll continue to monitor the feedback and evaluate.

Comment 5

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1846581 - Change how we enable pixel deltas on Nightly to match the documentation. r=hiro,botond,rmader

The pref value 0 is meant to be auto, and subject to change. So use that
rather than flipping the pref default? Otherwise we can make this a bool
pref instead probably.

Comment 6

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1846581 - Deal with pixel-based and page-based units separately in the swipe tracker. r=hiro,botond,rmader

Make the pixel size match Windows, and retain the page size behavior.

Depends on D186107

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7860798c30b3
Change how we enable pixel deltas on Nightly to match the documentation. r=hiro
https://hg.mozilla.org/integration/autoland/rev/51b9c3015af0
Deal with pixel-based and page-based units separately in the swipe tracker. r=hiro
https://hg.mozilla.org/integration/autoland/rev/938e64dd7f8b
apply code formatting via Lando

Comment 8

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/7860798c30b3
https://hg.mozilla.org/mozilla-central/rev/51b9c3015af0
https://hg.mozilla.org/mozilla-central/rev/938e64dd7f8b