1846741 - Fix and reenable `sub-sample-buffer-stitching.html`

Status: ASSIGNED

(Core :: Web Audio, defect)

Description

[Paul Adenot (:padenot)]

It was disabled on desktop in https://bugzilla.mozilla.org/show_bug.cgi?id=1533762. It now fails on mobile because mobile is using the same code as desktop after https://bugzilla.mozilla.org/show_bug.cgi?id=1833654.

Comment 1

[Paul Adenot (:padenot)]

Attachment: debug.png

This is dumping the file using the attached patch, opening in audacity, splitting the two channels (right click on the track, split), centering both tracks, so they are at the centre of the stereo field using the panning sliders on the left, inverting one track, mixing both tracks to a new track, and applying 50dB of gain to the track.

We see there seem to be an error that accumulate.

Comment 2

[Paul Adenot (:padenot)]

What's even more concerning is that this is supposed to be the no-op case, without a resampler.

Comment 3

[Paul Adenot (:padenot)]

Attachment: Bug 1846741 - Add a way to dump an AudioBuffer to an f32 WAV in Web Audio API WPTs. r?karlt

Comment 4

[Paul Adenot (:padenot)]

Attachment: WIP: Bug 1846741 - DO NOT LAND dump a wav in sub-sample-buffer-stitching.html

Depends on D185168

Comment 5

[Paul Adenot (:padenot)]

This was on desktop linux, running the test after removing the expectation .ini that makes it skipped.

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:karlt, could you have a look please?

For more information, please visit BugBot documentation.