1833654 - Make Android builds use f32 audio instead of int16_t

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, task)

Description

[Paul Adenot (:padenot)]

It's time, Android devices have had fast f32 hardware for ages now, and it's easier to use the same paths everywhere -- Android has been using a lot of f32 code anyway, anytime it's not just simple playback (but also for keeping sample data, maybe we'll have to do something there).

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:jimm, could you have a look please?

For more information, please visit BugBot documentation.

Comment 2

[Paul Adenot (:padenot)]

Attachment: Bug 1833654 - Remove libtremor from the tree. r?karlt

Depends on D176158

Comment 3

[Paul Adenot (:padenot)]

Attachment: Bug 1833654 - Switch android to f32. r?karlt,alwu

This is removing defines that control the preferred sample type and fixes all
uses.

Depends on D181519

Comment 4

[Paul Adenot (:padenot)]

Attachment: Bug 1833654 - Introduce InflatableShortBuffer. r?alwu

This allows getting audio in int16_t from e.g. a system API and converting it
without reallocation to f32.

Depends on D183275

Comment 5

[Paul Adenot (:padenot)]

Attachment: Bug 1833654 - Add logging statements to RemoteDataDecoder.cpp r?#media-playback-reviewers,alwu

Depends on D183277

Comment 6

[Paul Adenot (:padenot)]

Attachment: Bug 1833654 - Remove the second argument to AudioTrimmer::HandleDecodedResult. r?alwu

It's very misleading if the decoder isn't doing batches but has latency, such as on
Android, since it doesn't match input and output packets.

Depends on D183278

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fc7ba125c2fe
Switch android to f32. r=alwu,geckoview-reviewers,owlish DONTBUILD
https://hg.mozilla.org/integration/autoland/rev/b232ec1bbc2d
Remove libtremor from the tree. r=karlt,media-playback-reviewers,sylvestre DONTBUILD
https://hg.mozilla.org/integration/autoland/rev/6b087145b67f
Introduce InflatableShortBuffer. r=alwu DONTBUILD
https://hg.mozilla.org/integration/autoland/rev/83e3de80337b
Add logging statements to RemoteDataDecoder.cpp r=alwu,media-playback-reviewers DONTBUILD
https://hg.mozilla.org/integration/autoland/rev/46a61cbfe8a8
Remove the second argument to AudioTrimmer::HandleDecodedResult. r=alwu DONTBUILD

Comment 8

[Cristian Tuns]

Backed out for causing build bustages

• Backout link
• Push with failures
• Failure Log

Comment 9

[Paul Adenot (:padenot)]

Attachment: Bug 1833654 - Disable sub-sample-buffer-stitching.html. r?karlt

THis is investigated in bug 1833654. It's been disabled on desktop (that uses
f32) for a long time, but now the same problem happens on mobile now that it has
been switched to f32.

Depends on D183513

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0a0ec1730ddb
Switch android to f32. r=alwu,geckoview-reviewers,owlish
https://hg.mozilla.org/integration/autoland/rev/37c5b9265487
Remove libtremor from the tree. r=karlt,media-playback-reviewers,sylvestre
https://hg.mozilla.org/integration/autoland/rev/bf88e8a6256c
Introduce InflatableShortBuffer. r=alwu
https://hg.mozilla.org/integration/autoland/rev/c26367197d24
Add logging statements to RemoteDataDecoder.cpp r=alwu,media-playback-reviewers
https://hg.mozilla.org/integration/autoland/rev/ac78317c5c5f
Remove the second argument to AudioTrimmer::HandleDecodedResult. r=alwu
https://hg.mozilla.org/integration/autoland/rev/6cdca3101f3b
Disable sub-sample-buffer-stitching.html. r=karlt

Comment 11

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/0a0ec1730ddb
https://hg.mozilla.org/mozilla-central/rev/37c5b9265487
https://hg.mozilla.org/mozilla-central/rev/bf88e8a6256c
https://hg.mozilla.org/mozilla-central/rev/c26367197d24
https://hg.mozilla.org/mozilla-central/rev/ac78317c5c5f
https://hg.mozilla.org/mozilla-central/rev/6cdca3101f3b