1847179 - Wrong error message displayed when trying to install an unsupported add-on

Status: VERIFIED FIXED

(Firefox for Android :: WebExtensions, defect, P1)

Description

[William Durand [:willdurand]]

Steps to reproduce

1. Go to about:config and set the extensions.webapi.enabled pref to true in Nightly
2. Configure a custom AMO user collection in Fenix, it should NOT have Privacy Badger
3. Open addons.mozilla.org in a new tab
4. Go to the Privacy Badger detail page and try to install the add-on

Expected behavior

An error message saying: "Add-on is not supported" because users (of a custom collection) can only install the add-ons in the custom AMO user collection.

Actual behavior

An error message saying: "Add-on already installed", which is incorrect.

Comment 1

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1847179 - Fix wrong error message displayed when trying to install an unsupported add-on (#3114)

Comment 2

[BMO Github Automation]

Authored by https://github.com/willdurand
https://github.com/mozilla-mobile/firefox-android/commit/3673962544bbcb0ecc6ca566bfbdc695719db646
[main] Bug 1847179 - Fix wrong error message displayed when trying to install an unsupported add-on

Comment 3

[Delia Pop (Android QA)]

Attachment: Add-ons_Snackbar.png

Verified as fixed in latest Nightly 118.0a1 from 08/09 with Samsung Galaxy A53 5G (Android 13). The "Add-on is not supported" snackbar is displayed when attempting to install an add-on that was not previously added to the custom collection.
However, please note that an issue was observed and reported, https://bugzilla.mozilla.org/show_bug.cgi?id=1847956, since the snackbar is displayed overlapping the toolbar when the toolbar position is set to "Bottom".

Comment 4

[Oana Horvath [:ohorvath - out of office]]

Hi William! Is QA required for this work at this moment (I'm asking about the whole feature)? Or should we wait until it's ready to go live?

Comment 5

[William Durand [:willdurand]]

Most of the changes will be QA'ed one way or the other. While we have QA requests filed for some of the work in the "add-ons GA" project, there will always be bugs like this one, which change/fix existing behaviors and for which we'll need one-off QA. In this case, this has been verified in Comment 3 and we do not need more usually. We just need to avoid introducing regressions.